summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* libssh: remove dead code in sftp_qoutebagder/libssh-sftp_quoteDaniel Stenberg2017-12-051-113/+107
| | | | | | | ... by removing a superfluous NULL pointer check that also confuses Coverity. Fixes #2143
* libssh2: remove dead code from SSH_SFTP_QUOTEDaniel Stenberg2017-12-041-4/+4
| | | | | | | | | | | Figured out while reviewing code in the libssh backend. The pointer was checked for NULL after having been dereferenced, so we know it would always equal true or it would've crashed. Pointed-out-by: Nikos Mavrogiannopoulos Bug #2143 Closes #2148
* ssh-libssh.c: please checksrcDaniel Stenberg2017-12-041-1/+1
|
* libssh: fixed dereference in statvfs accessNikos Mavrogiannopoulos2017-12-041-1/+1
| | | | | | | The behavior is now equivalent to ssh.c when SSH_SFTP_QUOTE_STATVFS handling fails. Fixes #2142
* RESOURCES: update spec namesGuitared2017-12-041-9/+9
| | | | Closes #2145
* libssh: corrected use of sftp_statvfs() in SSH_SFTP_QUOTE_STATVFSNikos Mavrogiannopoulos2017-12-031-3/+1
| | | | | | | | | The previous code was incorrectly following the libssh2 error detection for libssh2_sftp_statvfs, which is not correct for libssh's sftp_statvfs. Fixes #2142 Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* libssh: no need to call sftp_get_error as ssh_get_error is sufficientNikos Mavrogiannopoulos2017-12-031-9/+2
| | | | | | Fixes #2141 Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* libssh: fix minor static code analyzer nitsDaniel Stenberg2017-12-021-7/+10
| | | | | | | | | - remove superfluous NULL check which otherwise tricks the static code analyzers to assume NULL pointer dereferences. - fix fallthrough in switch() - indent mistake
* openssl: pkcs12 is supported by boringsslDaniel Stenberg2017-12-021-10/+0
| | | | | | | | Removes another #ifdef for BoringSSL Pointed-out-by: David Benjamin Closes #2134
* travis: use pip2 instead of pipJay Satiro2017-12-021-1/+1
| | | | | | | | | | | .. since now mac osx image expects pip2 or pip3, and doesn't know pip: 0.01s$ pip install --user cpp-coveralls /Users/travis/.travis/job_stages: line 57: pip: command not found Ref: https://github.com/travis-ci/travis-ci/issues/8829 Closes https://github.com/curl/curl/pull/2133
* lib582: do not verify host for SFTPNikos Mavrogiannopoulos2017-12-011-0/+1
| | | | | | | | | | | This SFTP test fails with libssh back-end due to failure to verify the peer. Disable peer verification in the test as there seems to be the intention of the test. Note that the libssh back-end automatically verifies the peer's host using the default known_hosts file. Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* libssh: added SFTP supportNikos Mavrogiannopoulos2017-12-015-19/+1548
| | | | | | | | | | The SFTP back-end supports asynchronous reading only, limited to 32-bit file length. Writing is synchronous with no other limitations. This also brings keyboard-interactive authentication. Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* symbols-in-versions: added new symbols with 7.56.3 versionNikos Mavrogiannopoulos2017-12-011-0/+3
| | | | Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* .travis.yml: added build --with-libsshNikos Mavrogiannopoulos2017-12-011-0/+5
| | | | Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
* libssh2: return CURLE_UPLOAD_FAILED on failure to uploadNikos Mavrogiannopoulos2017-12-012-1/+5
| | | | | | | This brings its in sync with the error code returned by the libssh backend. Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
* libssh2: send the correct CURLE error code on scp file not foundNikos Mavrogiannopoulos2017-12-012-1/+6
| | | | | | | | | | That also updates tests to expect the right error code libssh2 back-end returns CURLE_SSH error if the remote file is not found. Expect instead CURLE_REMOTE_FILE_NOT_FOUND which is sent by the libssh backend. Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
* Added support for libssh SSH SCP back-endNikos Mavrogiannopoulos2017-12-0113-198/+1626
| | | | | | | | | | libssh is an alternative library to libssh2. https://www.libssh.org/ That patch set also introduces support for ECDSA ed25519 keys, as well as gssapi authentication. Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
* RELEASE-NOTES: synced with af8cc7a69Daniel Stenberg2017-12-011-139/+13
|
* curlver: towards 7.57.1Daniel Stenberg2017-12-011-3/+3
|
* lib: don't export all symbols, just everything curl_*W. Mark Kubacki2017-12-011-0/+2
| | | | | | | | | | | | | | | | | Absent any 'symbol map' or script to limit what gets exported, static linking of libraries previously resulted in a libcurl with curl's and those other symbols being (re-)exported. This did not happen if 'versioned symbols' were enabled (which is not the default) because then a version script is employed. This limits exports to everything starting in 'curl_*'., which is what "libcurl.vers" exports. This avoids strange side-effects such as with mixing methods from system libraries and those erroneously offered by libcurl. Closes #2127
* SSL: Avoid magic allocation of SSL backend specific dataJohannes Schindelin2017-12-012-25/+27
| | | | | | | | | | | | | | | | | | | | Originally, my idea was to allocate the two structures (or more precisely, the connectdata structure and the four SSL backend-specific strucutres required for ssl[0..1] and proxy_ssl[0..1]) in one go, so that they all could be free()d together. However, getting the alignment right is tricky. Too tricky. So let's just bite the bullet and allocate the SSL backend-specific data separately. As a consequence, we now have to be very careful to release the memory allocated for the SSL backend-specific data whenever we release any connectdata. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Closes #2119
* examples/xmlstream.c: don't switch off CURL_GLOBAL_SSLDaniel Stenberg2017-12-011-2/+2
| | | | Reported-by: Dima Tisnek
* travis: add boringssl buildDaniel Stenberg2017-11-301-2/+29
| | | | | | | | | | Uses a separate build without --enable-debug and no valgrind. The debug option causes far too many warnings in boringssl's headers (C++ comments, trailing commas etc). Valgrind triggers some false positive errors in thread-local data used by boringssl. Closes #2118
* RELEASE-NOTES: curl 7.57.0curl-7_57_0Daniel Stenberg2017-11-291-7/+26
|
* THANKS: added contributors from 7.57.0 releaseDaniel Stenberg2017-11-291-0/+23
|
* openssl: fix boringssl build againDaniel Stenberg2017-11-271-1/+1
| | | | | | | | commit d3ab7c5a21e broke the boringssl build since it doesn't have RSA_flags(), so we disable that code block for boringssl builds. Reported-by: W. Mark Kubacki Fixes #2117
* curl_ntlm_core.c: use the limits.h's SIZE_T_MAX if providedDaniel Stenberg2017-11-271-0/+3
|
* libcurl-share.3: the connection cache is shareable nowDaniel Stenberg2017-11-271-5/+4
|
* global_init: ignore CURL_GLOBAL_SSL's absenseDaniel Stenberg2017-11-273-10/+9
| | | | | | | | | | | | | | | | | This bit is no longer used. It is not clear what it meant for users to "init the TLS" in a world with different TLS backends and since the introduction of multissl, libcurl didn't properly work if inited without this bit set. Not a single user responded to the call for users of it: https://curl.haxx.se/mail/lib-2017-11/0072.html Reported-by: Evgeny Grin Assisted-by: Jay Satiro Fixes #2089 Fixes #2083 Closes #2107
* ntlm: avoid integer overflow for malloc sizeDaniel Stenberg2017-11-271-2/+18
| | | | | | | | | Reported-by: Alex Nichols Assisted-by: Kamil Dudka and Max Dymond CVE-2017-8816 Bug: https://curl.haxx.se/docs/adv_2017-11e7.html
* wildcardmatch: fix heap buffer overflow in setcharsetDaniel Stenberg2017-11-273-7/+56
| | | | | | | | | | | | | The code would previous read beyond the end of the pattern string if the match pattern ends with an open bracket when the default pattern matching function is used. Detected by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4161 CVE-2017-8817 Bug: https://curl.haxx.se/docs/adv_2017-ae72.html
* url: fix alignment of ssl_backend_data structJay Satiro2017-11-272-31/+30
| | | | | | | | | | | | | | | | | | | | | | | | | - Align the array of ssl_backend_data on a max 32 byte boundary. 8 is likely to be ok but I went with 32 for posterity should one of the ssl_backend_data structs change to contain a larger sized variable in the future. Prior to this change (since dev 70f1db3, release 7.56) the connectdata structure was undersized by 4 bytes in 32-bit builds with ssl enabled because long long * was mistakenly used for alignment instead of long long, with the intention being an 8 byte boundary. Also long long may not be an available type. The undersized connectdata could lead to oob read/write past the end in what was expected to be the last 4 bytes of the connection's secondary socket https proxy ssl_backend_data struct (the secondary socket in a connection is used by ftp, others?). Closes https://github.com/curl/curl/issues/2093 CVE-2017-8818 Bug: https://curl.haxx.se/docs/adv_2017-af0a.html
* ssh: remove check for a NULL pointer (!)Daniel Stenberg2017-11-251-2/+2
| | | | | | | | | | With this check present, scan-build warns that we might dereference this point in other places where it isn't first checked for NULL. Thus, if it *can* be NULL we have a problem on a few places. However, this pointer should not be possible to be NULL here so I remove the check and thus also three different scan-build warnings. Closes #2111
* test: add test for bad UNC/SMB path in file: URLMatthew Kerwin2017-11-242-1/+39
|
* test: add tests to ensure basic file: URLsMatthew Kerwin2017-11-243-1/+85
|
* URL: update "file:" URL handlingMatthew Kerwin2017-11-241-43/+78
| | | | | | | | | | | * LOTS of comment updates * explicit error for SMB shares (e.g. "file:////share/path/file") * more strict handling of authority (i.e. "//localhost/") * now accepts dodgy old "C:|" drive letters * more precise handling of drive letters in and out of Windows (especially recognising both "file:c:/" and "file:/c:/") Closes #2110
* metalink: fix memory-leak and NULL pointer dereferenceDaniel Stenberg2017-11-241-3/+24
| | | | | | Reported by scan-build Closes #2109
* connect: add support for new TCP Fast Open API on LinuxAlessandro Ghedini2017-11-244-5/+28
| | | | | | | | | | | The new API added in Linux 4.11 only requires setting a socket option before connecting, without the whole sento() machinery. Notably, this makes it possible to use TFO with SSL connections on Linux as well, without the need to mess around with OpenSSL (or whatever other SSL library) internals. Closes #2056
* make: fix "make distclean"Daniel Stenberg2017-11-242-9/+3
| | | | | Fixes #2097 Closes #2108
* RELEASE-NOTES: synced with 31f18d272Daniel Stenberg2017-11-231-9/+31
|
* connect: improve the bind error messageJay Satiro2017-11-231-0/+4
| | | | | | | | | | eg consider a non-existent interface eth8, curl --interface eth8 Before: curl: (45) Could not resolve host: eth8 After: curl: (45) Couldn't bind to 'eth8' Bug: https://github.com/curl/curl/issues/2104 Reported-by: Alfonso Martone
* examples/rtsp: clear RANGE again after useDaniel Stenberg2017-11-231-0/+3
| | | | | Fixes #2106 Reported-by: youngchopin on github
* test1264: verify URL with space in host name being rejectedMichael Kaufmann2017-11-222-1/+37
|
* url: reject ASCII control characters and space in host namesDaniel Stenberg2017-11-223-48/+47
| | | | | | | | | | Host names like "127.0.0.1 moo" would otherwise be accepted by some getaddrinfo() implementations. Updated test 1034 and 1035 accordingly. Fixes #2073 Closes #2092
* Curl_open: fix OOM return error correctlyDaniel Stenberg2017-11-211-20/+19
| | | | Closes #2098
* http2: fix "Value stored to 'end' is never read" scan-build errorDaniel Stenberg2017-11-211-1/+0
|
* http2: fix "Value stored to 'hdbuf' is never read" scan-build errorDaniel Stenberg2017-11-211-2/+0
|
* openssl: fix "Value stored to 'rc' is never read" scan-build errorDaniel Stenberg2017-11-211-2/+2
|
* mime: fix "Value stored to 'sz' is never read" scan-build errorDaniel Stenberg2017-11-211-2/+0
|
* Curl_llist_remove: fix potential NULL pointer derefDaniel Stenberg2017-11-211-1/+5
| | | | Fixes a scan-build warning.
View Lorry Controller Status