summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* http: move request-specific header store to urldate from connectdatabagder/http-data-to-curl-easyDaniel Stenberg2020-06-1510-130/+137
| | | | | | | | | | | Since the connection can be used by many independent requests (using HTTP/2 or HTTP/3), things like user-agent and other transfer-specific data MUST NOT be kept connection oriented as it could lead to requests getting the wrong string for their requests. This struct data was lingering like this due to old HTTP1 legacy thinking where it didn't mattered.. Fixes #5566
* CODE_REVIEW.md: how to do code reviews in curlDaniel Stenberg2020-06-132-0/+169
| | | | | | | | | | | Assisted-by: Daniel Gustafsson Assisted-by: Rich Salz Assisted-by: Hugo van Kemenade Assisted-by: James Fuller Assisted-by: Marc Hörsken Assisted-by: Jay Satiro Closes #5555
* altsvc: remove the num field from the altsvc structDaniel Stenberg2020-06-123-12/+8
| | | | | | | | It was superfluous since we have the list.size alredy Reported-by: Jay Satiro Fixes #5553 Closes #5563
* version.d: expanded and alpha-sortedDaniel Stenberg2020-06-121-28/+36
| | | | | | | Added a few missing features not previously mentioned. Ordered them alphabetically. Closes #5558
* ABI.md: rename to .md and polish the markdownDaniel Stenberg2020-06-122-19/+14
| | | | Closes #5562
* HELP-US: add a section for "smaller tasks"Daniel Stenberg2020-06-121-0/+17
| | | | | | | | | | The point of this section is to meet the CII Best Practices gold level critera: "The project MUST clearly identify small tasks that can be performed by new or casual contributors" Closes #5560
* TODO: retry on the redirected-to URLDaniel Stenberg2020-06-121-0/+12
| | | | Closes #5462
* mailmap: Nicolas StercheleDaniel Stenberg2020-06-121-0/+1
|
* TODO: remove 19.3 section titleSterchele Nicolas2020-06-121-1/+1
| | | | | | | Follow-up to ad6416986755e417c66e2c6, which caused wrong formatting on curl documentation website Closes #5561
* test1560: avoid possibly negative association in wordingMartin V2020-06-121-14/+14
| | | | Closes #5549
* share: don't set the share flag it something failsDaniel Stenberg2020-06-121-3/+5
| | | | | | | | When asking for a specific feature to be shared in the share object, that bit was previously set unconditionally even if the shared feature failed or otherwise wouldn't work. Closes #5554
* buildconf: remove -print from the find command that removes filesDaniel Stenberg2020-06-101-1/+1
| | | | It's just too annoying and unnecessary to get a long list of files shown
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-101-9/+36
|
* wording: avoid blacklist/whitelist stereotypesDaniel Stenberg2020-06-1017-70/+67
| | | | | | | | Instead of discussing if there's value or meaning (implied or not) in the colors, let's use words without the same possibly negative associations. Closes #5546
* tool_getparam: fix memory leak in parse_argsJay Satiro2020-06-091-0/+2
| | | | | | | | | Prior to this change in Windows Unicode builds most parsed options would not be freed. Found using _CrtDumpMemoryLeaks(). Ref: https://github.com/curl/curl/issues/5545
* socks: detect connection close during handshakeDaniel Stenberg2020-06-081-4/+28
| | | | | | | | | The SOCKS4/5 state machines weren't properly terminated when the proxy connection got closed, leading to a busy-loop. Reported-By: zloi-user on github Fixes #5532 Closes #5542
* multi: add defensive check on data->multi->num_alivexquery2020-06-081-1/+3
| | | | Closes #5540
* Curl_addrinfo: use one malloc instead of threeDaniel Stenberg2020-06-083-69/+30
| | | | | | | | To reduce the amount of allocations needed for creating a Curl_addrinfo struct, make a single larger malloc instead of three separate smaller ones. Closes #5533
* quiche: update SSLKEYLOGFILE supportAlessandro Ghedini2020-06-081-1/+7
| | | | | | | | quiche now requires the application to explicitly set the keylog path for each connection, rather than reading the environment variable itself. Closes #5541
* tests: add two simple tests for --login-optionsDaniel Stenberg2020-06-083-6/+94
| | | | | | Test 895 and 896 - as a follow-up to a3e972313b Closes #5539
* ngtcp2: update with recent API changesDaniel Stenberg2020-06-081-5/+8
| | | | | | | Syncs with ngtcp2 commit 7e9a917d386d98 merged June 7 2020. Assisted-by: Tatsuhiro Tsujikawa Closes #5538
* socks: remove unreachable breaks in socks.c and mime.cxquery2020-06-082-5/+3
| | | | Closes #5537
* tool_cfgable: free login_options at exitDaniel Stenberg2020-06-081-0/+1
| | | | | | | Memory leak Reported-by: Geeknik Labs Fixes #5535 Closes #5536
* libssh2: keep sftp errors as 'unsigned long'Daniel Stenberg2020-06-081-62/+66
| | | | | | | Remove weird work-around for storing the SFTP errors as int instead of the "unsigned long" that libssh2 actually returns for SFTP errors. Closes #5534
* timeouts: move ms timeouts to timediff_t from int and longMarc Hoersken2020-06-065-9/+13
| | | | | | | | | | | | | Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73de. Based upon #5262 Supersedes #5214, #5220 and #5221 Follow up to #5343 and #5479 Closes #5490
* openssl: set FLAG_TRUSTED_FIRST unconditionallyFrançois Rigault2020-06-061-4/+3
| | | | | | | | | | | | | On some systems, openssl 1.0.x is still the default, but it has been patched to contain all the recent security fixes. As a result of this patching, it is possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous behavior of openssl to not look at trusted chains first, remains. Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for the behavior of openssl based on the existence ofmacros. Closes #5530
* server/util: fix logmsg format using curl_off_t argumentDaniel Stenberg2020-06-061-1/+1
| | | | | | | | | ... this caused segfaults on armv7. Regression added in dd0365d560aea5a (7.70.0) Reviewed-by: Jay Satiro Closes #5529
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-051-11/+31
|
* socks: fix expected length of SOCKS5 replyCherish982020-06-051-0/+7
| | | | | | | | | Commit 4a4b63d forgot to set the expected SOCKS5 reply length when the reply ATYP is X'01'. This resulted in erroneously expecting more bytes when the request length is greater than the reply length (e.g., when remotely resolving the hostname). Closes #5527
* .gitignore: add directory containing the stats repoMarc Hoersken2020-06-051-1/+1
| | | | | | Since the new curl/stats repository is designed to be checked out into the curl repository working tree as stats/ it should be on the ignore list to aid in commit staging.
* HTTP3.md: clarify cargo build directoryAdnan Khan2020-06-051-0/+1
| | | | | | Cargo needs to be called from within the 'quiche' directory. Closes #5522
* user-agent.d: spell out what happens given a blank argumentDaniel Stenberg2020-06-051-0/+4
| | | | Closes #5525
* trailers: switch h1-trailer logic to use dynbufDaniel Stenberg2020-06-054-37/+21
| | | | | | In the continued effort to remove "manual" realloc schemes. Closes #5524
* CURLINFO_ACTIVESOCKET.3: clarify the descriptionDaniel Stenberg2020-06-051-9/+11
| | | | | | Reported-by: Jay Satiro Fixes #5299 Closes #5520
* mailmap: Don J OlmsteadDaniel Stenberg2020-06-041-0/+1
|
* configure: only strip first -L from LDFLAGSDaniel Stenberg2020-06-041-14/+14
| | | | | | | | | | | | | | In the logic that works out if a given OpenSSL path works, it stripped off a possibly leading -L flag using an incorrect sed pattern which would remove all instances of -L in the string, including if the path itself contained that two-letter sequence! The same pattern was used and is now updated in multiple places. Now it only removes -L if it starts the strings. Reported-by: Mohamed Osama Fixes #5519 Closes #5521
* quiche: advertise draft 28 supportPeter Wu2020-06-042-3/+15
| | | | | | | Fix the verbose message while at it, quiche currently supports draft 27 and draft 28 simultaneously. Closes #5518
* KNOWN_BUGS: RTSP authentication breaks without redirect supportDaniel Stenberg2020-06-041-0/+10
| | | | Closes #4750
* projects: Add crypt32.lib to dependencies for all OpenSSL configsJay Satiro2020-06-0420-144/+144
| | | | | | | | | | | | | Windows project configurations that use OpenSSL with USE_WIN32_CRYPTO need crypt32. Follow-up to 148534d which added CURLSSLOPT_NATIVE_CA for 7.71.0. The changes that are in this commit were made by script. Ref: https://gist.github.com/jay/a1861b50ecce2b32931237180f856e28 Closes https://github.com/curl/curl/pull/5516
* CI/macos: fix 'is already installed' errors by using bundleMarc Hoersken2020-06-031-4/+10
| | | | | | Avoid failing CI builds due to nghttp2 being already installed. Closes #5513
* altsvc: fix 'dsthost' may be used uninitialized in this functionDaniel Stenberg2020-06-031-1/+1
|
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-021-5/+26
|
* urldata: let the HTTP method be in the set.* structDaniel Stenberg2020-06-0212-60/+154
| | | | | | | | | | | | When the method is updated inside libcurl we must still not change the method as set by the user as then repeated transfers with that same handle might not execute the same operation anymore! This fixes the libcurl part of #5462 Test 1633 added to verify. Closes #5499
* hostip: fix the memory-leak introduced in 67d2802Daniel Stenberg2020-06-021-6/+15
| | | | | Fixes #5503 Closes #5504
* test970: make it require proxy supportDaniel Stenberg2020-06-021-0/+1
| | | | | | | | | | | This test verifies the -w %json output and the test case includes a full generated "blob". If there's no proxy support built into libcurl, it will return an error for proxy related info variables and they will not be included in the json, thus causing a mismatch and this test fails. Reported-by: Marc Hörsken Fixes #5501 Closes #5502
* examples/http2-down/upload: add error checksRadoslav Georgiev2020-06-022-6/+30
| | | | | | | | | | | | | If `index.html` does not exist in the directory from which the example is invoked, the fopen(upload, "rb") invocation in `setup` would fail, returning NULL. This value is subsequently passed as the FILE* argument of the `fread` invocation in the `read_callback` function, which is the actual cause of the crash (apparently `fread` assumes that argument to be non-null). In addition, mitigate some possible crashes of similar origin. Closes #5463
* examples/ephiperfifo: turn off interval when setting timerfdkotoriのねこ2020-06-021-3/+3
| | | | | | Reported-by: therealhirudo on github Fixes #5485 Closes #5497
* vtls: repair the build with `CURL_DISABLE_PROXY`Saleem Abdulrasool2020-06-012-0/+16
| | | | | | | | | `http_proxy` will not be available in `conndata` if `CURL_DISABLE_PROXY` is enabled. Repair the build with that configuration. Follow-up to f3d501dc67 Closes #5498
* transfer: remove k->str NULL checkDaniel Stenberg2020-06-011-1/+1
| | | | | | | | | | "Null-checking k->str suggests that it may be null, but it has already been dereferenced on all paths leading to the check" - and it can't legally be NULL at this point. Remove check. Detected by Coverity CID 1463884 Closes #5495
* select: always use Sleep in Curl_wait_ms on Win32Marc Hoersken2020-06-011-16/+4
| | | | | | | | | | | Since Win32 almost always will also have USE_WINSOCK, we can reduce complexity and always use Sleep there. Assisted-by: Jay Satiro Reviewed-by: Daniel Stenberg Follow up to #5343 Closes #5489
View Lorry Controller Status