summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* http: added 417 response treatmentbagder/http-417-handlingDaniel Stenberg2020-02-216-10/+137
| | | | | | | | | | | | | | When doing a request with a body + Expect: 100-continue and the server responds with a 417, the same request will be retried immediately without the Expect: header. Added test 357 to verify. Also added a control instruction to tell the sws test server to not read the request body if Expect: is present, which the new test 357 uses. Reported-by: bramus on github Fixes #4949
* github action: add CIFuzzLeo Neat2020-02-211-0/+24
| | | | Closes #4960
* cleanup: comment typosDaniel Stenberg2020-02-215-7/+5
| | | | | | Spotted by 'codespell' Closes #4957
* win32: USE_WIN32_CRYPTO to enable Win32 based MD4, MD5 and SHA256 functionsSteve Holme2020-02-203-5/+7
| | | | | | | | | Whilst lib\md4.c used this pre-processor, lib\md5.c and src\tool_metalink.c did not and simply relied on the WIN32 pre-processor directive. Reviewed-by: Marcel Raad Closes #4955
* connect: remove some spurious infof() callsDaniel Stenberg2020-02-191-7/+0
| | | | | | | As they were added primarily for debugging, they provide little use for users. Closes #4951
* HTTP-COOKIES: mention that a trailing newline is requiredDaniel Stenberg2020-02-191-11/+14
| | | | | | | | | | | | ... so that we know we got the whole and not a partial line. Also, changed the formatting of the fields away from a table again since the table format requires a github-markdown tool version that we don't run on the web server atm. Reported-by: Sunny Bean Fixes #4946 Closes #4947
* nit: Copyright year out of dateDaniel Stenberg2020-02-196-6/+6
| | | | Follow-up to 1fc0617dcc
* tool_util: Improve Windows version of tvnow()Jay Satiro2020-02-186-33/+72
| | | | | | | | | | | | | | | | | | | | | | | | | - Change tool_util.c tvnow() for Windows to match more closely to timeval.c Curl_now(). - Create a win32 init function for the tool, since some initialization is required for the tvnow() changes. Prior to this change the monotonic time function used by curl in Windows was determined at build-time and not runtime. That was a problem because when curl was built targeted for compatibility with old versions of Windows (eg _WIN32_WINNT < 0x0600) it would use GetTickCount which wraps every 49.7 days that Windows has been running. This change makes curl behave similar to libcurl's tvnow function, which determines at runtime whether the OS is Vista+ and if so calls QueryPerformanceCounter instead. (Note QueryPerformanceCounter is used because it has higher resolution than the more obvious candidate GetTickCount64). The changes to tvnow are basically a copy and paste but the types in some cases are different. Ref: https://github.com/curl/curl/issues/3309 Closes https://github.com/curl/curl/pull/4847
* SOCKS: fix typo in printf formattingDaniel Stenberg2020-02-181-1/+1
| | | | | | | Follow-up to 4a4b63daa Reported-by: Peter Piekarski Bug: https://github.com/curl/curl/commit/4a4b63daaa01ef59b131d91e8e6e6dfe275c0f08#r37351330
* CURLOPT_REDIR_PROTOCOLS.3: update the DEFAULT sectionDaniel Stenberg2020-02-181-2/+5
| | | | | | | | to be in sync with the description above Reported-by: Joonas Kuorilehto Fixes #4943 Closes #4945
* docs/GOVERNANCE: refreshed + added "donations" and "commercial support"Daniel Stenberg2020-02-181-3/+26
|
* altsvc: make saving the cache an atomic operationDaniel Stenberg2020-02-184-19/+41
| | | | | | | | ... by writing the file to temp name then rename to the final when done. Assisted-by: Jay Satiro Fixes #4936 Closes #4942
* rename: a new file for Curl_rename()Daniel Stenberg2020-02-184-28/+93
| | | | And make the cookie save function use it.
* cookies: make saving atomic with a renameDaniel Stenberg2020-02-171-16/+63
| | | | | | | | | | Saves the file as "[filename].[8 random hex digits].tmp" and renames away the extension when done. Co-authored-by: Jay Satiro Reported-by: Mike Frysinger Fixes #4914 Closes #4926
* RELEASE-NOTES: syncedDaniel Stenberg2020-02-171-12/+35
|
* socks: make the connect phase non-blockingDaniel Stenberg2020-02-1713-553/+817
| | | | | | Removes two entries from KNOWN_BUGS. Closes #4907
* multi: if Curl_readwrite sets 'comeback' use expire, not loopDaniel Stenberg2020-02-161-2/+7
| | | | | | | Otherwise, a very fast single transfer ricks starving out other concurrent transfers. Closes #4927
* ftp: convert 'sock_accepted' to a plain booleanDaniel Stenberg2020-02-163-6/+5
| | | | | | | This was an array indexed with sockindex but it was only ever used for the secondary socket. Closes #4929
* CURLINFO_COOKIELIST.3: Fix exampleJay Satiro2020-02-151-3/+3
| | | | | | | | | Prior to this change the example would try to import cookies from stdin, which wasn't what was intended. Reported-by: 3dyd@users.noreply.github.com Fixes https://github.com/curl/curl/issues/4930
* TODO: Paged searches on LDAP serverDaniel Stenberg2020-02-141-0/+5
| | | | Closes #4452
* TODO: CURLOPT_SSL_CTX_FUNCTION for LDAPSDaniel Stenberg2020-02-141-0/+8
| | | | Closes #4108
* azure: disable brotli on the macos debug-buildsDaniel Stenberg2020-02-141-1/+1
| | | | | | | | | Because of: brotli/decode.h:204:33: error: variable length array used [-Werror,-Wvla] const uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(encoded_size)], Closes #4925
* tool_home: Fix the copyright year being out of dateSteve Holme2020-02-132-2/+2
| | | | Follow up to 9dc350b6.
* tool_homedir: Change GetEnv() to use libcurl's curl_getenv()Jay Satiro2020-02-122-42/+58
| | | | | | | | | | | | | | | | | | | | | | - Deduplicate GetEnv() code. - On Windows change ultimate call to use Windows API GetEnvironmentVariable() instead of C runtime getenv(). Prior to this change both libcurl and the tool had their own GetEnv which over time diverged. Now the tool's GetEnv is a wrapper around curl_getenv (libcurl API function which is itself a wrapper around libcurl's GetEnv). Furthermore this change fixes a bug in that Windows API GetEnvironmentVariable() is called instead of C runtime getenv() to get the environment variable since some changes aren't always visible to the latter. Reported-by: Christoph M. Becker Fixes https://github.com/curl/curl/issues/4774 Closes https://github.com/curl/curl/pull/4863
* strerror.h: Copyright year out of dateDaniel Stenberg2020-02-121-1/+1
| | | | Follow-up to 1c4fa67e8a8fcf6
* strerror: Increase STRERROR_LEN 128 -> 256Jay Satiro2020-02-121-1/+1
| | | | | | | | | | STRERROR_LEN is the constant used throughout the library to set the size of the buffer on the stack that the curl strerror functions write to. Prior to this change some extended length Windows error messages could be truncated. Closes https://github.com/curl/curl/pull/4920
* multi: fix outdated commentJay Satiro2020-02-121-2/+2
| | | | | | | | | | - Do not say that conn->data is "cleared" by multi_done(). If the connection is in use then multi_done assigns another easy handle still using the connection to conn->data, therefore in that case it is not cleared. Closes https://github.com/curl/curl/pull/4901
* easy: remove dead codeJay Satiro2020-02-121-4/+0
| | | | | | multi is already assigned to data->multi by curl_multi_add_handle. Closes https://github.com/curl/curl/pull/4900
* create-dirs.d: mention the modeDaniel Stenberg2020-02-121-0/+2
| | | | | | Reported-by: Dan Jacobson Fixes #4766 Closes #4916
* CURLOPT_ALTSVC_CTRL.3: fix the DEFAULT wordingDaniel Stenberg2020-02-111-2/+5
| | | | | | | Assisted-by: Jay Satiro Reported-by: Craig Andrews Fixes #4909 Closes #4910
* RELEASE-NOTES: syncedDaniel Stenberg2020-02-101-8/+42
|
* smtp: Simplify the MAIL command and avoid a duplication of send stringsSteve Holme2020-02-091-12/+7
| | | | | | | | This avoids the duplication of strings when the optional AUTH and SIZE parameters are required. It also assists with the modifications that are part of #4892. Closes #4903
* altsvc: keep a copy of the file name to survive handle resetDaniel Stenberg2020-02-096-4/+143
| | | | | | | | | | | | The alt-svc cache survives a call to curl_easy_reset fine, but the file name to use for saving the cache was cleared. Now the alt-svc cache has a copy of the file name to survive handle resets. Added test 1908 to verify. Reported-by: Craig Andrews Fixes #4898 Closes #4902
* url: Include the failure reason when curl_win32_idn_to_ascii() failsSteve Holme2020-02-091-1/+3
| | | | | | | Provide the failure reason in the failf() info just as we do for the libidn2 version of code. Closes #4899
* asyn-thread: remove dead codeJay Satiro2020-02-091-3/+0
|
* github: Instructions to post "uname -a" on Unix systems in issuesEmil Engler2020-02-081-0/+2
| | | | Closes #4896
* configure.ac: fix comments about --with-quicheCristian Greco2020-02-081-2/+2
| | | | | | | A simple s/nghttp3/quiche in some comments of --with-quiche. Looks like a copy-paste error from --with-nghttp3. Closes #4897
* checksrc.bat: Fix not being able to run script from the main curl directorySteve Holme2020-02-071-2/+20
| | | | | | | | | | | | | | | | | | | | If the script was ran from the main curl directory rather then the projects directory then the script would simply exit without error: C:\url> projects\checksrc.bat The user would either need to change to the projects directory, explicitly specify the current working directory, or perform a oneline hacky workaround: C:\url> cd projects C:\url\projects> checksrc.bat C:\url> checksrc.bat %cd% C:\url> pushd projects & checksrc.bat & popd Closes #4894
* digest: Do not quote algorithm in HTTP authorisationPierre-Yves Bigourdan2020-02-0715-16/+16
| | | | | | | | | | RFC 7616 section 3.4 (The Authorization Header Field) states that "For historical reasons, a sender MUST NOT generate the quoted string syntax for the following parameters: algorithm, qop, and nc". This removes the quoting for the algorithm parameter. Reviewed-by: Steve Holme Closes #4890
* ftp: remove the duplicated user/password struct fieldsDaniel Stenberg2020-02-072-14/+3
| | | | Closes #4887
* ftp: remove superfluous checking for crlf in user or pwdDaniel Stenberg2020-02-073-19/+38
| | | | | | | | | ... as this is already done much earlier in the URL parser. Also add test case 894 that verifies that pop3 with an encodedd CR in the user name is rejected. Closes #4887
* ntlm_wb: Use Curl_socketpair() for greater portabilitySteve Holme2020-02-061-1/+1
| | | | | Reported-by: Daniel Stenberg Closes #4886
* contributors: Also include people who contributed to curl-wwwFrank Gevaerts2020-02-052-2/+27
| | | | Closes #4884
* contrithanks: Use the most recent tag by defaultFrank Gevaerts2020-02-051-1/+5
| | | | | | (similar to 5296abe) Closes #4883
* scripts: use last set tag if none givenDaniel Stenberg2020-02-052-6/+14
| | | | | | | | | Makes 'delta' and 'contributors.sh' easier to use. Make the delta script invoke contrithanks to get current number of contributors instead of counting THANKS, for accuracy. Closes #4881
* ftp: shrink temp buffers used for PORTDaniel Stenberg2020-02-051-5/+6
| | | | | | | These two stack based buffers only need to be 46 + 66 bytes instead of 256 + 1024. Closes #4880
* curl: error on --alt-svc use w/o supportDaniel Stenberg2020-02-052-4/+4
| | | | | | | | Make the tool check for alt-svc support at run-time and return error accordingly if not present when the option is used. Reported-by: Harry Sintonen Closes #4878
* docs/HTTP3: add --enable-alt-svc to curl's configureDaniel Stenberg2020-02-051-3/+3
|
* RELEASE-PROCEDURE: feature win is closed post-release a few daysDaniel Stenberg2020-02-041-5/+13
| | | | | | | We've tried to uphold this already but let's make it official by publicly stating this is the way we do it. Closes #4877
* altsvc: set h3 version at a common single spotDaniel Stenberg2020-02-041-11/+8
| | | | | | | | ... and move the #ifdefs out of the functions. Addresses the fact they were different before this change. Reported-by: Harry Sintonen Closes #4876