Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | curl: report error for "--no-" on non-boolean optionsbagder/curl-no-is-for-boolean | Daniel Stenberg | 2019-05-20 | 5 | -3/+46 |
| | | | | | Reported-by: Olen Andoni Fixes #3906 | ||||
* | lib: reduce variable scopes | Marcel Raad | 2019-05-20 | 23 | -124/+115 |
| | | | | | | Fixes Codacy/CppCheck warnings. Closes https://github.com/curl/curl/pull/3872 | ||||
* | tool_formparse: remove redundant assignment | Marcel Raad | 2019-05-20 | 1 | -3/+2 |
| | | | | | | Just initialize word_begin with the correct value. Closes https://github.com/curl/curl/pull/3873 | ||||
* | ssh: move variable declaration to where it's used | Marcel Raad | 2019-05-20 | 1 | -8/+5 |
| | | | | | | This way, we need only one call to free. Closes https://github.com/curl/curl/pull/3873 | ||||
* | ssh-libssh: remove unused variable | Marcel Raad | 2019-05-20 | 1 | -3/+1 |
| | | | | | | sock was only used to be assigned to fd_read. Closes https://github.com/curl/curl/pull/3873 | ||||
* | test332: verify the blksize fix | Daniel Stenberg | 2019-05-20 | 2 | -1/+46 |
| | |||||
* | tftp: use the current blksize for recvfrom() | Daniel Stenberg | 2019-05-20 | 1 | -1/+1 |
| | | | | | | bug: https://curl.haxx.se/docs/CVE-2019-5436.html Reported-by: l00p3r on hackerone CVE-2019-5436 | ||||
* | version: make ssl_version buffer match for multi_ssl | Daniel Gustafsson | 2019-05-19 | 1 | -0/+4 |
| | | | | | | | | | | | | When running a multi TLS backend build the version string needs more buffer space. Make the internal ssl_buffer stack buffer match the one in Curl_multissl_version() to allow for the longer string. For single TLS backend builds there is no use in extended to buffer. This is a fallout from #3863 which fixes up the multi_ssl string generation to avoid a buffer overflow when the buffer is too small. Closes #3875 Reviewed-by: Daniel Stenberg <daniel@haxx.se> | ||||
* | http_ntlm_wb: Handle auth for only a single request | Steve Holme | 2019-05-18 | 1 | -3/+11 |
| | | | | | | | | | | | | | | Currently when the server responds with 401 on NTLM authenticated connection (re-used) we consider it to have failed. However this is legitimate and may happen when for example IIS is set configured to 'authPersistSingleRequest' or when the request goes thru a proxy (with 'via' header). Implemented by imploying an additional state once a connection is re-used to indicate that if we receive 401 we need to restart authentication. Missed in fe6049f0. | ||||
* | http_ntlm_wb: Cleanup handshake after clean NTLM failure | Steve Holme | 2019-05-18 | 1 | -1/+7 |
| | | | | Missed in 50b87c4e. | ||||
* | http_ntlm_wb: Return the correct error on receiving an empty auth message | Steve Holme | 2019-05-18 | 1 | -3/+11 |
| | | | | | | Missed in fe20826b as it wasn't implemented in http.c in b4d6db83. Closes #3894 | ||||
* | curl: make code work with protocol-disabled libcurl | Daniel Stenberg | 2019-05-18 | 8 | -12/+22 |
| | | | | Closes #3844 | ||||
* | libcurl: #ifdef away more code for disabled features/protocols | Daniel Stenberg | 2019-05-17 | 8 | -104/+157 |
| | |||||
* | progress: CURL_DISABLE_PROGRESS_METER | Daniel Stenberg | 2019-05-17 | 1 | -49/+61 |
| | |||||
* | hostip: CURL_DISABLE_SHUFFLE_DNS | Daniel Stenberg | 2019-05-17 | 2 | -1/+6 |
| | |||||
* | netrc: CURL_DISABLE_NETRC | Daniel Stenberg | 2019-05-17 | 2 | -2/+12 |
| | |||||
* | docs: Markdown and misc improvements [ci skip] | Viktor Szakats | 2019-05-16 | 6 | -230/+240 |
| | | | | | Approved-by: Daniel Stenberg Closes #3896 | ||||
* | docs/RELEASE-PROCEDURE: link to live iCalendar [ci skip] | Viktor Szakats | 2019-05-16 | 1 | -0/+4 |
| | | | | | | Ref: https://github.com/curl/curl/commit/0af41b40b2c7bd379b2251cbe7cd618e21fa0ea1#commitcomment-33563135 Approved-by: Daniel Stenberg Closes #3895 | ||||
* | travis: add an osx http-only build | Daniel Stenberg | 2019-05-16 | 1 | -0/+3 |
| | | | | Closes #3887 | ||||
* | cleanup: remove FIXME and TODO comments | Daniel Stenberg | 2019-05-16 | 36 | -152/+33 |
| | | | | | | | | | They serve very little purpose and mostly just add noise. Most of them have been around for a very long time. I read them all before removing or rephrasing them. Ref: #3876 Closes #3883 | ||||
* | curl: don't set FTP options for FTP-disabled builds | Daniel Stenberg | 2019-05-16 | 1 | -1/+4 |
| | | | | | | | | | | ... since libcurl has started to be totally unaware of options for disabled protocols they now return error. Bug: https://github.com/curl/curl/commit/c9c5304dd4747cbe75d2f24be85920d572fcb5b8#commitcomment-33533937 Reported-by: Marcel Raad Closes #3886 | ||||
* | http_ntlm_wb: Move the type-2 message processing into a dedicated function | Steve Holme | 2019-05-16 | 3 | -15/+35 |
| | | | | | | This brings the code inline with the other HTTP authentication mechanisms. Closes #3890 | ||||
* | RELEASE-NOTES: synced | Daniel Stenberg | 2019-05-15 | 1 | -9/+22 |
| | |||||
* | docs/RELEASE-PROCEDURE: updated coming releases dates [ci skip] | Daniel Stenberg | 2019-05-15 | 1 | -1/+4 |
| | |||||
* | CURLOPT_READFUNCTION.3: see also CURLOPT_UPLOAD_BUFFERSIZE [ci skip] | Daniel Stenberg | 2019-05-15 | 1 | -1/+2 |
| | | | | | Reported-by: Roy Bellingan Bug: #3885 | ||||
* | parse_proxy: use the URL parser API | Daniel Stenberg | 2019-05-15 | 2 | -148/+83 |
| | | | | | | | As we treat a given proxy as a URL we should use the unified URL parser to extract the parts out of it. Closes #3878 | ||||
* | http_negotiate: Move the Negotiate state out of the negotiatedata structure | Steve Holme | 2019-05-15 | 6 | -30/+37 |
| | | | | | | | Given that this member variable is not used by the SASL based protocols there is no need to have it here. Closes #3882 | ||||
* | http_ntlm: Move the NTLM state out of the ntlmdata structure | Steve Holme | 2019-05-15 | 6 | -28/+34 |
| | | | | | Given that this member variable is not used by the SASL based protocols there is no need to have it here. | ||||
* | url: Move the negotiate state type into a dedicated enum | Steve Holme | 2019-05-15 | 1 | -3/+9 |
| | |||||
* | url: Remove duplicate clean up of the winbind variables in conn_shutdown() | Steve Holme | 2019-05-14 | 1 | -6/+0 |
| | | | | | | | | Given that Curl_disconnect() calls Curl_http_auth_cleanup_ntlm() prior to calling conn_shutdown() and it in turn performs this, there is no need to perform the same action in conn_shutdown(). Closes #3881 | ||||
* | urlapi: require a non-zero host name length when parsing URL | Daniel Stenberg | 2019-05-14 | 2 | -0/+5 |
| | | | | | | Updated test 1560 to verify. Closes #3880 | ||||
* | configure: error out if OpenSSL wasn't detected when asked for | Daniel Stenberg | 2019-05-14 | 1 | -0/+8 |
| | | | | | | | | | If --with-ssl is used and configure still couldn't enable SSL this creates an error instead of just silently ignoring the fact. Suggested-by: Isaiah Norton Fixes #3824 Closes #3830 | ||||
* | imap: Fix typo in comment | Daniel Gustafsson | 2019-05-14 | 1 | -1/+1 |
| | |||||
* | url: Remove unnecessary initialisation from allocate_conn() | Steve Holme | 2019-05-14 | 1 | -14/+1 |
| | | | | | | No need to set variables to zero as calloc() does this for us. Closes #3879 | ||||
* | CURLOPT_CAINFO.3: with Schannel, you want Windows 8 or later [ci skip] | Daniel Stenberg | 2019-05-14 | 1 | -5/+6 |
| | | | | | | | Clues-provided-by: Jay Satiro Clues-provided-by: Jeroen Ooms Fixes #3711 Closes #3874 | ||||
* | vtls: fix potential ssl_buffer stack overflow | Daniel Gustafsson | 2019-05-13 | 1 | -4/+5 |
| | | | | | | | | | | | | In Curl_multissl_version() it was possible to overflow the passed in buffer if the generated version string exceeded the size of the buffer. Fix by inverting the logic, and also make sure to not exceed the local buffer during the string generation. Closes #3863 Reported-by: nevv on HackerOne/curl Reviewed-by: Jay Satiro Reviewed-by: Daniel Stenberg | ||||
* | RELEASE-NOTES: synced | Daniel Stenberg | 2019-05-13 | 1 | -6/+36 |
| | |||||
* | appveyor: also build "/ci" branches like travis | Daniel Stenberg | 2019-05-13 | 1 | -0/+1 |
| | |||||
* | pingpong: disable more when no pingpong enabled | Daniel Stenberg | 2019-05-13 | 2 | -1/+11 |
| | |||||
* | proxy: acknowledge DISABLE_PROXY more | Daniel Stenberg | 2019-05-13 | 3 | -5/+38 |
| | |||||
* | parsedate: CURL_DISABLE_PARSEDATE | Daniel Stenberg | 2019-05-13 | 2 | -15/+37 |
| | |||||
* | sasl: only enable if there's a protocol enabled using it | Daniel Stenberg | 2019-05-13 | 1 | -0/+4 |
| | |||||
* | mime: acknowledge CURL_DISABLE_MIME | Daniel Stenberg | 2019-05-13 | 5 | -79/+42 |
| | |||||
* | wildcard: disable from build when FTP isn't present | Daniel Stenberg | 2019-05-13 | 7 | -6/+28 |
| | |||||
* | http: CURL_DISABLE_HTTP_AUTH | Daniel Stenberg | 2019-05-13 | 2 | -1/+20 |
| | |||||
* | base64: build conditionally if there are users | Daniel Stenberg | 2019-05-13 | 1 | -1/+8 |
| | |||||
* | doh: CURL_DISABLE_DOH | Daniel Stenberg | 2019-05-13 | 3 | -1/+15 |
| | |||||
* | auth: Rename the various authentication clean up functions | Steve Holme | 2019-05-12 | 18 | -53/+54 |
| | | | | | | For consistency and to a avoid confusion. Closes #3869 | ||||
* | docs/INSTALL: fix broken link [ci skip] | Jay Satiro | 2019-05-12 | 1 | -1/+1 |
| | | | | | Reported-by: Joombalaya on github Fixes #3818 | ||||
* | easy: fix another "clarify calculation precedence" warning | Marcel Raad | 2019-05-12 | 1 | -2/+2 |
| | | | | I missed this one in commit 6b3dde7fe62ea5a557fd1fd323fac2bcd0c2e9be. |