| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
... previously it would store it already in the happy eyeballs stage
which could lead to the IPv6 bit being set for an IPv4 connection,
leading to curl not wanting to do EPSV=>PASV for FTP transfers.
|
|
|
|
|
|
|
|
|
|
| |
It triggers an assert() when built with memdebug since malloc(0) may
return NULL *or* a valid pointer.
Detected by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4054
Assisted-by: Max Dymond
Closes #2054
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By properly keeping track of the last entry in the list of URLs/uploads
to handle, curl now avoids many meaningless traverses of the list which
speeds up many-URL handling *MASSIVELY* (several magnitudes on 100K
URLs).
Added test 1291, to verify that it doesn't take ages - but we don't have
any detection of "too slow" command in the test suite.
Reported-by: arainchik on github
Fixes #1959
Closes #2052
|
|
|
|
|
|
|
| |
Assisted-by: Per Lundberg
Fixes #2044
Closes #2046
Closes #2048
|
|
|
|
|
|
|
| |
Regression since f121575
Reported-by: Petr Voytsik
Fixes #2047
|
|
|
|
|
| |
Prior to this change since f121575 (7.56.1+) CURLOPT_DNS_CACHE_TIMEOUT
erroneously rejected -1 with CURLE_BAD_FUNCTION_ARGUMENT.
|
|
|
|
| |
This caused the torture tests on test 1800 to fail.
|
|
|
|
| |
Test cleanup after OOM wasn't being consistently performed.
|
|
|
|
|
|
|
|
|
|
|
| |
... which is valid according to documentation. Regression since
f121575c0b5f.
Verified now in test 501.
Reported-by: cbartl on github
Fixes #2038
Closes #2039
|
| |
|
|
|
|
|
|
|
|
|
|
| |
.. also add same arg value check to CURLOPT_POSTFIELDSIZE_LARGE.
Prior to this change since f121575 (7.56.1+) CURLOPT_POSTFIELDSIZE
erroneously rejected -1 value with CURLE_BAD_FUNCTION_ARGUMENT.
Bug: https://curl.haxx.se/mail/lib-2017-11/0000.html
Reported-by: Andrew Lambert
|
|
|
|
|
|
|
|
| |
... when expiring old cookies.
Reported-by: Pavel Gushchin
Fixes #2032
Closes #2035
|
|
|
|
|
|
| |
This avoids build errors and warnings caused by implicit casts.
Closes https://github.com/curl/curl/pull/2031
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not generate line with the current date, such as:
* Generation time: Tue Oct-24 18:01:41 2017
This will improve reproducibility. The generated string is only
part of a comment, so there should be no adverse consequences.
Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
closes #2026
|
| |
|
|
|
|
|
| |
Pointed-out-by: Dmitri Tikhonov
Bug: #2034
|
|
|
|
| |
s/curlx_tvnow/Curl_now
|
| |
|
|
|
|
|
|
| |
If clock_gettime() is not supported, use mach_absolute_time() on MacOS.
closes #2033
|
| |
|
|
|
|
|
|
|
|
| |
Also upgrade test 1133 to cover this case and clarify man page about
form data quoting.
Bug: https://github.com/curl/curl/issues/2022
Reported-By: omau on github
|
| |
|
|
|
|
|
|
|
|
|
| |
The config files define curl and libcurl targets as imported targets
CURL::curl and CURL::libcurl. For backward compatibility with CMake-
provided find-module the CURL_INCLUDE_DIRS and CURL_LIBRARIES are
also set.
Closes #1879
|
| |
|
|
|
|
|
|
|
|
| |
Updated docs to include support for RFC7616
Signed-off-by: Florin <petriuc.florin@gmail.com>
Closes #1934
|
|
|
|
| |
Signed-off-by: Florin <petriuc.florin@gmail.com>
|
|
|
|
| |
Closes #2002
|
|
|
|
|
| |
Removed done stuff. Removed entries no longer considered for the near
term.
|
|
|
|
| |
Closes #2028
|
|
|
|
|
|
|
|
| |
returning 'time_t' is problematic when that type is unsigned and we
return values less than zero to signal "already expired", used in
several places in the code.
Closes #2021
|
| |
|
|
|
|
|
|
| |
Regression since f121575c0b5f
Reported-by: Rob Cotrone
|
|
|
|
|
|
| |
This avoids warnings about unused stuff.
Closes https://github.com/curl/curl/pull/2023
|
|
|
|
| |
"PR-welcome" was the former name.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
If WINAPI_FAMILY is defined, it should be safe to try to include
winapifamily.h to check what the define evaluates to.
This should fix detection of CURL_WINDOWS_APP if building with
_WIN32_WINNT set to 0x0600.
Closes #2025
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When uploading via chunked-encoding don't compare file size to bytes
sent to determine whether the upload has finished.
Chunked-encoding adds its own overhead which why the bytes sent is not
equal to the file size. Prior to this change if a file was uploaded in
chunked-encoding and its size was known it was possible that the upload
could end prematurely without sending the final few chunks. That would
result in a server hang waiting for the remaining data, likely followed
by a disconnect.
The scope of this bug is limited to some arbitrary file sizes which have
not been determined. One size that triggers the bug is 475020.
Bug: https://github.com/curl/curl/issues/2001
Reported-by: moohoorama@users.noreply.github.com
Closes https://github.com/curl/curl/pull/2010
|
|
|
|
|
|
|
|
|
|
| |
... by using curl_off_t for the typedef if time_t is larger than 4
bytes.
Reported-by: Gisle Vanem
Bug: https://github.com/curl/curl/commit/b9d25f9a6b3ca791385b80a6a3c3fa5ae113e1e0#co
mmitcomment-25205058
Closes #2019
|
|
|
|
|
|
|
|
|
|
| |
... instead of doing an infinite loop!
Added test 1162 to verify.
Reported-by: Max Dymond
Fixes #2015
Closes #2017
|
|
|
|
|
|
| |
Fixes timeouts in the fuzzing tests for non-FTP protocols.
Closes #2016
|
|
|
|
|
|
|
| |
Allow users to specify their own hash define for
CURL_CONNECTION_HASH_SIZE so that both values can be overridden.
Closes #1982
|
|
|
|
|
|
|
|
|
|
| |
... since the 'tv' stood for timeval and this function does not return a
timeval struct anymore.
Also, cleaned up the Curl_timediff*() functions to avoid typecasts and
clean up the descriptive comments.
Closes #2011
|
| |
|
|
|
|
|
|
|
|
| |
When using the FTP list parser, ensure that the memory that's
allocated is always freed.
Detected by OSS-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3682
Closes #2013
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
... to cater for systems with unsigned time_t variables.
- Renamed the functions to curlx_timediff and Curl_timediff_us.
- Added overflow protection for both of them in either direction for
both 32 bit and 64 bit time_ts
- Reprefixed the curlx_time functions to use Curl_*
Reported-by: Peter Piekarski
Fixes #2004
Closes #2005
|
|
|
|
|
|
|
|
| |
They use $(TESTUTIL) and thus should use $(TESTUTIL_LIBS) too.
This fixes build failures on Fedora 13.
Closes #2006
|
|
|
|
| |
closes #2008
|
| |
|
| |
|