summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* config.d: clarify that initial : and = might need quoting [skip ci]bagder/config-docsDaniel Stenberg2019-04-081-6/+6
| | | | Fixes #3738
* socks5: user name and passwords must be shorter than 256Daniel Stenberg2019-04-071-2/+14
| | | | | | | | bytes... since the protocol needs to store the length in a single byte field. Reported-by: XmiliaH on github Fixes #3737 Closes #3740
* test: urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski2019-04-071-0/+4
|
* urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski2019-04-071-3/+3
| | | | | fixes #3741 Closes #3742
* multi_runsingle(): fix use-after-freeEven Rouault2019-04-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #3745 Closes #3746 The following snippet ``` int main() { CURL* hCurlHandle = curl_easy_init(); curl_easy_setopt(hCurlHandle, CURLOPT_URL, "http://example.com"); curl_easy_setopt(hCurlHandle, CURLOPT_PROXY, "1"); curl_easy_perform(hCurlHandle); curl_easy_cleanup(hCurlHandle); return 0; } ``` triggers the following Valgrind warning ``` ==4125== Invalid read of size 8 ==4125== at 0x4E7D1EE: Curl_llist_remove (llist.c:97) ==4125== by 0x4E7EF5C: detach_connnection (multi.c:798) ==4125== by 0x4E80545: multi_runsingle (multi.c:1451) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Address 0x9b3d1d0 is 1,120 bytes inside a block of size 1,600 free'd ==4125== at 0x4C2ECF0: free (vg_replace_malloc.c:530) ==4125== by 0x4E62C36: conn_free (url.c:756) ==4125== by 0x4E62D34: Curl_disconnect (url.c:818) ==4125== by 0x4E48DF9: Curl_once_resolved (hostip.c:1097) ==4125== by 0x4E8052D: multi_runsingle (multi.c:1446) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Block was alloc'd at ==4125== at 0x4C2F988: calloc (vg_replace_malloc.c:711) ==4125== by 0x4E6438E: allocate_conn (url.c:1654) ==4125== by 0x4E685B4: create_conn (url.c:3496) ==4125== by 0x4E6968F: Curl_connect (url.c:4023) ==4125== by 0x4E802E7: multi_runsingle (multi.c:1368) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ``` This has been bisected to commit 2f44e94 Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14109 Credit to OSS Fuzz
* pipelining: removedDaniel Stenberg2019-04-0628-1394/+183
| | | | | | | As previously planned and documented in DEPRECATE.md, all pipelining code is removed. Closes #3651
* tests: make Impacket (SMB server) Python 3 compatiblecclauss2019-04-069-342/+352
| | | | | Closes #3731 Fixes #3289
* cmake: set SSL_BACKENDSSimon Warta2019-04-061-4/+13
| | | | | | | This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac Closes https://github.com/curl/curl/pull/3736
* cmake: don't run SORT on empty listSimon Warta2019-04-061-1/+3
| | | | | | | In case of an empty list, SORTing leads to the cmake error "list sub-command SORT requires list to be present." Closes https://github.com/curl/curl/pull/3736
* configure: fix default location for fish completionsEli Schwartz2019-04-051-1/+6
| | | | | | | | | | | | | | Fish defines a vendor completions directory for completions that are not installed as part of the fish project itself, and the vendor completions are preferred if they exist. This prevents trying to overwrite the builtin curl.fish completion (or creating file conflicts in distro packaging). Prefer the pkg-config defined location exported by fish, if it can be found, and fall back to the correct directory defined by most systems. Closes #3723 Reviewed-by: Daniel Gustafsson
* ftplistparser: fix LGTM alert "Empty block without comment"Marcel Raad2019-04-051-4/+1
| | | | | | Removing the block is consistent with line 954/957. Closes https://github.com/curl/curl/pull/3732
* transfer: fix LGTM alert "Comparison is always true"Marcel Raad2019-04-051-1/+1
| | | | | | | Just remove the redundant condition, which also makes it clear that k->buf is always 0-terminated if this break is not hit. Closes https://github.com/curl/curl/pull/3732
* smtp: fix compiler warningRikard Falkeborn2019-04-041-1/+1
| | | | | | | | | | | | | | | | | | | - Fix clang string-plus-int warning. Clang 8 warns about adding a string to an int does not append to the string. Indeed it doesn't, but that was not the intention either. Use array indexing as suggested to silence the warning. There should be no functional changes. (In other words clang warns about "foo"+2 but not &"foo"[2] so use the latter.) smtp.c:1221:29: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] eob = strdup(SMTP_EOB + 2); ~~~~~~~~~~~~~~~~^~~~ Closes https://github.com/curl/curl/pull/3729
* VS projects: use Unicode for VC10+Marcel Raad2019-04-0410-560/+560
| | | | | | | | | | | | | All Windows APIs have been natively UTF-16 since Windows 2000 and the non-Unicode variants are just wrappers around them. Only Windows 9x doesn't understand Unicode without the UnicoWS DLL. As later Visual Studio versions cannot target Windows 9x anyway, using the ANSI API doesn't really have any benefit there. This avoids issues like KNOWN_BUGS 6.5. Ref: https://github.com/curl/curl/issues/2120 Closes https://github.com/curl/curl/pull/3720
* RELEASE-NOTES: syncedDaniel Gustafsson2019-04-031-229/+25
| | | | | Bump the version in progress to 7.64.2, if we merge any "change" before the cut-off date we can update the version.
* documentation: Fix several typosTim Rühsen2019-04-036-6/+6
| | | | | | Closes #3724 Reviewed-by: Jakub Zakrzewski Reviewed-by: Daniel Gustafsson
* vauth/oauth2: Fix OAUTHBEARER token generationMert Yazıcıoğlu2019-04-0215-34/+75
| | | | | | | | | | | OAUTHBEARER tokens were incorrectly generated in a format similar to XOAUTH2 tokens. These changes make OAUTHBEARER tokens conform to the RFC7628. Fixes: #2487 Reported-by: Paolo Mossino Closes https://github.com/curl/curl/pull/3377
* tool_cb_wrt: fix bad-function-cast warningMarcel Raad2019-04-021-5/+3
| | | | | | | | | Commit f5bc578f4cdfdc6c708211dfc2962a0e9d79352d reintroduced the warning fixed in commit 2f5f31bb57d68b54e03bffcd9648aece1fe564f8. Extend fhnd's scope and reuse that variable instead of calling _get_osfhandle a second time to fix the warning again. Closes https://github.com/curl/curl/pull/3718
* VC15 project: remove MinimalRebuildMarcel Raad2019-04-011-28/+0
| | | | | | Already done in commit d5cfefd0ea8e331b884186bff484210fad36e345 for the library project, but I forgot the tool project template. Now also removed for that.
* cirrus: Customize the disabled tests per FreeBSD versionDan Fandrich2019-04-011-3/+7
| | | | | | Try to run as many test cases as possible on each OS version. 12.0 passes 13 more tests than the older versions, so we might as well run them.
* tool_help: include <strings.h> for strcasecmpDaniel Stenberg2019-04-011-0/+3
| | | | | | Reported-by: Wyatt O'Day Fixes #3715 Closes #3716
* scripts: fix typosDaniel Gustafsson2019-03-312-4/+4
|
* travis: allow builds on branches named "ci"Dan Fandrich2019-03-281-0/+1
| | | | This allows a way to test changes other than through PRs.
* resolve: apply Happy Eyeballs philosophy to parallel c-ares queriesBrad Spencer2019-03-272-0/+96
| | | | Closes #3699
* multi: improved HTTP_1_1_REQUIRED handlingDaniel Stenberg2019-03-271-18/+19
| | | | | | | | | Make sure to downgrade to 1.1 even when we get this HTTP/2 stream error on first flight. Reported-by: niner on github Fixes #3696 Closes #3707
* configure: avoid unportable `==' test(1) operatorLeonardo Taccari2019-03-271-1/+1
| | | | Closes #3709
* RELEASE: 7.64.1curl-7_64_1Daniel Stenberg2019-03-272-10/+48
|
* Revert "ntlm: remove USE_WIN32_CRYPTO check to get USE_NTLM2SESSION set"Daniel Stenberg2019-03-271-1/+1
| | | | | | This reverts commit 9130ead9fcabdb6b8fbdb37c0b38be2d326adb00. Fixes #3708
* ntlm: remove USE_WIN32_CRYPTO check to get USE_NTLM2SESSION setChristian Schmitz2019-03-261-1/+1
| | | | Closes #3704
* tool_cb_wrt: fix writing to Windows null device NULJay Satiro2019-03-261-1/+6
| | | | | | | | | | | | - Improve console detection. Prior to this change WriteConsole could be called to write to a handle that may not be a console, which would cause an error. This issue is limited to character devices that are not also consoles such as the null device NUL. Bug: https://github.com/curl/curl/issues/3175#issuecomment-439068724 Reported-by: Gisle Vanem
* CURLMOPT_PIPELINING.3: fix typoJay Satiro2019-03-251-1/+1
|
* TODO: config file parsingDaniel Stenberg2019-03-251-0/+9
| | | | Closes #3698
* os400: Disable Alt-Svc by default since it's experimentalJay Satiro2019-03-242-3/+8
| | | | | | | | | | | Follow-up to 520f0b4 which added Alt-Svc support and enabled it by default for OS400. Since the feature is experimental, it should be disabled by default. Ref: https://github.com/curl/curl/commit/520f0b4#commitcomment-32792332 Ref: https://curl.haxx.se/mail/lib-2019-02/0008.html Closes https://github.com/curl/curl/pull/3688
* tests: Fixed XML validation errors in some test files.Dan Fandrich2019-03-245-2/+6
|
* tests: Fix some incorrect precheck error messages.Dan Fandrich2019-03-245-5/+5
| | | | [ci skip]
* curl_url.3: this is not experimental anymoreDaniel Stenberg2019-03-221-9/+1
|
* travis: bump the used wolfSSL version to 4.0.0Daniel Stenberg2019-03-221-7/+7
| | | | | | | | | Test 311 is now fine, leaving only 313 (CRL) disabled. Test 313 details can be found here: https://github.com/wolfSSL/wolfssl/issues/1546 Closes #3697
* lib: Fix typos in commentsDaniel Gustafsson2019-03-222-2/+2
|
* openssl: if cert type is ENG and no key specified, key is ENG tooDavid Woodhouse2019-03-201-4/+4
| | | | | Fixes #3692 Closes #3692
* sectransp: tvOS 11 is required for ALPN supportDaniel Stenberg2019-03-201-2/+2
| | | | | | | | Reported-by: nianxuejie on github Assisted-by: Nick Zitzmann Assisted-by: Jay Satiro Fixes #3689 Closes #3690
* test1541: threaded connection sharingDaniel Stenberg2019-03-184-2/+189
| | | | | | | | | The threaded-shared-conn.c example turned into test case. Only works if pthread was detected. An attempt to detect future regressions such as e3a53e3efb942a5 Closes #3687
* os400: alt-svc support.Patrick Monnerat2019-03-174-3/+29
| | | | | Although experimental, enable it in the platform config file. Upgrade ILE/RPG binding.
* conncache: use conn->data to know if a transfer owns itDaniel Stenberg2019-03-172-7/+11
| | | | | | | | | | | | | - make sure an already "owned" connection isn't returned unless multiplexed. - clear ->data when returning the connection to the cache again Regression since 7.62.0 (probably in commit 1b76c38904f0) Bug: https://curl.haxx.se/mail/lib-2019-03/0064.html Closes #3686
* RELEASE-NOTES: syncedDaniel Stenberg2019-03-151-12/+32
|
* configure: add --with-amisslChris Young2019-03-158-21/+194
| | | | | | | | | | AmiSSL is an Amiga native library which provides a wrapper over OpenSSL. It also requires all programs using it to use bsdsocket.library directly, rather than accessing socket functions through clib, which libcurl was not necessarily doing previously. Configure will now check for the headers and ensure they are included if found. Closes #3677
* vtls: rename some of the SSL functionsChris Young2019-03-152-5/+5
| | | | | ... in the SSL structure as AmiSSL is using macros for the socket API functions.
* tool_getpass: termios.h is present on AmigaOS 3, but no tcgetattr/tcsetattrChris Young2019-03-151-1/+5
|
* tool_operate: build on AmigaOSChris Young2019-03-151-3/+7
|
* makefile: make checksrc and hugefile commands "silent"Daniel Stenberg2019-03-147-25/+65
| | | | | | | ... to match the style already used for compiling, linking etc. Acknowledges 'make V=1' to enable verbose. Closes #3681
* curl.1: --user and --proxy-user are hidden from ps outputDaniel Stenberg2019-03-142-0/+12
| | | | | | | | Suggested-by: Eric Curtin Improved-by: Dan Fandrich Ref: #3680 Closes #3683