summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* openssl: fix the SSL_get_tlsext_status_ocsp_resp callbagder/SSL_get_tlsext_status_ocsp_respDaniel Stenberg2019-01-151-3/+4
| | | | | | | | .... to not pass in a const in the second argument as that's not how it is supposed to be used and might cause compiler warnings. Reported-by: Pavel Pavlov Fixes #3477
* curl-compilers.m4: detect xlclangDaniel Stenberg2019-01-151-2/+11
| | | | | | | | | Since it isn't totally clang compatible, we detect this IBM clang front-end and if detected, avoids some clang specific magic. Reported-by: Kees Dekker Fixes #3474 Closes #3476
* README: add codacy code quality badgeDaniel Stenberg2019-01-151-0/+1
| | | | [skip ci]
* extract_if_dead: follow-up to 54b201b48c90aDaniel Stenberg2019-01-151-2/+1
| | | | | | | | | | extract_if_dead() dead is called from two functions, and only one of them should get conn->data updated and now neither call path clears it. scan-build found a case where conn->data would be NULL dereferenced in ConnectionExists() otherwise. Closes #3473
* multi: remove "Dead assignment"Daniel Stenberg2019-01-151-2/+0
| | | | | | Found by scan-build. Follow-up to 4c35574bb785ce. Closes #3471
* tests: move objnames-* from lib into testsDaniel Stenberg2019-01-157-18/+18
| | | | | | | Since they're used purely for testing purposes, I think they should rather be stored there. Closes #3470
* travis: added cmake build for osxSergei Nikulov2019-01-151-4/+8
|
* cookie: fix comment typo (url_path_len -> uri_path_len)Frank Gevaerts2019-01-141-1/+1
| | | | Closes #3469
* winbuild: conditionally use /DZLIB_WINAPIMarcel Raad2019-01-141-1/+3
| | | | | | | | | | | zlibwapi.lib (dynamic library) and zlibstat.lib (static library) have the ZLIB_WINAPI define set by default. Using them requires that define too. Ref: https://zlib.net/DLL_FAQ.txt Fixes https://github.com/curl/curl/issues/3133 Closes https://github.com/curl/curl/pull/3460
* src/Makefile: make 'tidy' target work for metalink buildsDaniel Stenberg2019-01-141-2/+2
|
* extract_if_dead: use a known working transfer when checking connectionsDaniel Stenberg2019-01-131-2/+2
| | | | | | | | | | | | | Make sure that this function sets a proper "live" transfer for the connection before calling the protocol-specific connection check function, and then clear it again afterward as a non-used connection has no current transfer. Reported-by: Jeroen Ooms Reviewed-by: Marcel Raad Reviewed-by: Daniel Gustafsson Fixes #3463 Closes #3464
* openssl: adapt to 3.0.0, OpenSSL_version_num() is deprecatedDaniel Stenberg2019-01-132-4/+11
| | | | | | OpenSSL_version() replaces OpenSSL_version_num() Closes #3462
* cmake: added checks for HAVE_VARIADIC_MACROS_C99 and HAVE_VARIADIC_MACROS_GCCSergei Nikulov2019-01-112-2/+46
|
* urldata: rename easy_conn to just connDaniel Stenberg2019-01-1115-204/+199
| | | | | | | | | | | | | | | We use "conn" everywhere to be a pointer to the connection. Introduces two functions that "attaches" and "detaches" the connection to and from the transfer. Going forward, we should favour using "data->conn" (since a transfer always only has a single connection or none at all) to "conn->data" (since a connection can have none, one or many transfers associated with it and updating conn->data to be correct is error prone and a frequent reason for internal issues). Closes #3442
* tool_cb_prg: avoid integer overflowDaniel Stenberg2019-01-111-3/+16
| | | | | | | | When calculating the progress bar width. Reported-by: Peng Li Fixes #3456 Closes #3458
* travis: turn off copyright year checks in checksrcDaniel Gustafsson2019-01-111-3/+0
| | | | | | | | | | | Invoking the maintainer intended COPYRIGHTYEAR check for everyone in the PR pipeline is too invasive, especially at the turn of the year when many files get affected. Remove and leave it as a tool for maintainers to verify patches before commits. This reverts f7bdf4b2e1d81b2652b81b9b3029927589273b41. After discussion with: Daniel Stenberg
* KNOWN_BUGS: cmake makes unusable tool_hugehelp.c with MinGWDaniel Stenberg2019-01-101-0/+9
| | | | Closes #3125
* KNOWN_BUGS: Improve --data-urlencode space encodingDaniel Stenberg2019-01-101-0/+8
| | | | Closes #3229
* os400: add a missing closing bracketPatrick Monnerat2019-01-101-0/+1
| | | | | | See https://github.com/curl/curl/issues/3453#issuecomment-453054458 Reported-by: jonrumsey on github
* os400: fix extra parameter syntax error.Patrick Monnerat2019-01-101-2/+2
| | | | | Reported-by: jonrumsey on github Closes #3453
* test1558: verify CURLINFO_PROTOCOL on file:// transferDaniel Stenberg2019-01-104-2/+120
| | | | | | Attempt to reproduce issue #3444. Closes #3447
* RELEASE-NOTES: syncedDaniel Stenberg2019-01-101-19/+33
|
* xattr: strip credentials from any URL that is storedDaniel Stenberg2019-01-105-10/+177
| | | | | | | | | Both user and password are cleared uncondtitionally. Added unit test 1621 to verify. Fixes #3423 Closes #3433
* cookies: allow secure override when done over HTTPSDaniel Stenberg2019-01-103-3/+75
| | | | | | | | Added test 1562 to verify. Reported-by: Jeroen Ooms Fixes #3445 Closes #3450
* multi: multiplexing improvementsDaniel Stenberg2019-01-102-104/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #3436 Closes #3448 Problem 1 After LOTS of scratching my head, I eventually realized that even when doing 10 uploads in parallel, sometimes the socket callback to the application that tells it what to wait for on the socket, looked like it would reflect the status of just the single transfer that just changed state. Digging into the code revealed that this was indeed the truth. When multiple transfers are using the same connection, the application did not correctly get the *combined* flags for all transfers which then could make it switch to READ (only) when in fact most transfers wanted to get told when the socket was WRITEABLE. Problem 1b A separate but related regression had also been introduced by me when I cleared connection/transfer association better a while ago, as now the logic couldn't find the connection and see if that was marked as used by more transfers and then it would also prematurely remove the socket from the socket hash table even in times other transfers were still using it! Fix 1 Make sure that each socket stored in the socket hash has a "combined" action field of what to ask the application to wait for, that is potentially the ORed action of multiple parallel transfers. And remove that socket hash entry only if there are no transfers left using it. Problem 2 The socket hash entry stored an association to a single transfer using that socket - and when curl_multi_socket_action() was called to tell libcurl about activities on that specific socket only that transfer was "handled". This was WRONG, as a single socket/connection can be used by numerous parallel transfers and not necessarily a single one. Fix 2 We now store a list of handles in the socket hashtable entry and when libcurl is told there's traffic for a particular socket, it now iterates over all known transfers using that single socket.
* test1561: improve test nameDaniel Stenberg2019-01-091-1/+1
| | | | [skip ci]
* cookies: skip custom cookies when redirecting cross-siteKatsuhiko YOSHIDA2019-01-094-2/+97
| | | | Closes #3417
* THANKS: fixups and a dedupeDaniel Stenberg2019-01-093-6/+6
| | | | [skip ci]
* timediff: fix math for unsigned time_tDaniel Stenberg2019-01-091-3/+3
| | | | | | Bug: https://curl.haxx.se/mail/lib-2018-12/0088.html Closes #3449
* tests: allow tests to pass by 2037-02-12Bernhard M. Wiedemann2019-01-088-23/+23
| | | | | | similar to commit f508d29f3902104018 Closes #3443
* RELEASE-NOTES: syncedDaniel Stenberg2019-01-071-6/+27
|
* curl_multi_remove_handle() don't block terminating c-ares requestsBrad Spencer2019-01-078-21/+225
| | | | | | | | | Added Curl_resolver_kill() for all three resolver modes, which only blocks when necessary, along with test 1592 to confirm curl_multi_remove_handle() doesn't block unless it must. Closes #3428 Fixes #3371
* Revert "http_negotiate: do not close connection until negotiation is completed"Daniel Stenberg2019-01-072-10/+3
| | | | | | | | | This reverts commit 07ebaf837843124ee670e5b8c218b80b92e06e47. This also reopens PR #3275 which brought the change now reverted. Fixes #3384 Closes #3439
* curl/urlapi.h: include "curl.h" firstDaniel Stenberg2019-01-071-1/+3
| | | | | | | | | This allows programs to include curl/urlapi.h directly. Reviewed-by: Daniel Gustafsson Reported-by: Ben Kohler Fixes #3438 Closes #3441
* VS projects: fix build warningMarcel Raad2019-01-061-28/+0
| | | | | | | | | | | | Starting with Visual Studio 2017 Update 9, Visual Studio doesn't like the MinimalRebuild option anymore and warns: cl : Command line warning D9035: option 'Gm' has been deprecated and will be removed in a future release The option can be safely removed so that the default is used. Closes https://github.com/curl/curl/pull/3425
* schannel: fix compiler warningMarcel Raad2019-01-061-3/+3
| | | | | | | | | When building with Unicode on MSVC, the compiler warns about freeing a pointer to const in Curl_unicodefree. Fix this by declaring it as non-const and casting the argument to Curl_convert_UTF8_to_tchar to non-const too, like we do in all other places. Closes https://github.com/curl/curl/pull/3435
* printf: introduce CURL_FORMAT_TIMEDIFF_TRikard Falkeborn2019-01-043-12/+17
|
* printf: fix format specifiersRikard Falkeborn2019-01-047-20/+19
| | | | Closes #3426
* libtest/stub_gssapi: use "real" snprintfDaniel Stenberg2019-01-031-7/+6
| | | | | | | | | | | | | ... since it doesn't link with libcurl. Reverts the commit dcd6f81025 changes from this file. Bug: https://curl.haxx.se/mail/lib-2019-01/0000.html Reported-by: Shlomi Fish Reviewed-by: Daniel Gustafsson Reviewed-by: Kamil Dudka Closes #3434
* INTERNALS: correct some outdated function namesDaniel Stenberg2019-01-031-14/+10
| | | | Closes #3431
* docs/version.d: mention MultiSSLDaniel Stenberg2019-01-031-0/+2
| | | | | Reviewed-by: Daniel Gustafsson Closes #3432
* examples: Update .gitignoreRikard Falkeborn2019-01-021-0/+3
| | | | | | | | Add a few missing examples to make `make examples` not leave the workspace in a dirty state. Closes #3427 Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
* THANKS: add more missing namesDaniel Gustafsson2019-01-021-0/+1
| | | | | Add Adrian Burcea who made the artwork for the curl://up 2018 event which was held in Stockholm, Sweden.
* docs: mention potential leak in curl_slist_appendDaniel Gustafsson2019-01-021-2/+14
| | | | | | | | | | | | | When a non-empty list is appended to, and used as the returnvalue, the list pointer can leak in case of an allocation failure in the curl_slist_append() call. This is correctly handled in curl code usage but we weren't explicitly pointing it out in the API call documentation. Fix by extending the RETURNVALUE manpage section and example code. Closes #3424 Reported-by: dnivras on github Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* tvnow: silence conversion warningsMarcel Raad2019-01-012-2/+2
| | | | | | MinGW-w64 defaults to targeting Windows 7 now, so GetTickCount64 is used and the milliseconds are represented as unsigned long long, leading to a compiler warning when implicitly converting them to long.
* THANKS: dedupe more namesDaniel Stenberg2019-01-012-16/+17
| | | | Researched-by: Tae Wong
* ntlm: update selection of type 3 responseMarkus Moeller2019-01-0138-148/+150
| | | | | | | | | | | NTLM2 did not work i.e. no NTLMv2 response was created. Changing the check seems to work. Ref: https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-NLMP/[MS-NLMP].pdf Fixes https://github.com/curl/curl/issues/3286 Closes https://github.com/curl/curl/pull/3287 Closes https://github.com/curl/curl/pull/3415
* THANKS: added missing names from year <= 2000Daniel Stenberg2018-12-311-0/+59
| | | | | Due to a report of a missing name in THANKS I manually went through an old CHANGES.0 file and added many previously missing names here.
* urlapi: fix parsing ipv6 with zone indexDaniel Gustafsson2018-12-302-2/+13
| | | | | | | | | | | | | | The previous fix for parsing IPv6 URLs with a zone index was a paddle short for URLs without an explicit port. This patch fixes that case and adds a unit test case. This bug was highlighted by issue #3408, and while it's not the full fix for the problem there it is an isolated bug that should be fixed regardless. Closes #3411 Reported-by: GitYuanQu on github Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* THANKS: dedupe Guenter KnaufDaniel Stenberg2018-12-302-1/+1
| | | | Reported-by: Tae Wong
View Lorry Controller Status