summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Curl_inet_ntop: always check the return codebagder/Curl_inet_ntopDaniel Stenberg2020-06-242-7/+13
| | | | | Reported-by: Siva Sivaraman Fixes #5412
* url: make sure pushed streams get an allocated download bufferDaniel Stenberg2020-06-233-4/+11
| | | | | | | | | Follow-up to c4e6968127e876b0 When a new transfer is created, as a resuly of an acknowledged push, that transfer needs a download buffer allocated. Closes #5590
* openssl: Don't ignore CA paths when using Windows CA storeJay Satiro2020-06-223-15/+13
| | | | | | | | | | | | | This commit changes the behavior of CURLSSLOPT_NATIVE_CA so that it does not override CURLOPT_CAINFO / CURLOPT_CAPATH, or the hardcoded default locations. Instead the CA store can now be used at the same time. The change is due to the impending release. The issue is still being discussed. The behavior of CURLSSLOPT_NATIVE_CA is subject to change and is now documented as experimental. Ref: bc052cc (parent commit) Ref: https://github.com/curl/curl/issues/5585
* tool_operate: Don't use Windows CA store as a fallbackJay Satiro2020-06-221-8/+0
| | | | | | | | | | | | | | | | | | | | | | | Background: 148534d added CURLSSLOPT_NATIVE_CA to use the Windows OS certificate store in libcurl w/ OpenSSL on Windows. CURLSSLOPT_NATIVE_CA overrides CURLOPT_CAINFO if both are set. The curl tool will fall back to CURLSSLOPT_NATIVE_CA if it could not find a certificate bundle to set via CURLOPT_CAINFO. Problem: libcurl may be built with hardcoded paths to a certificate bundle or directory, and if CURLSSLOPT_NATIVE_CA is used then those paths are ignored. Solution: A solution is still being discussed but since there's an impending release this commit removes using CURLSSLOPT_NATIVE_CA in the curl tool. Ref: https://github.com/curl/curl/issues/5585
* openssl: Fix CA fallback logic for OpenSSL 3.0 buildJay Satiro2020-06-221-1/+1
| | | | | | | Prior to this change I assume a build error would occur when CURL_CA_FALLBACK was used. Closes https://github.com/curl/curl/pull/5587
* copyright: update mismatched copyright yearsDaniel Stenberg2020-06-224-4/+4
|
* test1460: verify that -Ji is not okDaniel Stenberg2020-06-222-1/+65
|
* tool_getparam: -i is not OK if -J is usedDaniel Stenberg2020-06-222-18/+9
| | | | | Reported-by: sn on hackerone Bug: https://curl.haxx.se/docs/CVE-2020-8177.html
* CMake: ignore INTERFACE_LIBRARY targets for pkg-config filePeter Wu2020-06-211-1/+9
| | | | | | Reviewed-by: Marcel Raad Fixes #5512 Closes #5517
* multibyte: Fixed access-> waccess to file for Windows PlarformValentyn Korniienko2020-06-212-0/+25
| | | | | Reviewed-by: Marcel Raad Closes #5580
* altsvc: bump to h3-29Daniel Stenberg2020-06-191-2/+2
| | | | Closes #5584
* urlglob: treat literal IPv6 addresses with zone IDs as a host nameDaniel Stenberg2020-06-181-20/+27
| | | | | | | | | | ... and not as a "glob". Now done by passing the supposed host to the URL parser which supposedly will do a better job at identifying "real" numerical IPv6 addresses. Reported-by: puckipedia on github Fixes #5576 Closes #5579
* test1179: verify error message for non-existing cmdline optionDaniel Stenberg2020-06-182-1/+44
|
* tool_getparam: repair the error message for unknown flagDaniel Stenberg2020-06-181-1/+2
| | | | | | | Follow-up to 9e5669f3880674 Detected by Coverity CID 1464582 ("Logically dead code") Closes #5577
* FILEFORMAT: describe verify/stderrDaniel Stenberg2020-06-181-0/+9
|
* connect: improve happy eyeballs handlingDaniel Stenberg2020-06-185-58/+84
| | | | | | | | For QUIC but also for regular TCP when the second family runs out of IPs with a failure while the first family is still trying to connect. Separated the timeout handling for IPv4 and IPv6 connections when they both have a number of addresses to iterate over.
* ngtcp2: never call fprintf() in lib code in release versionDaniel Stenberg2020-06-181-12/+14
|
* ngtcp2: fix happy eyeballs quic connect crashDaniel Stenberg2020-06-181-1/+2
| | | | | | Reported-by: Peter Wu Fixes #5565 Closes #5568
* select: remove the unused ELAPSED_MS() macroDaniel Stenberg2020-06-181-3/+0
| | | | Closes #5573
* multi: implement wait using winsock eventsrcombs2020-06-172-4/+122
| | | | | | | | | | | | This avoids using a pair of TCP ports to provide wakeup functionality for every multi instance on Windows, where socketpair() is emulated using a TCP socket on loopback which could in turn lead to socket resource exhaustion. Reviewed-by: Gergely Nagy Reviewed-by: Marc Hörsken Closes #5397
* manpage: add three missing environment variablesDaniel Stenberg2020-06-171-1/+17
| | | | | | CURL_SSL_BACKEND, QLOGDIR and SSLKEYLOGFILE Closes #5571
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-161-13/+28
|
* configure: for wolfSSL, check for the DES func needed for NTLMDaniel Stenberg2020-06-161-6/+50
| | | | Also adds pkg-config support for the wolfSSL detection.
* ntlm: enable NTLM support with wolfSSLRuurd Beerstra2020-06-165-19/+24
| | | | | | | | | When wolfSSL is built with its OpenSSL API layer, it fetures the same DES* functions that OpenSSL has. This change take advantage of that. Co-authored-by: Daniel Stenberg Closes #5556 Fixes #5548
* http: move header storage to Curl_easy from connectdataDaniel Stenberg2020-06-1510-130/+137
| | | | | | | | | | | | Since the connection can be used by many independent requests (using HTTP/2 or HTTP/3), things like user-agent and other transfer-specific data MUST NOT be kept connection oriented as it could lead to requests getting the wrong string for their requests. This struct data was lingering like this due to old HTTP1 legacy thinking where it didn't mattered.. Fixes #5566 Closes #5567
* CODE_REVIEW.md: how to do code reviews in curlDaniel Stenberg2020-06-132-0/+169
| | | | | | | | | | | Assisted-by: Daniel Gustafsson Assisted-by: Rich Salz Assisted-by: Hugo van Kemenade Assisted-by: James Fuller Assisted-by: Marc Hörsken Assisted-by: Jay Satiro Closes #5555
* altsvc: remove the num field from the altsvc structDaniel Stenberg2020-06-123-12/+8
| | | | | | | | It was superfluous since we have the list.size alredy Reported-by: Jay Satiro Fixes #5553 Closes #5563
* version.d: expanded and alpha-sortedDaniel Stenberg2020-06-121-28/+36
| | | | | | | Added a few missing features not previously mentioned. Ordered them alphabetically. Closes #5558
* ABI.md: rename to .md and polish the markdownDaniel Stenberg2020-06-122-19/+14
| | | | Closes #5562
* HELP-US: add a section for "smaller tasks"Daniel Stenberg2020-06-121-0/+17
| | | | | | | | | | The point of this section is to meet the CII Best Practices gold level critera: "The project MUST clearly identify small tasks that can be performed by new or casual contributors" Closes #5560
* TODO: retry on the redirected-to URLDaniel Stenberg2020-06-121-0/+12
| | | | Closes #5462
* mailmap: Nicolas StercheleDaniel Stenberg2020-06-121-0/+1
|
* TODO: remove 19.3 section titleSterchele Nicolas2020-06-121-1/+1
| | | | | | | Follow-up to ad6416986755e417c66e2c6, which caused wrong formatting on curl documentation website Closes #5561
* test1560: avoid possibly negative association in wordingMartin V2020-06-121-14/+14
| | | | Closes #5549
* share: don't set the share flag it something failsDaniel Stenberg2020-06-121-3/+5
| | | | | | | | When asking for a specific feature to be shared in the share object, that bit was previously set unconditionally even if the shared feature failed or otherwise wouldn't work. Closes #5554
* buildconf: remove -print from the find command that removes filesDaniel Stenberg2020-06-101-1/+1
| | | | It's just too annoying and unnecessary to get a long list of files shown
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-101-9/+36
|
* wording: avoid blacklist/whitelist stereotypesDaniel Stenberg2020-06-1017-70/+67
| | | | | | | | Instead of discussing if there's value or meaning (implied or not) in the colors, let's use words without the same possibly negative associations. Closes #5546
* tool_getparam: fix memory leak in parse_argsJay Satiro2020-06-091-0/+2
| | | | | | | | | Prior to this change in Windows Unicode builds most parsed options would not be freed. Found using _CrtDumpMemoryLeaks(). Ref: https://github.com/curl/curl/issues/5545
* socks: detect connection close during handshakeDaniel Stenberg2020-06-081-4/+28
| | | | | | | | | The SOCKS4/5 state machines weren't properly terminated when the proxy connection got closed, leading to a busy-loop. Reported-By: zloi-user on github Fixes #5532 Closes #5542
* multi: add defensive check on data->multi->num_alivexquery2020-06-081-1/+3
| | | | Closes #5540
* Curl_addrinfo: use one malloc instead of threeDaniel Stenberg2020-06-083-69/+30
| | | | | | | | To reduce the amount of allocations needed for creating a Curl_addrinfo struct, make a single larger malloc instead of three separate smaller ones. Closes #5533
* quiche: update SSLKEYLOGFILE supportAlessandro Ghedini2020-06-081-1/+7
| | | | | | | | quiche now requires the application to explicitly set the keylog path for each connection, rather than reading the environment variable itself. Closes #5541
* tests: add two simple tests for --login-optionsDaniel Stenberg2020-06-083-6/+94
| | | | | | Test 895 and 896 - as a follow-up to a3e972313b Closes #5539
* ngtcp2: update with recent API changesDaniel Stenberg2020-06-081-5/+8
| | | | | | | Syncs with ngtcp2 commit 7e9a917d386d98 merged June 7 2020. Assisted-by: Tatsuhiro Tsujikawa Closes #5538
* socks: remove unreachable breaks in socks.c and mime.cxquery2020-06-082-5/+3
| | | | Closes #5537
* tool_cfgable: free login_options at exitDaniel Stenberg2020-06-081-0/+1
| | | | | | | Memory leak Reported-by: Geeknik Labs Fixes #5535 Closes #5536
* libssh2: keep sftp errors as 'unsigned long'Daniel Stenberg2020-06-081-62/+66
| | | | | | | Remove weird work-around for storing the SFTP errors as int instead of the "unsigned long" that libssh2 actually returns for SFTP errors. Closes #5534
* timeouts: move ms timeouts to timediff_t from int and longMarc Hoersken2020-06-065-9/+13
| | | | | | | | | | | | | Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73de. Based upon #5262 Supersedes #5214, #5220 and #5221 Follow up to #5343 and #5479 Closes #5490
* openssl: set FLAG_TRUSTED_FIRST unconditionallyFrançois Rigault2020-06-061-4/+3
| | | | | | | | | | | | | On some systems, openssl 1.0.x is still the default, but it has been patched to contain all the recent security fixes. As a result of this patching, it is possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous behavior of openssl to not look at trusted chains first, remains. Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for the behavior of openssl based on the existence ofmacros. Closes #5530