summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* tests: Run global cleanup at end of testsDaniel Gustafsson2019-04-154-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Make sure to run curl_global_cleanup() when shutting down the test suite to release any resources allocated in the SSL setup. This is clearly visible when running tests with PolarSSL where the thread lock calloc() memory which isn't released when not running cleanup. Below is an excerpt from the autobuild logs: ==12368== 96 bytes in 1 blocks are possibly lost in loss record 1 of 2 ==12368== at 0x4837B65: calloc (vg_replace_malloc.c:752) ==12368== by 0x11A76E: curl_dbg_calloc (memdebug.c:205) ==12368== by 0x145CDF: Curl_polarsslthreadlock_thread_setup (polarssl_threadlock.c:54) ==12368== by 0x145B37: Curl_polarssl_init (polarssl.c:865) ==12368== by 0x14129D: Curl_ssl_init (vtls.c:171) ==12368== by 0x118B4C: global_init (easy.c:158) ==12368== by 0x118BF5: curl_global_init (easy.c:221) ==12368== by 0x118D0B: curl_easy_init (easy.c:299) ==12368== by 0x114E96: test (lib1906.c:32) ==12368== by 0x115495: main (first.c:174) Closes #3783 Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* travis: use mbedtls from XenialMarcel Raad2019-04-151-13/+1
| | | | | | No need to build it from source anymore. Closes https://github.com/curl/curl/pull/3779
* travis: use libpsl from XenialMarcel Raad2019-04-151-29/+46
| | | | | | | This makes building libpsl and libidn2 from source unnecessary and removes the need for the autopoint and libunistring-dev packages. Closes https://github.com/curl/curl/pull/3779
* runtests: start socksd like other serversDaniel Stenberg2019-04-151-1/+1
| | | | | | | ... without a $srcdir prefix. Triggered by the failures in several autobuilds. Closes #3781
* socksd: Fix typosDaniel Gustafsson2019-04-141-2/+2
| | | | Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* socksd: Properly decorate static variablesDaniel Gustafsson2019-04-141-4/+4
| | | | | | | | Mark global variables static to avoid compiler warning in Clang when using -Wmissing-variable-declarations. Closes #3778 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* md(4|5): Fixed indentation oddities with the importation of replacement codeSteve Holme2019-04-142-114/+114
| | | | | | | The indentation from 211d5329 and 57d6d253 was a little strange as parts didn't align correctly, uses 4 spaces rather than 2. Checked the indentation of the original source so it aligns, albeit, using curl style.
* md5: Code style to return CURLE_OK rather than numeric 0Steve Holme2019-04-141-2/+2
|
* md5: Corrected code style for some pointer argumentsSteve Holme2019-04-141-6/+6
|
* travis: update some builds to xenialMarcel Raad2019-04-131-26/+26
| | | | | | | | | Xenial comes with more up-to-date software versions and more available packages, some of which we currently build from source. Unfortunately, some builds would fail with Xenial because of assertion failures in Valgrind when using OpenSSL, so leave these at Trusty. Closes https://github.com/curl/curl/pull/3777
* test: make tests and test scripts use socksd for SOCKSDaniel Stenberg2019-04-139-142/+149
| | | | Make all SOCKS tests use socksd instead of ssh.
* socksd: new SOCKS 4+5 server for testsDaniel Stenberg2019-04-133-1/+1174
| | | | Closes #3752
* singleipconnect: show port in the verbose "Trying ..." messageDaniel Stenberg2019-04-131-1/+1
| | | | To aid debugging better.
* CURLOPT_ADDRESS_SCOPE: fix range check and moretmilburn2019-04-134-25/+26
| | | | | | | | | | | | | | | | | Commit 9081014 fixed most of the confusing issues between scope id and scope however 844896d added bad limits checking assuming that the scope is being set and not the scope id. I have fixed the documentation so it all refers to scope ids. In addition Curl_if2ip refered to the scope id as remote_scope_id which is incorrect, so I renamed it to local_scope_id. Adjusted-by: Daniel Stenberg Closes #3655 Closes #3765 Fixes #3713
* urlapi: stricter CURLUPART_PORT parsingDaniel Stenberg2019-04-133-33/+80
| | | | | | | | | | | Only allow well formed decimal numbers in the input. Document that the number MUST be between 1 and 65535. Add tests to test 1560 to verify the above. Ref: https://github.com/curl/curl/issues/3753 Closes #3762
* winbuild: Support MultiSSL buildsJan-E2019-04-132-6/+6
| | | | | | | | | | - Remove the lines in winbuild/Makefile.vc that generate an error with multiple SSL backends. - Add /DCURL_WITH_MULTI_SSL in winbuild/MakefileBuild.vc if multiple SSL backends are set. Closes https://github.com/curl/curl/pull/3772
* travis: remove mesalink builds (temporarily?)Daniel Stenberg2019-04-121-29/+0
| | | | | | | | Since the mesalink build started to fail on travis, even though we build a fixed release version, we disable it to prevent it from blocking progress. Closes #3767
* openssl: mark connection for close on TLS close_notifyDaniel Stenberg2019-04-121-0/+3
| | | | | | | | | Without this, detecting and avoid reusing a closed TLS connection (without a previous GOAWAY) when doing HTTP/2 is tricky. Reported-by: Tom van der Woerdt Fixes #3750 Closes #3763
* RELEASE-NOTES: syncedDaniel Stenberg2019-04-121-3/+31
|
* vauth/cleartext: Update the PLAIN login function signature to match RFC 4616Steve Holme2019-04-113-23/+27
| | | | | | | Functionally this doesn't change anything as we still use the username for both the authorisation identity and the authentication identity. Closes #3757
* test1906: verify CURLOPT_CURLU + CURLOPT_PORT usageDaniel Stenberg2019-04-114-2/+129
| | | | Based-on-code-by: Poul T Lomholt
* url: always clone the CUROPT_CURLU handleDaniel Stenberg2019-04-111-3/+2
| | | | | | | | | Since a few code paths actually update that data. Fixes #3753 Closes #3761 Reported-by: Poul T Lomholt
* CURLOPT_DNS_USE_GLOBAL_CACHE: removeDaniel Stenberg2019-04-119-119/+35
| | | | | | | | Remove the code too. The functionality has been disabled in code since 7.62.0. Setting this option will from now on simply be ignored and have no function. Closes #3654
* travis: install libgnutls28-dev only for --with-gnutls buildMarcel Raad2019-04-111-1/+1
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install libnss3-dev only for --with-nss buildMarcel Raad2019-04-111-1/+1
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install libssh2-dev only for --with-libssh2 buildMarcel Raad2019-04-111-1/+1
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install libssh-dev only for --with-libssh buildMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install krb5-user only for --with-gssapi buildMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install lcov only for the coverage jobMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install clang only when neededMarcel Raad2019-04-111-5/+91
| | | | | | | This reduces the GCC job runtimes a little and it's needed to selectively update clang builds to xenial. Closes https://github.com/curl/curl/pull/3721
* AppVeyor: enable testing for WinSSL buildMarcel Raad2019-04-111-3/+3
| | | | Closes https://github.com/curl/curl/pull/3725
* build: fix Codacy/CppCheck warningsMarcel Raad2019-04-1116-17/+24
| | | | | | | | | | - remove unused variables - declare conditionally used variables conditionally - suppress unused variable warnings in the CMake tests - remove dead variable stores - consistently use WIN32 macro to detect Windows Closes https://github.com/curl/curl/pull/3739
* polarssl_threadlock: remove conditionally unused codeMarcel Raad2019-04-112-29/+23
| | | | | | | | | | | | | Make functions no-ops if neither both USE_THREADS_POSIX and HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are defined. Previously, if only one of them was defined, there was either code compiled that did nothing useful or the wrong header included for the functions used. Also, move POLARSSL_MUTEX_T define to implementation file as it's not used externally. Closes https://github.com/curl/curl/pull/3739
* lib557: initialize variablesMarcel Raad2019-04-111-7/+7
| | | | | | These variables are only conditionally initialized. Closes https://github.com/curl/curl/pull/3739
* lib509: add missing include for strdupMarcel Raad2019-04-111-0/+2
| | | | Closes https://github.com/curl/curl/pull/3739
* README.md: fix no-consecutive-blank-lines Codacy warningMarcel Raad2019-04-111-1/+0
| | | | | | Consistently use one blank line between blocks. Closes https://github.com/curl/curl/pull/3739
* tests/server/util: fix Windows Unicode buildMarcel Raad2019-04-111-2/+2
| | | | | | | Always use the ANSI version of FormatMessage as we don't have the curl_multibyte gear available here. Closes https://github.com/curl/curl/pull/3758
* curl_easy_getinfo.3: fix minor formatting mistakeDaniel Stenberg2019-04-111-2/+2
|
* xattr: skip unittest on unsupported platformsDaniel Gustafsson2019-04-111-1/+3
| | | | | | | | | | | | | | | | | | | | | | | The stripcredentials unittest fails to compile on platforms without xattr support, for example the Solaris member in the buildfarm which fails with the following: CC unit1621-unit1621.o CC ../libtest/unit1621-first.o CCLD unit1621 Undefined first referenced symbol in file stripcredentials unit1621-unit1621.o goto problem 2 ld: fatal: symbol referencing errors. No output written to .libs/unit1621 collect2: error: ld returned 1 exit status gmake[2]: *** [Makefile:996: unit1621] Error 1 Fix by excluding the test on such platforms by using the reverse logic from where stripcredentials() is defined. Closes #3759 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* emailL Added reference to RFC8314 for implicit TLSSteve Holme2019-04-113-0/+3
|
* README: Schannel, stop calling it "winssl"Steve Holme2019-04-101-6/+6
| | | | Stick to "Schannel" everywhere - follow up to 180501cb.
* cmake: clear CMAKE_REQUIRED_LIBRARIES after each useJakub Zakrzewski2019-04-101-0/+3
| | | | | | | | | | This fixes GSSAPI builds with the libraries in a non-standard location. The testing for recv() were failing because it failed to link the Kerberos libraries, which are not needed for this or subsequent tests. fixes #3743 closes #3744
* cmake: avoid linking executable for some tests with cmake 3.6+Jakub Zakrzewski2019-04-101-35/+40
| | | | | | | | | | | | With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. This commit also avoids #3743 (GSSAPI build errors) on itself with cmake 3.6 or above. That issue was fixed separately for all versions. Ref: #3744
* cmake: minor cleanupJakub Zakrzewski2019-04-101-7/+1
| | | | | | | | | | | | - Remove nneeded include_regular_expression. It was setting what is already a default. - Remove duplicated include. - Don't check for pre-3.0.0 CMake version. We already require at least 3.0.0, so it's just clutter. Ref: #3744
* build-openssl.bat: Fixed support for OpenSSL v1.1.0+Steve Holme2019-04-081-117/+240
|
* build-openssl.bat: Perfer the use of if statements rather than goto (where ↵Steve Holme2019-04-081-141/+137
| | | | possible)
* build-openssl.bat: Perform the install for each build type directly after ↵Steve Holme2019-04-081-12/+28
| | | | the build
* build-openssl.bat: Split the install of static and shared build typesSteve Holme2019-04-081-41/+65
|
* build-openssl.bat: Split the building of static and shared build typesSteve Holme2019-04-081-6/+17
|
* build-openssl.bat: Move the installation into a separate functionSteve Holme2019-04-081-84/+66
|