summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* TODO: remove configure --disable-pthreadsDaniel Stenberg2018-05-021-6/+11
|
* wolfssl: Fix non-blocking connectDavid Garske2018-05-021-1/+1
| | | | Closes https://github.com/curl/curl/pull/2542
* CURLOPT_URL.3: add ENCODING section [ci skip]Daniel Stenberg2018-04-301-1/+11
| | | | Feedback-by: Michael Kilburn
* KNOWN_BUGS: Client cert with Issuer DN differs between backendsDaniel Stenberg2018-04-301-0/+8
| | | | Closes #1411
* KNOWN_BUGS: Passive transfer tries only one IP addressDaniel Stenberg2018-04-301-0/+13
| | | | Closes #1508
* KNOWN_BUGS: --upload-file . hang if delay in STDINDaniel Stenberg2018-04-301-0/+8
| | | | Closes #2051
* KNOWN_BUGS: Connection information when using TCP Fast OpenDaniel Stenberg2018-04-301-0/+8
| | | | Closes #1332
* travis: enable libssh2 on both macos and LinuxDaniel Stenberg2018-04-301-2/+2
| | | | | | | It seems to not be detected by default anymore (which is a bug I believe) Closes #2541
* TODO: Support the clienthello extensionDaniel Stenberg2018-04-301-0/+11
| | | | Closes #2299
* TODO: CLOEXECDaniel Stenberg2018-04-301-0/+9
| | | | Closes #2252
* tests: provide 'manual' as a feature to optionally requireDaniel Stenberg2018-04-293-0/+21
| | | | | | | | | ... and make test 1026 rely on that feature so that --disable-manual builds don't cause test failures. Reported-by: Max Dymond and Anders Roxell Fixes #2533 Closes #2540
* CURLINFO_PROTOCOL.3: mention the existing defined namesDaniel Stenberg2018-04-271-3/+12
|
* cookies: remove unused macroDaniel Gustafsson2018-04-271-1/+0
| | | | | | | Commit 2bc230de63 made the macro MAX_COOKIE_LINE_TXT become unused, so remove as it's not part of the published API. Closes https://github.com/curl/curl/pull/2537
* checksrc: force indentation of lines after an elseDaniel Gustafsson2018-04-277-17/+11
| | | | | | | | This extends the INDENTATION case to also handle 'else' statements and require proper indentation on the following line. Also fixes the offending cases found in the codebase. Closes #2532
* http2: fix null pointer dereference in http2_connisdeadDaniel Stenberg2018-04-261-2/+5
| | | | | | | | | | | This function can get called on a connection that isn't setup enough to have the 'recv_underlying' function pointer initialized so it would try to call the NULL pointer. Reported-by: Dario Weisser Follow-up to db1b2c7fe9b093f8 (never shipped in a release) Closes #2536
* http2: get rid of another strstr()Daniel Stenberg2018-04-261-2/+4
| | | | | | | | | | | | | Follow-up to 1514c44655e12e: replace another strstr() call done on a buffer that might not be zero terminated - with a memchr() call, even if we know the substring will be found. Assisted-by: Max Dymond Detected by OSS-Fuzz Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8021 Closes #2534
* cyassl: adapt to libraries without TLS 1.0 support built-inDaniel Stenberg2018-04-261-1/+6
| | | | WolfSSL doesn't enable it by default anymore
* configure: provide --with-wolfssl as an alias for --with-cyasslDaniel Stenberg2018-04-261-0/+6
|
* RELEASE-NOTES: syncedDaniel Stenberg2018-04-251-4/+17
|
* os400.c: fix ASSIGNWITHINCONDITION checksrc warningsDaniel Gustafsson2018-04-251-57/+93
| | | | | | | | | | | | | | All occurrences of assignment within conditional expression in os400sys.c rewritten into two steps: first assignment and then the check on the success of the assignment. Also adjust related incorrect brace positions to match project indentation style. This was spurred by seeing "if((inp = input_token))", but while in there all warnings were fixed. There should be no functional change from these changes. Closes #2525
* cookies: ensure that we have cookies before writing jarDaniel Gustafsson2018-04-251-0/+4
| | | | | | | The jar should be written iff there are cookies, so ensure that we still have cookies after expiration to avoid creating an empty file. Closes #2529
* strcpy_url: only %-encode values >= 0x80Daniel Stenberg2018-04-251-1/+1
| | | | | | | | OSS-Fuzz detected https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8000 Broke in dd7521bcc1b7
* mime: avoid NULL pointer dereference riskDaniel Stenberg2018-04-241-1/+1
| | | | | | Coverity detected, CID 1435120 Closes #2527
* ctype: restore character classification for non-ASCII platformsStephan Mühlstrasser2018-04-244-2/+49
| | | | | | | | | | | With commit 4272a0b0fc49a1ac0ceab5c4a365c9f6ab8bf8e2 curl-speficic character classification macros and functions were introduced in curl_ctype.[ch] to avoid dependencies on the locale. This broke curl on non-ASCII, e.g. EBCDIC platforms. This change restores the previous set of character classification macros when CURL_DOES_CONVERSIONS is defined. Closes #2494
* ftplistparser: keep state between invokesDaniel Stenberg2018-04-245-33/+43
| | | | | | | | | | Fixes FTP wildcard parsing when done over a number of read buffers. Regression from f786d1f14 Reported-by: wncboy on github Fixes #2445 Closes #2526
* examples/http2-upload: expand buffer to avoid silly warningDaniel Stenberg2018-04-241-2/+2
| | | | | http2-upload.c:135:44: error: ‘%02d’ directive output may be truncated writing between 2 and 11 bytes into a region of size between 8 and 17
* examples/sftpuploadresume: typecast fseek argument to longDaniel Stenberg2018-04-241-1/+1
| | | | | /docs/examples/sftpuploadresume.c:102:12: warning: conversion to 'long int' from 'curl_off_t {aka long long int}' may alter its value
* Revert "ftplistparser: keep state between invokes"Daniel Stenberg2018-04-245-43/+32
| | | | | | This reverts commit abbc8457d85aca74b7cfda1d394b0844932b2934. Caused fuzzer problems on travis not seen when this was a PR!
* Curl_memchr: zero length input can't matchDaniel Stenberg2018-04-241-9/+10
| | | | | | Avoids undefined behavior. Reported-by: Geeknik Labs
* ftplistparser: keep state between invokesDaniel Stenberg2018-04-235-32/+43
| | | | | | | | | | Fixes FTP wildcard parsing when doing over a number of read buffers. Regression from f786d1f14 Reported-by: wncboy on github Fixes #2445 Closes #2519
* ftplistparser: renamed some members and variablesDaniel Stenberg2018-04-235-47/+47
| | | | ... to make them better spell out what they're for.
* RELEASE-NOTES: syncedDaniel Stenberg2018-04-231-7/+30
|
* curl_global_sslset: always provide available backendsChristian Schmitz2018-04-232-3/+7
| | | | Closes #2499
* http2: convert an assert to run-time checkDaniel Stenberg2018-04-231-2/+4
| | | | | | | | | | | | Fuzzing has proven we can reach code in on_frame_recv with status_code not having been set, so let's detect that in run-time (instead of with assert) and error error accordingly. (This should no longer happen with the latest nghttp2) Detected by OSS-Fuzz Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7903 Closes #2514
* curl.1: clarify that options and URLs can be mixedDaniel Stenberg2018-04-231-4/+4
| | | | | Fixes #2515 Closes #2517
* CURLOPT_SSLCERT.3: improve WinSSL-specific usage infoArchangel_SDY2018-04-232-2/+21
| | | | | | Ref: https://github.com/curl/curl/pull/2376#issuecomment-381858780 Closes https://github.com/curl/curl/pull/2504
* schannel: fix build error on targets <= XPArchangel_SDY2018-04-231-1/+1
| | | | | | | | | - Use CRYPT_STRING_HEX instead of CRYPT_STRING_HEXRAW since XP doesn't support the latter. Ref: https://github.com/curl/curl/pull/2376#issuecomment-382153668 Closes https://github.com/curl/curl/pull/2504
* Revert "ftplistparser: keep state between invokes"Daniel Stenberg2018-04-231-2/+1
| | | | | | | This reverts commit 8fb78f9ddc6d858d630600059b8ad84a80892fd9. Unfortunately this fix introduces memory leaks I've not been able to fix in several days. Reverting this for now to get the leaks fixed.
* tool_help: clarify --max-time unit of time is secondsJay Satiro2018-04-212-2/+2
| | | | | | | | Before: -m, --max-time <time> Maximum time allowed for the transfer After: -m, --max-time <seconds> Maximum time allowed for the transfer
* http2: handle GOAWAY properlyDaniel Stenberg2018-04-204-9/+31
| | | | | | | | | | When receiving REFUSED_STREAM, mark the connection for close and retry streams accordingly on another/fresh connection. Reported-by: Terry Wu Fixes #2416 Fixes #1618 Closes #2510
* http2: clear the "drain counter" when a stream is closedDaniel Stenberg2018-04-201-0/+1
| | | | | | | | | | This fixes the notorious "httpc->drain_total >= data->state.drain" assert. Reported-by: Anders Bakken Fixes #1680 Closes #2509
* http2: avoid strstr() on data not zero terminatedDaniel Stenberg2018-04-201-2/+5
| | | | | | | | | | | | | It's not strictly clear if the API contract allows us to call strstr() on a string that isn't zero terminated even when we know it will find the substring, and clang's ASAN check dislikes us for it. Also added a check of the return code in case it fails, even if I can't think of a situation how that can trigger. Detected by OSS-Fuzz Closes #2513 Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7760
* openssl: fix subjectAltName check on non-ASCII platformsStephan Mühlstrasser2018-04-201-4/+46
| | | | | | | | Curl_cert_hostcheck operates with the host character set, therefore the ASCII subjectAltName string retrieved with OpenSSL must be converted to the host encoding before comparison. Closes #2493
* openssl: Add support for OpenSSL 1.1.1 verbose-mode trace messagesJay Satiro2018-04-201-8/+47
| | | | | | | | | | | - Support handling verbose-mode trace messages of type SSL3_RT_INNER_CONTENT_TYPE, SSL3_MT_ENCRYPTED_EXTENSIONS, SSL3_MT_END_OF_EARLY_DATA, SSL3_MT_KEY_UPDATE, SSL3_MT_NEXT_PROTO, SSL3_MT_MESSAGE_HASH Reported-by: iz8mbw@users.noreply.github.com Fixes https://github.com/curl/curl/issues/2403
* ftplistparser: keep state between invokesDaniel Stenberg2018-04-191-1/+2
| | | | | | | | Regression from f786d1f14 Reported-by: wncboy on github Fixes #2445 Closes #2508
* detect_proxy: only show proxy use if it had contentsDaniel Stenberg2018-04-191-1/+2
|
* http2: handle on_begin_headers() called more than onceDaniel Stenberg2018-04-191-8/+4
| | | | | | | | | | | This triggered an assert if called more than once in debug mode (and a memory leak if not debug build). With the right sequence of HTTP/2 headers incoming it can happen. Detected by OSS-Fuzz Closes #2507 Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7764
* schannel: add support for CURLOPT_CAINFODan McNulty2018-04-1837-258/+1406
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Move verify_certificate functionality in schannel.c into a new file called schannel_verify.c. Additionally, some structure defintions from schannel.c have been moved to schannel.h to allow them to be used in schannel_verify.c. - Make verify_certificate functionality for Schannel available on all versions of Windows instead of just Windows CE. verify_certificate will be invoked on Windows CE or when the user specifies CURLOPT_CAINFO and CURLOPT_SSL_VERIFYPEER. - In verify_certificate, create a custom certificate chain engine that exclusively trusts the certificate store backed by the CURLOPT_CAINFO file. - doc updates of --cacert/CAINFO support for schannel - Use CERT_NAME_SEARCH_ALL_NAMES_FLAG when invoking CertGetNameString when available. This implements a TODO in schannel.c to improve handling of multiple SANs in a certificate. In particular, all SANs will now be searched instead of just the first name. - Update tool_operate.c to not search for the curl-ca-bundle.crt file when using Schannel to maintain backward compatibility. Previously, any curl-ca-bundle.crt file found in that search would have been ignored by Schannel. But, with CAINFO support, the file found by that search would have been used as the certificate store and could cause issues for any users that have curl-ca-bundle.crt in the search path. - Update url.c to not set the build time CURL_CA_BUNDLE if the selected SSL backend is Schannel. We allow setting CA location for schannel only when explicitly specified by the user via CURLOPT_CAINFO / --cacert. - Add new test cases 3000 and 3001. These test cases check that the first and last SAN, respectively, matches the connection hostname. New test certificates have been added for these cases. For 3000, the certificate prefix is Server-localhost-firstSAN and for 3001, the certificate prefix is Server-localhost-secondSAN. - Remove TODO 15.2 (Add support for custom server certificate validation), this commit addresses it. Closes https://github.com/curl/curl/pull/1325
* schannel: fix warningJay Satiro2018-04-171-1/+2
| | | | | | | | | | - Fix warning 'integer from pointer without a cast' on 3rd arg in CertOpenStore. The arg type HCRYPTPROV may be a pointer or integer type of the same size. Follow-up to e35b025. Caught by Marc's CI builds.
* docs: fix typosJakub Wilk2018-04-1754-75/+75
| | | | Closes https://github.com/curl/curl/pull/2503