summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* travis: install libssh2-dev only for --with-libssh2 buildMarcel Raad2019-04-111-1/+1
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install libssh-dev only for --with-libssh buildMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install krb5-user only for --with-gssapi buildMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install lcov only for the coverage jobMarcel Raad2019-04-111-1/+7
| | | | | | Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
* travis: install clang only when neededMarcel Raad2019-04-111-5/+91
| | | | | | | This reduces the GCC job runtimes a little and it's needed to selectively update clang builds to xenial. Closes https://github.com/curl/curl/pull/3721
* AppVeyor: enable testing for WinSSL buildMarcel Raad2019-04-111-3/+3
| | | | Closes https://github.com/curl/curl/pull/3725
* build: fix Codacy/CppCheck warningsMarcel Raad2019-04-1116-17/+24
| | | | | | | | | | - remove unused variables - declare conditionally used variables conditionally - suppress unused variable warnings in the CMake tests - remove dead variable stores - consistently use WIN32 macro to detect Windows Closes https://github.com/curl/curl/pull/3739
* polarssl_threadlock: remove conditionally unused codeMarcel Raad2019-04-112-29/+23
| | | | | | | | | | | | | Make functions no-ops if neither both USE_THREADS_POSIX and HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are defined. Previously, if only one of them was defined, there was either code compiled that did nothing useful or the wrong header included for the functions used. Also, move POLARSSL_MUTEX_T define to implementation file as it's not used externally. Closes https://github.com/curl/curl/pull/3739
* lib557: initialize variablesMarcel Raad2019-04-111-7/+7
| | | | | | These variables are only conditionally initialized. Closes https://github.com/curl/curl/pull/3739
* lib509: add missing include for strdupMarcel Raad2019-04-111-0/+2
| | | | Closes https://github.com/curl/curl/pull/3739
* README.md: fix no-consecutive-blank-lines Codacy warningMarcel Raad2019-04-111-1/+0
| | | | | | Consistently use one blank line between blocks. Closes https://github.com/curl/curl/pull/3739
* tests/server/util: fix Windows Unicode buildMarcel Raad2019-04-111-2/+2
| | | | | | | Always use the ANSI version of FormatMessage as we don't have the curl_multibyte gear available here. Closes https://github.com/curl/curl/pull/3758
* curl_easy_getinfo.3: fix minor formatting mistakeDaniel Stenberg2019-04-111-2/+2
|
* xattr: skip unittest on unsupported platformsDaniel Gustafsson2019-04-111-1/+3
| | | | | | | | | | | | | | | | | | | | | | | The stripcredentials unittest fails to compile on platforms without xattr support, for example the Solaris member in the buildfarm which fails with the following: CC unit1621-unit1621.o CC ../libtest/unit1621-first.o CCLD unit1621 Undefined first referenced symbol in file stripcredentials unit1621-unit1621.o goto problem 2 ld: fatal: symbol referencing errors. No output written to .libs/unit1621 collect2: error: ld returned 1 exit status gmake[2]: *** [Makefile:996: unit1621] Error 1 Fix by excluding the test on such platforms by using the reverse logic from where stripcredentials() is defined. Closes #3759 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* emailL Added reference to RFC8314 for implicit TLSSteve Holme2019-04-113-0/+3
|
* README: Schannel, stop calling it "winssl"Steve Holme2019-04-101-6/+6
| | | | Stick to "Schannel" everywhere - follow up to 180501cb.
* cmake: clear CMAKE_REQUIRED_LIBRARIES after each useJakub Zakrzewski2019-04-101-0/+3
| | | | | | | | | | This fixes GSSAPI builds with the libraries in a non-standard location. The testing for recv() were failing because it failed to link the Kerberos libraries, which are not needed for this or subsequent tests. fixes #3743 closes #3744
* cmake: avoid linking executable for some tests with cmake 3.6+Jakub Zakrzewski2019-04-101-35/+40
| | | | | | | | | | | | With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. This commit also avoids #3743 (GSSAPI build errors) on itself with cmake 3.6 or above. That issue was fixed separately for all versions. Ref: #3744
* cmake: minor cleanupJakub Zakrzewski2019-04-101-7/+1
| | | | | | | | | | | | - Remove nneeded include_regular_expression. It was setting what is already a default. - Remove duplicated include. - Don't check for pre-3.0.0 CMake version. We already require at least 3.0.0, so it's just clutter. Ref: #3744
* build-openssl.bat: Fixed support for OpenSSL v1.1.0+Steve Holme2019-04-081-117/+240
|
* build-openssl.bat: Perfer the use of if statements rather than goto (where ↵Steve Holme2019-04-081-141/+137
| | | | possible)
* build-openssl.bat: Perform the install for each build type directly after ↵Steve Holme2019-04-081-12/+28
| | | | the build
* build-openssl.bat: Split the install of static and shared build typesSteve Holme2019-04-081-41/+65
|
* build-openssl.bat: Split the building of static and shared build typesSteve Holme2019-04-081-6/+17
|
* build-openssl.bat: Move the installation into a separate functionSteve Holme2019-04-081-84/+66
|
* build-openssl.bat: Move the build step into a separate functionSteve Holme2019-04-081-12/+26
|
* build-openssl.bat: Move the OpenSSL configuration into a separate functionSteve Holme2019-04-081-7/+47
|
* build-openssl.bat: Fixed the BUILD_CONFIG variable not being initialisedSteve Holme2019-04-081-0/+1
| | | | | Should the parent environment set this variable then the build might not be performed as the user intended.
* socks: fix error messageDaniel Stenberg2019-04-081-1/+1
|
* config.d: clarify that initial : and = might need quoting [skip ci]Daniel Stenberg2019-04-081-6/+6
| | | | | Fixes #3738 Closes #3749
* RELEASE-NOTES: syncedDaniel Stenberg2019-04-082-11/+31
| | | | bumped to 7.65.0 for next release
* socks5: user name and passwords must be shorter than 256Daniel Stenberg2019-04-071-2/+14
| | | | | | | | bytes... since the protocol needs to store the length in a single byte field. Reported-by: XmiliaH on github Fixes #3737 Closes #3740
* test: urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski2019-04-071-0/+4
|
* urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski2019-04-071-3/+3
| | | | | fixes #3741 Closes #3742
* multi_runsingle(): fix use-after-freeEven Rouault2019-04-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #3745 Closes #3746 The following snippet ``` int main() { CURL* hCurlHandle = curl_easy_init(); curl_easy_setopt(hCurlHandle, CURLOPT_URL, "http://example.com"); curl_easy_setopt(hCurlHandle, CURLOPT_PROXY, "1"); curl_easy_perform(hCurlHandle); curl_easy_cleanup(hCurlHandle); return 0; } ``` triggers the following Valgrind warning ``` ==4125== Invalid read of size 8 ==4125== at 0x4E7D1EE: Curl_llist_remove (llist.c:97) ==4125== by 0x4E7EF5C: detach_connnection (multi.c:798) ==4125== by 0x4E80545: multi_runsingle (multi.c:1451) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Address 0x9b3d1d0 is 1,120 bytes inside a block of size 1,600 free'd ==4125== at 0x4C2ECF0: free (vg_replace_malloc.c:530) ==4125== by 0x4E62C36: conn_free (url.c:756) ==4125== by 0x4E62D34: Curl_disconnect (url.c:818) ==4125== by 0x4E48DF9: Curl_once_resolved (hostip.c:1097) ==4125== by 0x4E8052D: multi_runsingle (multi.c:1446) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Block was alloc'd at ==4125== at 0x4C2F988: calloc (vg_replace_malloc.c:711) ==4125== by 0x4E6438E: allocate_conn (url.c:1654) ==4125== by 0x4E685B4: create_conn (url.c:3496) ==4125== by 0x4E6968F: Curl_connect (url.c:4023) ==4125== by 0x4E802E7: multi_runsingle (multi.c:1368) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ``` This has been bisected to commit 2f44e94 Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14109 Credit to OSS Fuzz
* pipelining: removedDaniel Stenberg2019-04-0628-1394/+183
| | | | | | | As previously planned and documented in DEPRECATE.md, all pipelining code is removed. Closes #3651
* tests: make Impacket (SMB server) Python 3 compatiblecclauss2019-04-069-342/+352
| | | | | Closes #3731 Fixes #3289
* cmake: set SSL_BACKENDSSimon Warta2019-04-061-4/+13
| | | | | | | This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac Closes https://github.com/curl/curl/pull/3736
* cmake: don't run SORT on empty listSimon Warta2019-04-061-1/+3
| | | | | | | In case of an empty list, SORTing leads to the cmake error "list sub-command SORT requires list to be present." Closes https://github.com/curl/curl/pull/3736
* configure: fix default location for fish completionsEli Schwartz2019-04-051-1/+6
| | | | | | | | | | | | | | Fish defines a vendor completions directory for completions that are not installed as part of the fish project itself, and the vendor completions are preferred if they exist. This prevents trying to overwrite the builtin curl.fish completion (or creating file conflicts in distro packaging). Prefer the pkg-config defined location exported by fish, if it can be found, and fall back to the correct directory defined by most systems. Closes #3723 Reviewed-by: Daniel Gustafsson
* ftplistparser: fix LGTM alert "Empty block without comment"Marcel Raad2019-04-051-4/+1
| | | | | | Removing the block is consistent with line 954/957. Closes https://github.com/curl/curl/pull/3732
* transfer: fix LGTM alert "Comparison is always true"Marcel Raad2019-04-051-1/+1
| | | | | | | Just remove the redundant condition, which also makes it clear that k->buf is always 0-terminated if this break is not hit. Closes https://github.com/curl/curl/pull/3732
* smtp: fix compiler warningRikard Falkeborn2019-04-041-1/+1
| | | | | | | | | | | | | | | | | | | - Fix clang string-plus-int warning. Clang 8 warns about adding a string to an int does not append to the string. Indeed it doesn't, but that was not the intention either. Use array indexing as suggested to silence the warning. There should be no functional changes. (In other words clang warns about "foo"+2 but not &"foo"[2] so use the latter.) smtp.c:1221:29: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] eob = strdup(SMTP_EOB + 2); ~~~~~~~~~~~~~~~~^~~~ Closes https://github.com/curl/curl/pull/3729
* VS projects: use Unicode for VC10+Marcel Raad2019-04-0410-560/+560
| | | | | | | | | | | | | All Windows APIs have been natively UTF-16 since Windows 2000 and the non-Unicode variants are just wrappers around them. Only Windows 9x doesn't understand Unicode without the UnicoWS DLL. As later Visual Studio versions cannot target Windows 9x anyway, using the ANSI API doesn't really have any benefit there. This avoids issues like KNOWN_BUGS 6.5. Ref: https://github.com/curl/curl/issues/2120 Closes https://github.com/curl/curl/pull/3720
* RELEASE-NOTES: syncedDaniel Gustafsson2019-04-031-229/+25
| | | | | Bump the version in progress to 7.64.2, if we merge any "change" before the cut-off date we can update the version.
* documentation: Fix several typosTim Rühsen2019-04-036-6/+6
| | | | | | Closes #3724 Reviewed-by: Jakub Zakrzewski Reviewed-by: Daniel Gustafsson
* vauth/oauth2: Fix OAUTHBEARER token generationMert Yazıcıoğlu2019-04-0215-34/+75
| | | | | | | | | | | OAUTHBEARER tokens were incorrectly generated in a format similar to XOAUTH2 tokens. These changes make OAUTHBEARER tokens conform to the RFC7628. Fixes: #2487 Reported-by: Paolo Mossino Closes https://github.com/curl/curl/pull/3377
* tool_cb_wrt: fix bad-function-cast warningMarcel Raad2019-04-021-5/+3
| | | | | | | | | Commit f5bc578f4cdfdc6c708211dfc2962a0e9d79352d reintroduced the warning fixed in commit 2f5f31bb57d68b54e03bffcd9648aece1fe564f8. Extend fhnd's scope and reuse that variable instead of calling _get_osfhandle a second time to fix the warning again. Closes https://github.com/curl/curl/pull/3718
* VC15 project: remove MinimalRebuildMarcel Raad2019-04-011-28/+0
| | | | | | Already done in commit d5cfefd0ea8e331b884186bff484210fad36e345 for the library project, but I forgot the tool project template. Now also removed for that.
* cirrus: Customize the disabled tests per FreeBSD versionDan Fandrich2019-04-011-3/+7
| | | | | | Try to run as many test cases as possible on each OS version. 12.0 passes 13 more tests than the older versions, so we might as well run them.
View Lorry Controller Status