summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* FTP: allow PASV on IPv6 connections when a proxy is being usedLaurie Clark-Michalek2018-04-061-1/+1
| | | | | | | | | | | | In the situation of a client connecting to an FTP server using an IPv6 tunnel proxy, the connection info will indicate that the connection is IPv6. However, because the server behing the proxy is IPv4, it is permissable to attempt PSV mode. In the case of the FTP server being IPv4 only, EPSV will always fail, and with the current logic curl will be unable to connect to the server, as the IPv6 fwdproxy causes curl to think that EPSV is impossible. Closes #2432
* file: restore old behavior for file:////foo/bar URLsJon DeVree2018-04-062-35/+13
| | | | | | | | | | | | | | | | | | | | | curl 7.57.0 and up interpret this according to Appendix E.3.2 of RFC 8089 but then returns an error saying this is unimplemented. This is actually a regression in behavior on both Windows and Unix. Before curl 7.57.0 this URL was treated as a path of "//foo/bar" and then passed to the relevant OS API. This means that the behavior of this case is actually OS dependent. The Unix path resolution rules say that the OS must handle swallowing the extra "/" and so this path is the same as "/foo/bar" The Windows path resolution rules say that this is a UNC path and automatically handles the SMB access for the program. So curl on Windows was already doing Appendix E.3.2 without any special code in curl. Regression Closes #2438
* Revert "openssl: Don't add verify locations when verifypeer==0"Gaurav Malhotra2018-04-061-15/+16
| | | | | | | | | | | | | This reverts commit dc85437736e1fc90e689bb1f6c51c8f1aa9430eb. libcurl (with the OpenSSL backend) performs server certificate verification even if verifypeer == 0 and the verification result is available using CURLINFO_SSL_VERIFYRESULT. The commit that is being reverted caused the CURLINFO_SSL_VERIFYRESULT to not have useful information for the verifypeer == 0 use case (it would always have X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY). Closes #2451
* tls: fix mbedTLS 2.7.0 build + handle sha256 failuresWyatt O'Day2018-04-0610-10/+29
| | | | | | (mbedtls 2.70 compiled with MBEDTLS_DEPRECATED_REMOVED) Closes #2453
* cookie: case-insensitive hashing for the domainsLauri Kasanen2018-04-062-3/+18
| | | | closes #2458
* cookie: fix and optimize 2nd top level domain name extractionPatrick Monnerat2018-04-042-24/+21
| | | | | | | | | | | This fixes a segfault occurring when a name of the (invalid) form "domain..tld" is processed. test46 updated to cover this case. Follow-up to commit c990ead. Ref: https://github.com/curl/curl/pull/2440
* openssl: provide defines for argument typecasts to build warning-freeDaniel Stenberg2018-04-041-1/+9
| | | | ... as OpenSSL >= 1.1.0 and libressl >= 2.7.0 use different argument types.
* openssl: fix build with LibreSSL 2.7Bernard Spil2018-04-041-6/+9
| | | | | | | | | | - LibreSSL 2.7 implements (most of) OpenSSL 1.1 API Fixes #2319 Closes #2447 Closes #2448 Signed-off-by: Bernard Spil <brnrd@FreeBSD.org>
* cookie: store cookies per top-level-domain-specific hash tableLauri Kasanen2018-04-023-89/+159
| | | | | | This makes libcurl handle thousands of cookies much better and speedier. Closes #2440
* cookies: when reading from a file, only remove_expired onceLauri Kasanen2018-04-024-6/+12
| | | | | | This drops the cookie load time for 8k cookies from 178ms to 15ms. Closes #2441
* test1148: set a fixed locale for the testDaniel Stenberg2018-04-021-0/+4
| | | | | | | ...as otherwise it might use a different decimal sign. Bug: #2436 Reported-by: Oumph on github
* docs: fix CURLINFO_*_T examples use of CURL_FORMAT_CURL_OFF_TJay Satiro2018-03-316-6/+6
| | | | | | | | | - Put a percent sign before each CURL_FORMAT_CURL_OFF_T in printf. For example "%" CURL_FORMAT_CURL_OFF_T becomes %lld or similar. Bug: https://curl.haxx.se/mail/lib-2018-03/0140.html Reported-by: David L.
* cmake: Add advapi32 as explicit link library for win32Michał Janiszewski2018-03-271-0/+1
| | | | | ARM targets need advapi32 explicitly. Closes #2363
* TODO: connection cache sharing is now supporteDaniel Stenberg2018-03-271-2/+1
|
* travis: enable apt retry on failJay Satiro2018-03-261-0/+2
| | | | | | | | | This is a workaround for an unsolved travis issue that is causing CI instances to sporadically fail due to 'unable to connect' issues during apt stage. Ref: https://github.com/travis-ci/travis-ci/issues/8507 Ref: https://github.com/travis-ci/travis-ci/issues/9112#issuecomment-376305909
* runtests.pl: fix warning 'use of uninitialized value'Michael Kaufmann2018-03-261-1/+2
| | | | | | follow-up to a9a7b60 Closes #2428
* gitignore: ignore more generated filesDaniel Stenberg2018-03-242-5/+13
|
* threaded resolver: track resolver time and set suitable timeout valuesDaniel Stenberg2018-03-241-28/+39
| | | | | | | | | | In order to make curl_multi_timeout() return suitable "sleep" times even when there's no socket to wait for while the name is being resolved in a helper thread. It will increases the timeouts as time passes. Closes #2419
* openldap: fix for NULL return from ldap_get_attribute_ber()Howard Chu2018-03-231-1/+22
| | | | Closes #2399
* travis-ci: enable -Werror for CMake builds (#2418)Sergei Nikulov2018-03-221-1/+1
|
* cmake: avoid warn-as-error during config checks (#2411)Sergei Nikulov2018-03-221-11/+10
| | | | | | - Move the CURL_WERROR option processing after the configuration checks to avoid failures in case of warnings during the configuration checks. This is a partial fix for #2358
* timeval: remove compilation warning by casting (#2417)Sergei Nikulov2018-03-221-1/+1
| | | This is fixes #2358
* http2: read pending frames (including GOAWAY) in connection-checkDaniel Stenberg2018-03-221-13/+41
| | | | | | | | | | If a connection has received a GOAWAY frame while not being used, the function now reads frames off the connection before trying to reuse it to avoid reusing connections the server has told us not to use. Reported-by: Alex Baines Fixes #1967 Closes #2402
* CI: add lgtm.yml for tweaking lgtm.com analysisBas van Schaik2018-03-221-0/+10
| | | | Closes #2414
* CURLINFO_SSL_VERIFYRESULT.3: fix the example, add some textDaniel Stenberg2018-03-211-3/+5
| | | | | | Reported-by: Michal Trybus Fixes #2400
* TODO: expand ~/ in config filesDaniel Stenberg2018-03-211-0/+8
| | | | Closes #2317
* cookie.d: mention that "-" as filename means stdinDaniel Stenberg2018-03-201-1/+2
| | | | | Reported-by: Dongliang Mu Fixes #2410
* CURLINFO_COOKIELIST.3: made the example not leak memoryDaniel Stenberg2018-03-201-4/+5
| | | | Reported-by: Muz Dima
* vauth/cleartext: fix integer overflow checkDaniel Stenberg2018-03-203-20/+14
| | | | | | | | Make the integer overflow check not rely on the undefined behavior that a size_t wraps around on overflow. Detected by lgtm.com Closes #2408
* lib/curl_path.h: add #ifdef header guardDaniel Stenberg2018-03-201-1/+4
| | | | Detected by lgtm.com
* vauth/ntlm.h: fix the #ifdef header guardDaniel Stenberg2018-03-201-4/+4
| | | | Detected by lgtm.com
* examples/hiperfifo: checksrc complianceJay Satiro2018-03-201-9/+13
|
* parsedate: support UT timezoneNikos Tsipinakis2018-03-192-0/+2
| | | | | | | RFC822 section 5.2 mentions Universal Time, 'UT', to be synonymous with GMT. Closes #2401
* RELEASE-NOTES: syncedDaniel Stenberg2018-03-191-6/+28
|
* cmake: add support for brotliDon2018-03-193-0/+35
| | | | | | | | Currently CMake cannot detect Brotli support. This adds detection of the libraries and associated header files. It also adds this to the generated config. Closes #2392
* darwinssl: fix iOS buildChris Araman2018-03-181-0/+2
|
* ILE/RPG binding: Add CURLOPT_HAPROXYPROTOCOL/Fix CURLOPT_DNS_SHUFFLE_ADDRESSESPatrick Monnerat2018-03-181-1/+3
|
* resolve: add CURLOPT_DNS_SHUFFLE_ADDRESSESRick Deist2018-03-1714-3/+270
| | | | | | | | | | | This patch adds CURLOPT_DNS_SHUFFLE_ADDRESSES to explicitly request shuffling of IP addresses returned for a hostname when there is more than one. This is useful when the application knows that a round robin approach is appropriate and is willing to accept the consequences of potentially discarding some preference order returned by the system's implementation. Closes #1694
* add_handle/easy_perform: clear errorbuffer on start if setDaniel Stenberg2018-03-173-5/+13
| | | | | | | | | | To offer applications a more defined behavior, we clear the buffer as early as possible. Assisted-by: Jay Satiro Fixes #2190 Closes #2377
* CURLOPT_HAPROXYPROTOCOL: support the HAProxy PROXY protocolLawrence Matthews2018-03-1716-1/+261
| | | | | | Add --haproxy-protocol for the command line tool Closes #2162
* curl_version_info.3: fix ssl_version descriptionDaniel Stenberg2018-03-171-3/+4
| | | | | Reported-by: Vincas Razma Fixes #2364
* multi: improved pending transfers handling => improved performanceDaniel Stenberg2018-03-162-27/+21
| | | | | | | | | | | | | | | | When a transfer is requested to get done and it is put in the pending queue when limited by number of connections, total or per-host, libcurl would previously very aggressively retry *ALL* pending transfers to get them transferring. That was very time consuming. By reducing the aggressiveness in how pending are being retried, we waste MUCH less time on putting transfers back into pending again. Some test cases got a factor 30(!) speed improvement with this change. Reported-by: Cyril B Fixes #2369 Closes #2383
* pause: when changing pause state, update socket stateDaniel Stenberg2018-03-163-1/+12
| | | | | | | | | | | | Especially unpausing a transfer might have to move the socket back to the "currently used sockets" hash to get monitored. Otherwise it would never get any more data and get stuck. Easily triggered with pausing using the multi_socket API. Reported-by: Philip Prindeville Bug: https://curl.haxx.se/mail/lib-2018-03/0048.html Fixes #2393 Closes #2391
* examples/hiperfifo.c: improvedPhilip Prindeville2018-03-161-64/+76
| | | | | | | | | | | | | | | | * use member struct event’s instead of pointers to alloc’d struct events * simplify the cases for the mcode_or_die() function via macros; * make multi_timer_cb() actually do what the block comment says it should; * accept a “stop” command on the FIFO to shut down the service; * use cleaner notation for unused variables than the (void) hack; * allow following redirections (304’s);
* rate-limit: use three second window to better handle high speedsDaniel Stenberg2018-03-163-44/+62
| | | | | | | | | | | | | | | Due to very frequent updates of the rate limit "window", it could attempt to rate limit within the same milliseconds and that then made the calculations wrong, leading to it not behaving correctly on very fast transfers. This new logic updates the rate limit "window" to be no shorter than the last three seconds and only updating the timestamps for this when switching between the states TOOFAST/PERFORM. Reported-by: 刘佩东 Fixes #2386 Closes #2388
* cleanup: misc typos in strings and commentsluz.paz2018-03-1616-17/+17
| | | | | | Found via `codespell` Closes #2389
* RELEASE-NOTES: toward 7.60.0Daniel Stenberg2018-03-162-157/+18
|
* http2: fixes typoKobi Gurkan2018-03-151-1/+1
| | | | Closes #2387
* user-agent.d:: mention --proxy-header as wellDaniel Stenberg2018-03-151-2/+2
| | | | Bug: https://github.com/curl/curl/issues/2381
* transfer: make HTTP without headers count correct body sizeDaniel Stenberg2018-03-155-5/+60
| | | | | | | | This is what "HTTP/0.9" basically looks like. Reported on IRC Closes #2382