diff options
author | Daniel Stenberg <daniel@haxx.se> | 2020-07-02 16:42:55 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2020-07-03 10:10:30 +0200 |
commit | 1535363e728aa956bd64dd0325d8e38264a15468 (patch) | |
tree | 0495616846347a3aa6905332ef8f393143b31869 /tests | |
parent | 54f21be2e3a64b9e57130cf6d1eb4f17c44d7967 (diff) | |
download | curl-1535363e728aa956bd64dd0325d8e38264a15468.tar.gz |
ftpserver: don't verify SMTP MAIL FROM names
Rely on tests asking the names to get refused instead - test servers
should be as dumb as possible. Edited test 914, 955 and 959 accordingly.
Closes #5639
Diffstat (limited to 'tests')
-rw-r--r-- | tests/data/test914 | 3 | ||||
-rw-r--r-- | tests/data/test955 | 3 | ||||
-rw-r--r-- | tests/data/test959 | 3 | ||||
-rwxr-xr-x | tests/ftpserver.pl | 9 |
4 files changed, 11 insertions, 7 deletions
diff --git a/tests/data/test914 b/tests/data/test914 index d1532c806..0124b7671 100644 --- a/tests/data/test914 +++ b/tests/data/test914 @@ -8,6 +8,9 @@ SMTP # # Server-side <reply> +<servercmd> +REPLY MAIL 501 not fine enough +</servercmd> </reply> # diff --git a/tests/data/test955 b/tests/data/test955 index 57d618c7d..97ef29561 100644 --- a/tests/data/test955 +++ b/tests/data/test955 @@ -8,6 +8,9 @@ SMTP # # Server-side <reply> +<servercmd> +REPLY MAIL 501 not fine enough +</servercmd> </reply> # diff --git a/tests/data/test959 b/tests/data/test959 index a61c3d142..1b2d65842 100644 --- a/tests/data/test959 +++ b/tests/data/test959 @@ -8,6 +8,9 @@ SMTP # # Server-side <reply> +<servercmd> +REPLY MAIL 501 not fine enough +</servercmd> </reply> # diff --git a/tests/ftpserver.pl b/tests/ftpserver.pl index 92420ea4b..a0b36e5de 100755 --- a/tests/ftpserver.pl +++ b/tests/ftpserver.pl @@ -835,13 +835,8 @@ sub MAIL_smtp { } } - # Validate the from address (only <> and a valid email address inside - # <> are allowed, such as <user@example.com>) - if (($from eq "<>") || - (!$smtputf8 && $from =~ - /^<([a-zA-Z0-9._%+-]+)\@(([a-zA-Z0-9-]+)\.)+([a-zA-Z]{2,4})>$/) || - ($smtputf8 && $from =~ - /^<([a-zA-Z0-9\x{80}-\x{ff}._%+-]+)\@(([a-zA-Z0-9\x{80}-\x{ff}-]+)\.)+([a-zA-Z]{2,4})>$/)) { + # this server doesn't "validate" MAIL FROM addresses + if (length($from)) { my @found; my $valid = 1; |