summaryrefslogtreecommitdiff
path: root/tests/unit
diff options
context:
space:
mode:
authordfandrich <dan@coneharvesters.com>2015-11-12 23:45:56 +0100
committerDan Fandrich <dan@coneharvesters.com>2015-11-12 23:50:18 +0100
commiteb3703f05253fc0c7065377eb70c553325830cd3 (patch)
tree75d0e813f6796a72191db9c72ec61dce0084aac4 /tests/unit
parentd7e352402cf21da54933392372f7a9232d3d7f23 (diff)
downloadcurl-eb3703f05253fc0c7065377eb70c553325830cd3.tar.gz
unit1603: Demote hash mismatch failure to a warning
The hashes can vary between architectures (e.g. Sparc differs from x86_64). This is not a fatal problem but just reduces the coverage of these white-box tests, as the assumptions about into which hash bucket each key falls are no longer valid.
Diffstat (limited to 'tests/unit')
-rw-r--r--tests/unit/unit1603.c19
1 files changed, 9 insertions, 10 deletions
diff --git a/tests/unit/unit1603.c b/tests/unit/unit1603.c
index 27a08a73f..7d4a7105c 100644
--- a/tests/unit/unit1603.c
+++ b/tests/unit/unit1603.c
@@ -57,16 +57,15 @@ UNITTEST_START
char *nodep;
int rc;
- /* Ensure the key1 hashes are as expected in order to test both hash
- collisions and a full table */
- fail_unless(Curl_hash_str(key1, strlen(key1), slots) == 1,
- "hashes are not computed as expected");
- fail_unless(Curl_hash_str(key2, strlen(key2), slots) == 0,
- "hashes are not computed as expected");
- fail_unless(Curl_hash_str(key3, strlen(key3), slots) == 2,
- "hashes are not computed as expected");
- fail_unless(Curl_hash_str(key4, strlen(key4), slots) == 1,
- "hashes are not computed as expected");
+ /* Ensure the key hashes are as expected in order to test both hash
+ collisions and a full table. Unfortunately, the hashes can vary
+ between architectures. */
+ if(Curl_hash_str(key1, strlen(key1), slots) != 1 ||
+ Curl_hash_str(key2, strlen(key2), slots) != 0 ||
+ Curl_hash_str(key3, strlen(key3), slots) != 2 ||
+ Curl_hash_str(key4, strlen(key4), slots) != 1)
+ fprintf(stderr, "Warning: hashes are not computed as expected on this "
+ "architecture; test coverage will be less comprehensive\n");
nodep = Curl_hash_add(&hash_static, &key1, strlen(key1), &key1);
fail_unless(nodep, "insertion into hash failed");