summaryrefslogtreecommitdiff
path: root/tests/data/test134
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2021-02-12 10:27:42 +0100
committerDaniel Stenberg <daniel@haxx.se>2021-02-13 22:36:15 +0100
commit46620b97431e19c53ce82e55055c85830f088cf4 (patch)
tree672f1b6b90b0dc5dc2693df105ab010def1cd35a /tests/data/test134
parente992770e8d16e4be2a3da8aa2cef5cfc12e22372 (diff)
downloadcurl-46620b97431e19c53ce82e55055c85830f088cf4.tar.gz
http: use credentials from transfer, not connection
HTTP auth "accidentally" worked before this cleanup since the code would always overwrite the connection credentials with the credentials from the most recent transfer and since HTTP auth is typically done first thing, this has not been an issue. It was still wrong and subject to possible race conditions or future breakage if the sequence of functions would change. The data.set.str[] strings MUST remain unmodified exactly as set by the user, and the credentials to use internally are instead set/updated in state.aptr.* Added test 675 to verify different credentials used in two requests done over a reused HTTP connection, which previously behaved wrongly. Fixes #6542 Closes #6545
Diffstat (limited to 'tests/data/test134')
-rw-r--r--tests/data/test1348
1 files changed, 5 insertions, 3 deletions
diff --git a/tests/data/test134 b/tests/data/test134
index e314b662e..4ca63accd 100644
--- a/tests/data/test134
+++ b/tests/data/test134
@@ -33,10 +33,12 @@ dr-xr-xr-x 5 0 1 512 Oct 1 1997 usr
<server>
ftp
</server>
- <name>
+<name>
FTP (optional .netrc; programmatic user/passwd) dir list PASV
- </name>
- <command>
+</name>
+
+# -u overrides netrc which overrides the URL
+<command>
--netrc-optional --netrc-file log/netrc134 -u romulus:rhemus ftp://mary:mark@%HOSTIP:%FTPPORT/
</command>
<file name="log/netrc134" >