diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2020-10-02 10:58:52 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2020-10-02 16:35:53 +0200 |
| commit | 26a7d51c21bce00e332bbd10443594edb879a871 (patch) | |
| tree | d10c7901ebd1a7133f66bbd4e5a49e1120b1b6af /lib | |
| parent | ddecd28268b78ae3361bc010c719446d55a8f894 (diff) | |
| download | curl-26a7d51c21bce00e332bbd10443594edb879a871.tar.gz | |
checksrc: warn on space after exclamation mark
Closes #6034
Diffstat (limited to 'lib')
| -rwxr-xr-x | lib/checksrc.pl | 7 | ||||
| -rw-r--r-- | lib/inet_pton.c | 4 | ||||
| -rw-r--r-- | lib/mprintf.c | 2 |
3 files changed, 10 insertions, 3 deletions
diff --git a/lib/checksrc.pl b/lib/checksrc.pl index c47aaf0f5..f9d076a2f 100755 --- a/lib/checksrc.pl +++ b/lib/checksrc.pl @@ -84,6 +84,7 @@ my %warnings = ( 'TYPEDEFSTRUCT' => 'typedefed struct', 'DOBRACE' => 'A single space between do and open brace', 'BRACEWHILE' => 'A single space between open brace and while', + 'EXCLAMATIONSPACE' => 'Whitespace after exclamation mark in expression', ); sub readskiplist { @@ -725,6 +726,12 @@ sub scanfile { "typedef'ed struct"); } + if($nostr =~ /(.*)! +(\w|\()/) { + checkwarn("EXCLAMATIONSPACE", + $line, length($1)+1, $file, $ol, + "space after exclamation mark"); + } + # check for more than one consecutive space before open brace or # question mark. Skip lines containing strings since they make it hard # due to artificially getting multiple spaces diff --git a/lib/inet_pton.c b/lib/inet_pton.c index 9c87a0562..4923cae24 100644 --- a/lib/inet_pton.c +++ b/lib/inet_pton.c @@ -1,6 +1,6 @@ /* This is from the BIND 4.9.4 release, modified to compile by itself */ -/* Copyright (c) 1996 - 2019 by Internet Software Consortium. +/* Copyright (c) 1996 - 2020 by Internet Software Consortium. * * Permission to use, copy, modify, and distribute this software for any * purpose with or without fee is hereby granted, provided that the above @@ -112,7 +112,7 @@ inet_pton4(const char *src, unsigned char *dst) if(val > 255) return (0); *tp = (unsigned char)val; - if(! saw_digit) { + if(!saw_digit) { if(++octets > 4) return (0); saw_digit = 1; diff --git a/lib/mprintf.c b/lib/mprintf.c index 8f0011e91..6aceadc96 100644 --- a/lib/mprintf.c +++ b/lib/mprintf.c @@ -878,7 +878,7 @@ static int dprintf_formatf( OUTCHAR(' '); for(point = strnil; *point != '\0'; ++point) OUTCHAR(*point); - if(! (p->flags & FLAGS_LEFT)) + if(!(p->flags & FLAGS_LEFT)) while(width-- > 0) OUTCHAR(' '); } |