diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2020-07-27 14:28:37 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2020-07-28 23:51:17 +0200 |
| commit | 2f72ad44fca689d3e0f4574e59e551443c406717 (patch) | |
| tree | e05ce1540d43ff6f7de83d0c98f74a1b4d683067 /lib | |
| parent | 5ae339971a9590bfc227d104122faf119ef18f2a (diff) | |
| download | curl-2f72ad44fca689d3e0f4574e59e551443c406717.tar.gz | |
checksrc: ban gmtime/localtime
They're not thread-safe so they should not be used in libcurl code.
Explictly enabled when deemed necessary and in examples and tests
Reviewed-by: Nicolas Sterchele
Closes #5732
Diffstat (limited to 'lib')
| -rwxr-xr-x | lib/checksrc.pl | 3 | ||||
| -rw-r--r-- | lib/parsedate.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/lib/checksrc.pl b/lib/checksrc.pl index 97b8f9e1d..498da94bb 100755 --- a/lib/checksrc.pl +++ b/lib/checksrc.pl @@ -592,7 +592,8 @@ sub scanfile { # scan for use of banned functions if($l =~ /^(.*\W) - (gets| + (gmtime|localtime| + gets| strtok| v?sprintf| (str|_mbs|_tcs|_wcs)n?cat| diff --git a/lib/parsedate.c b/lib/parsedate.c index 585d7ea40..4c7a40c4c 100644 --- a/lib/parsedate.c +++ b/lib/parsedate.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2019, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -624,6 +624,7 @@ CURLcode Curl_gmtime(time_t intime, struct tm *store) /* thread-safe version */ tm = (struct tm *)gmtime_r(&intime, store); #else + /* !checksrc! disable BANNEDFUNC 1 */ tm = gmtime(&intime); if(tm) *store = *tm; /* copy the pointed struct to the local copy */ |