lib: when saving files, use advisory locksbagder/lock-output-files

... instead of saving into a temp name and rename. This makes them work
properly when the output is a character device. Applies to cookies,
alt-svc and hsts files.

Makes Curl_rename superfluous and therefore removed.

Reported-by: rofl0r on github
Assisted-by: Paul Vixie
Fixes #6882
Closes #6884

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/url.c b/lib/url.c
index 74ebb6f91..fd0869e81 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -416,7 +416,7 @@ CURLcode Curl_close(struct Curl_easy **datap)
   Curl_dyn_free(&data->state.headerb);
   Curl_safefree(data->state.ulbuf);
   Curl_flush_cookies(data, TRUE);
-  Curl_altsvc_save(data, data->asi, data->set.str[STRING_ALTSVC]);
+  Curl_altsvc_save(data->asi, data->set.str[STRING_ALTSVC]);
   Curl_altsvc_cleanup(&data->asi);
   Curl_hsts_save(data, data->hsts, data->set.str[STRING_HSTS]);
   Curl_hsts_cleanup(&data->hsts);