summaryrefslogtreecommitdiff
path: root/lib/telnet.c
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2016-04-29 15:46:40 +0200
committerDaniel Stenberg <daniel@haxx.se>2016-04-29 22:32:49 +0200
commit4f45240bc84a9aa648c8f7243be7b79e9f9323a5 (patch)
tree975f7e1e617df32c42db93cf0cbacfd10ff640c4 /lib/telnet.c
parent63b5378a617437859da1e7ab5553d36eb83bdd44 (diff)
downloadcurl-4f45240bc84a9aa648c8f7243be7b79e9f9323a5.tar.gz
lib: include curl_printf.h as one of the last headers
curl_printf.h defines printf to curl_mprintf, etc. This can cause problems with external headers which may use __attribute__((format(printf, ...))) markers etc. To avoid that they cause problems with system includes, we include curl_printf.h after any system headers. That makes the three last headers to always be, and we keep them in this order: curl_printf.h curl_memory.h memdebug.h None of them include system headers, they all do funny #defines. Reported-by: David Benjamin Fixes #743
Diffstat (limited to 'lib/telnet.c')
-rw-r--r--lib/telnet.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/telnet.c b/lib/telnet.c
index 068470b93..6b73bc5bd 100644
--- a/lib/telnet.c
+++ b/lib/telnet.c
@@ -51,7 +51,6 @@
#include "telnet.h"
#include "connect.h"
#include "progress.h"
-#include "curl_printf.h"
#define TELOPTS
#define TELCMDS
@@ -62,7 +61,8 @@
#include "rawstr.h"
#include "warnless.h"
-/* The last #include files should be: */
+/* The last 3 #include files should be in this order */
+#include "curl_printf.h"
#include "curl_memory.h"
#include "memdebug.h"