diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2020-08-24 11:07:59 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2020-08-24 11:07:59 +0200 |
| commit | 863095f2bcf25d2b0243ad5c67735c04deff4241 (patch) | |
| tree | 79a510285513d9eb5fa0ad376b31da5bbe86c6f4 /lib/progress.h | |
| parent | 98c94596f5928840177b6bd3c7b0f0dd03a431af (diff) | |
| download | curl-bagder/timeout-overflow.tar.gz | |
Curl_pgrsTime - return new time to avoid timeout integer overflowbagder/timeout-overflow
Setting a timeout to INT_MAX could cause an immediate error to get
returned as timeout because of an overflow when different values of
'now' were used.
This is primarily fixed by having Curl_pgrsTime() return the "now" when
TIMER_STARTSINGLE is set so that the parent function will continue using
that time.
Reported-by: Ionuț-Francisc Oancea
Fixes #5583
Diffstat (limited to 'lib/progress.h')
| -rw-r--r-- | lib/progress.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/progress.h b/lib/progress.h index 3515ac6d5..c19d966d3 100644 --- a/lib/progress.h +++ b/lib/progress.h @@ -7,7 +7,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2018, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -49,7 +49,7 @@ void Curl_pgrsSetUploadCounter(struct Curl_easy *data, curl_off_t size); void Curl_ratelimit(struct Curl_easy *data, struct curltime now); int Curl_pgrsUpdate(struct connectdata *); void Curl_pgrsResetTransferSizes(struct Curl_easy *data); -void Curl_pgrsTime(struct Curl_easy *data, timerid timer); +struct curltime Curl_pgrsTime(struct Curl_easy *data, timerid timer); timediff_t Curl_pgrsLimitWaitTime(curl_off_t cursize, curl_off_t startsize, curl_off_t limit, |