diff options
author | Daniel Gustafsson <daniel@yesql.se> | 2021-09-29 10:00:52 +0200 |
---|---|---|
committer | Daniel Gustafsson <daniel@yesql.se> | 2021-09-29 10:00:52 +0200 |
commit | 12246eddc5d844efec16141d259092fd69f89bc4 (patch) | |
tree | 2a8c2b960cbf828f7c77eff10179acb01ac1d3af /lib/multihandle.h | |
parent | 2b7e56aab353188e7919cd941150abb77ffc4d97 (diff) | |
download | curl-12246eddc5d844efec16141d259092fd69f89bc4.tar.gz |
lib: avoid fallthrough cases in switch statements
Commit b5a434f7f0ee4d64857f8592eced5b9007d83620 inhibits the warning
on implicit fallthrough cases, since the current coding of indicating
fallthrough with comments is falling out of fashion with new compilers.
This attempts to make the issue smaller by rewriting fallthroughs to no
longer fallthrough, via either breaking the cases or turning switch
statements into if statements.
lib/content_encoding.c: the fallthrough codepath is simply copied
into the case as it's a single line.
lib/http_ntlm.c: the fallthrough case skips a state in the state-
machine and fast-forwards to NTLMSTATE_LAST. Do this before the
switch statement instead to set up the states that we actually
want.
lib/http_proxy.c: the fallthrough is just falling into exiting the
switch statement which can be done easily enough in the case.
lib/mime.c: switch statement rewritten as if statement.
lib/pop3.c: the fallthrough case skips to the next state in the
statemachine, do this explicitly instead.
lib/urlapi.c: switch statement rewritten as if statement.
lib/vssh/wolfssh.c: the fallthrough cases fast-forwards the state
machine, do this by running another iteration of the switch
statement instead.
lib/vtls/gtls.c: switch statement rewritten as if statement.
lib/vtls/nss.c: the fallthrough codepath is simply copied into the
case as it's a single line. Also twiddle a comment to not be
inside a non-brace if statement.
Closes: #7322
See-also: #7295
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Diffstat (limited to 'lib/multihandle.h')
0 files changed, 0 insertions, 0 deletions