diff options
author | Daniel Stenberg <daniel@haxx.se> | 2020-06-24 01:13:04 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2020-06-24 16:04:54 +0200 |
commit | d2baa502fc7ea3f003db2d13b110f3f1da8d8073 (patch) | |
tree | 77ae009ffc8ef051e85ba377d44f0e94ed1cbdae /lib/if2ip.c | |
parent | 550bcdd442dcd6d32e9ef018dbcb72b06365a03c (diff) | |
download | curl-d2baa502fc7ea3f003db2d13b110f3f1da8d8073.tar.gz |
Curl_inet_ntop: always check the return code
Reported-by: Siva Sivaraman
Fixes #5412
Closes #5597
Diffstat (limited to 'lib/if2ip.c')
-rw-r--r-- | lib/if2ip.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/lib/if2ip.c b/lib/if2ip.c index b283f67f8..39388692e 100644 --- a/lib/if2ip.c +++ b/lib/if2ip.c @@ -118,7 +118,7 @@ if2ip_result_t Curl_if2ip(int af, unsigned int remote_scope, if(iface->ifa_addr->sa_family == af) { if(strcasecompare(iface->ifa_name, interf)) { void *addr; - char *ip; + const char *ip; char scope[12] = ""; char ipstr[64]; #ifdef ENABLE_IPV6 @@ -153,15 +153,15 @@ if2ip_result_t Curl_if2ip(int af, unsigned int remote_scope, } if(scopeid) - msnprintf(scope, sizeof(scope), "%%%u", scopeid); + msnprintf(scope, sizeof(scope), "%%%u", scopeid); #endif } else #endif addr = - &((struct sockaddr_in *)(void *)iface->ifa_addr)->sin_addr; + &((struct sockaddr_in *)(void *)iface->ifa_addr)->sin_addr; res = IF2IP_FOUND; - ip = (char *) Curl_inet_ntop(af, addr, ipstr, sizeof(ipstr)); + ip = Curl_inet_ntop(af, addr, ipstr, sizeof(ipstr)); msnprintf(buf, buf_size, "%s%s", ip, scope); break; } @@ -190,6 +190,7 @@ if2ip_result_t Curl_if2ip(int af, unsigned int remote_scope, struct sockaddr_in *s; curl_socket_t dummy; size_t len; + const char *r; (void)remote_scope; (void)local_scope_id; @@ -219,9 +220,11 @@ if2ip_result_t Curl_if2ip(int af, unsigned int remote_scope, s = (struct sockaddr_in *)(void *)&req.ifr_addr; memcpy(&in, &s->sin_addr, sizeof(in)); - Curl_inet_ntop(s->sin_family, &in, buf, buf_size); + r = Curl_inet_ntop(s->sin_family, &in, buf, buf_size); sclose(dummy); + if(!r) + return IF2IP_NOT_FOUND; return IF2IP_FOUND; } |