diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2016-04-29 15:46:40 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2016-04-29 22:32:49 +0200 |
| commit | 4f45240bc84a9aa648c8f7243be7b79e9f9323a5 (patch) | |
| tree | 975f7e1e617df32c42db93cf0cbacfd10ff640c4 /lib/http_proxy.c | |
| parent | 63b5378a617437859da1e7ab5553d36eb83bdd44 (diff) | |
| download | curl-4f45240bc84a9aa648c8f7243be7b79e9f9323a5.tar.gz | |
lib: include curl_printf.h as one of the last headers
curl_printf.h defines printf to curl_mprintf, etc. This can cause
problems with external headers which may use
__attribute__((format(printf, ...))) markers etc.
To avoid that they cause problems with system includes, we include
curl_printf.h after any system headers. That makes the three last
headers to always be, and we keep them in this order:
curl_printf.h
curl_memory.h
memdebug.h
None of them include system headers, they all do funny #defines.
Reported-by: David Benjamin
Fixes #743
Diffstat (limited to 'lib/http_proxy.c')
| -rw-r--r-- | lib/http_proxy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/http_proxy.c b/lib/http_proxy.c index 676f0cb5d..814c572f6 100644 --- a/lib/http_proxy.c +++ b/lib/http_proxy.c @@ -35,11 +35,11 @@ #include "progress.h" #include "non-ascii.h" #include "connect.h" -#include "curl_printf.h" #include "curlx.h" +/* The last 3 #include files should be in this order */ +#include "curl_printf.h" #include "curl_memory.h" -/* The last #include file should be: */ #include "memdebug.h" CURLcode Curl_proxy_connect(struct connectdata *conn) |