diff options
author | Daniel Stenberg <daniel@haxx.se> | 2017-04-20 15:10:04 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2017-04-22 11:25:27 +0200 |
commit | cbae73e1dd95946597ea74ccb580c30f78e3fa73 (patch) | |
tree | 56697b9325403031bb2fcfc6a723719b9819b0be /lib/hash.c | |
parent | cbb59ed9ce9555e0dc0b485247fe86f0e45006b3 (diff) | |
download | curl-cbae73e1dd95946597ea74ccb580c30f78e3fa73.tar.gz |
llist: no longer uses malloc
The 'list element' struct now has to be within the data that is being
added to the list. Removes 16.6% (tiny) mallocs from a simple HTTP
transfer. (96 => 80)
Also removed return codes since the llist functions can't fail now.
Test 1300 updated accordingly.
Closes #1435
Diffstat (limited to 'lib/hash.c')
-rw-r--r-- | lib/hash.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/lib/hash.c b/lib/hash.c index b7305a572..6afeaa12c 100644 --- a/lib/hash.c +++ b/lib/hash.c @@ -124,17 +124,9 @@ Curl_hash_add(struct curl_hash *h, void *key, size_t key_len, void *p) he = mk_hash_element(key, key_len, p); if(he) { - if(Curl_llist_insert_next(l, l->tail, he)) { - ++h->size; - return p; /* return the new entry */ - } - /* - * Couldn't insert it, destroy the 'he' element and the key again. We - * don't call hash_element_dtor() since that would also call the - * "destructor" for the actual data 'p'. When we fail, we shall not touch - * that data. - */ - free(he); + Curl_llist_insert_next(l, l->tail, he, &he->list); + ++h->size; + return p; /* return the new entry */ } return NULL; /* failure */ |