diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2014-10-23 22:56:35 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2014-10-24 08:23:19 +0200 |
| commit | 0eb3d15ccb419bfda41ee31bdbf73c36facc7388 (patch) | |
| tree | 0c4abf7bf4bac279cbcfd708e1cdd1bcdf29bb77 /lib/gopher.c | |
| parent | 1752e9c088d9bb7a3156dba9c66f7f64dd87afa9 (diff) | |
| download | curl-0eb3d15ccb419bfda41ee31bdbf73c36facc7388.tar.gz | |
code cleanup: we prefer 'CURLcode result'
... for the local variable name in functions holding the return
code. Using the same name universally makes code easier to read and
follow.
Also, unify code for checking for CURLcode errors with:
if(result) or if(!result)
instead of
if(result == CURLE_OK), if(CURLE_OK == result) or if(result != CURLE_OK)
Diffstat (limited to 'lib/gopher.c')
| -rw-r--r-- | lib/gopher.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/gopher.c b/lib/gopher.c index b1dd65fff..f3fd06533 100644 --- a/lib/gopher.c +++ b/lib/gopher.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2012, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2014, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -121,7 +121,7 @@ static CURLcode gopher_do(struct connectdata *conn, bool *done) for(;;) { result = Curl_write(conn, sockfd, sel, k, &amount); - if(CURLE_OK == result) { /* Which may not have written it all! */ + if(!result) { /* Which may not have written it all! */ result = Curl_client_write(conn, CLIENTWRITE_HEADER, sel, amount); if(result) { Curl_safefree(sel_org); @@ -154,7 +154,7 @@ static CURLcode gopher_do(struct connectdata *conn, bool *done) /* We can use Curl_sendf to send the terminal \r\n relatively safely and save allocing another string/doing another _write loop. */ result = Curl_sendf(sockfd, conn, "\r\n"); - if(result != CURLE_OK) { + if(result) { failf(data, "Failed sending Gopher request"); return result; } |