summaryrefslogtreecommitdiff
path: root/lib/doh.c
diff options
context:
space:
mode:
authorJay Satiro <raysatiro@yahoo.com>2021-03-04 00:55:53 -0500
committerJay Satiro <raysatiro@yahoo.com>2021-03-17 18:12:45 -0400
commit8a4ef73c8fc035becb4c1d99ca8b1892d100532a (patch)
tree19f3eca86c640f940b9b0e12eeb001f9944bf3ac /lib/doh.c
parent6d176bee59558a1ec9dffc6633aa05e713af73f0 (diff)
downloadcurl-8a4ef73c8fc035becb4c1d99ca8b1892d100532a.tar.gz
docs: Explain DOH transfers inherit some SSL settings
- Document in DOH that some SSL settings are inherited but DOH hostname and peer verification are not and are controlled separately. - Document that CURLOPT_SSL_CTX_FUNCTION is inherited by DOH handles but we're considering changing behavior to no longer inherit it. Request feedback. Closes https://github.com/curl/curl/pull/6688
Diffstat (limited to 'lib/doh.c')
-rw-r--r--lib/doh.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/doh.c b/lib/doh.c
index 15cdc35a4..52388cba3 100644
--- a/lib/doh.c
+++ b/lib/doh.c
@@ -359,7 +359,11 @@ static CURLcode dohprobe(struct Curl_easy *data,
doh->set.dohfor = data; /* identify for which transfer this is done */
p->easy = doh;
- /* add this transfer to the multi handle */
+ /* DOH private_data must be null because the user must have a way to
+ distinguish their transfer's handle from DOH handles in user
+ callbacks (ie SSL CTX callback). */
+ DEBUGASSERT(!data->set.private_data);
+
if(curl_multi_add_handle(multi, doh))
goto error;
}