diff options
| author | David Woodhouse <David.Woodhouse@intel.com> | 2015-07-16 14:17:33 -0400 |
|---|---|---|
| committer | Jay Satiro <raysatiro@yahoo.com> | 2015-07-16 14:22:45 -0400 |
| commit | 60b19630b032d99270282e021216605718acc14d (patch) | |
| tree | f26ed6457467669696532cee96d8f9c7d8b3e731 /lib/curl_ntlm_wb.c | |
| parent | de74e856e63b0c6fd1e36d96d6310672abf12c29 (diff) | |
| download | curl-60b19630b032d99270282e021216605718acc14d.tar.gz | |
ntlm_wb: Fix theoretical memory leak
Static analysis indicated that my commit 9008f3d564 ("ntlm_wb: Fix
hard-coded limit on NTLM auth packet size") introduced a potential
memory leak on an error path, because we forget to free the buffer
before returning an error.
Fix this.
Although actually, it never happens in practice because we never *get*
here with state == NTLMSTATE_TYPE1. The state is always zero. That
might want cleaning up in a separate patch.
Reported-by: Terri Oda
Diffstat (limited to 'lib/curl_ntlm_wb.c')
| -rw-r--r-- | lib/curl_ntlm_wb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/curl_ntlm_wb.c b/lib/curl_ntlm_wb.c index d63fb277b..b2a5fb343 100644 --- a/lib/curl_ntlm_wb.c +++ b/lib/curl_ntlm_wb.c @@ -306,7 +306,7 @@ static CURLcode ntlm_wb_response(struct connectdata *conn, if(state == NTLMSTATE_TYPE1 && len_out == 3 && buf[0] == 'P' && buf[1] == 'W') - return CURLE_REMOTE_ACCESS_DENIED; + goto done; /* invalid response */ if(len_out < 4) goto done; |