diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2016-10-04 23:26:13 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2016-10-31 08:46:35 +0100 |
| commit | c5be3d7267c725dbd093ff3a883e07ee8cf2a1d5 (patch) | |
| tree | 796903dc1b07470871b957ffd4a20d22038bc2a5 /lib/cookie.h | |
| parent | fba28277ca17cb102209772e8bb214854a05cc6a (diff) | |
| download | curl-c5be3d7267c725dbd093ff3a883e07ee8cf2a1d5.tar.gz | |
cookies: getlist() now holds deep copies of all cookies
Previously it only held references to them, which was reckless as the
thread lock was released so the cookies could get modified by other
handles that share the same cookie jar over the share interface.
CVE-2016-8623
Bug: https://curl.haxx.se/docs/adv_20161102I.html
Reported-by: Cure53
Diffstat (limited to 'lib/cookie.h')
| -rw-r--r-- | lib/cookie.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/cookie.h b/lib/cookie.h index cd7c54a28..a9a45785c 100644 --- a/lib/cookie.h +++ b/lib/cookie.h @@ -7,7 +7,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2011, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2016, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -82,7 +82,7 @@ struct Cookie *Curl_cookie_add(struct Curl_easy *data, struct Cookie *Curl_cookie_getlist(struct CookieInfo *, const char *, const char *, bool); -void Curl_cookie_freelist(struct Cookie *cookies, bool cookiestoo); +void Curl_cookie_freelist(struct Cookie *cookies); void Curl_cookie_clearall(struct CookieInfo *cookies); void Curl_cookie_clearsess(struct CookieInfo *cookies); |