summaryrefslogtreecommitdiff
path: root/lib/checksrc.pl
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2020-10-15 15:30:55 +0200
committerDaniel Stenberg <daniel@haxx.se>2020-10-15 23:32:26 +0200
commit475c1aba68030bc21b8d0ed76a7028eb2e797f64 (patch)
tree44040f70841735b6394311bbef1b3840d47923dd /lib/checksrc.pl
parentb7ea3d2c22fe76fd85d1c5c6672829960d1d6e36 (diff)
downloadcurl-475c1aba68030bc21b8d0ed76a7028eb2e797f64.tar.gz
checksrc: warn on empty line before open brace
... and fix a few occurances Closes #6088
Diffstat (limited to 'lib/checksrc.pl')
-rwxr-xr-xlib/checksrc.pl6
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/checksrc.pl b/lib/checksrc.pl
index 78b9cef5b..126f3c77e 100755
--- a/lib/checksrc.pl
+++ b/lib/checksrc.pl
@@ -85,6 +85,7 @@ my %warnings = (
'DOBRACE' => 'A single space between do and open brace',
'BRACEWHILE' => 'A single space between open brace and while',
'EXCLAMATIONSPACE' => 'Whitespace after exclamation mark in expression',
+ 'EMPTYLINEBRACE' => 'Empty line before the open brace',
);
sub readskiplist {
@@ -594,6 +595,11 @@ sub scanfile {
checkwarn("PARENBRACE",
$line, length($1)+1, $file, $l, "missing space after close paren");
}
+ # check for "^{" with an empty line before it
+ if(($l =~ /^\{/) && ($prevl =~ /^[ \t]*\z/)) {
+ checkwarn("EMPTYLINEBRACE",
+ $line, 0, $file, $l, "empty line before open brace");
+ }
# check for space before the semicolon last in a line
if($l =~ /^(.*[^ ].*) ;$/) {