diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2021-01-08 17:58:15 +0100 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2021-01-17 23:56:09 +0100 |
| commit | 215db086e09665ee7af9b646ad6c4d6e281001ac (patch) | |
| tree | 50c74f8456df87e86de6d72e90190a3563083a1a /lib/asyn-ares.c | |
| parent | 0d26ab9ed3ac29da2a383d313e93df3e9f5295a2 (diff) | |
| download | curl-215db086e09665ee7af9b646ad6c4d6e281001ac.tar.gz | |
lib: pass in 'struct Curl_easy *' to most functions
... in most cases instead of 'struct connectdata *' but in some cases in
addition to.
- We mostly operate on transfers and not connections.
- We need the transfer handle to log, store data and more. Everything in
libcurl is driven by a transfer (the CURL * in the public API).
- This work clarifies and separates the transfers from the connections
better.
- We should avoid "conn->data". Since individual connections can be used
by many transfers when multiplexing, making sure that conn->data
points to the current and correct transfer at all times is difficult
and has been notoriously error-prone over the years. The goal is to
ultimately remove the conn->data pointer for this reason.
Closes #6425
Diffstat (limited to 'lib/asyn-ares.c')
| -rw-r--r-- | lib/asyn-ares.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/asyn-ares.c b/lib/asyn-ares.c index 606162daa..c8e8e14ea 100644 --- a/lib/asyn-ares.c +++ b/lib/asyn-ares.c @@ -671,7 +671,7 @@ struct Curl_addrinfo *Curl_resolver_getaddrinfo(struct connectdata *conn, res->last_status = ARES_ENOTFOUND; #ifdef ENABLE_IPV6 if(family == PF_UNSPEC) { - if(Curl_ipv6works(conn)) { + if(Curl_ipv6works(data)) { res->num_pending = 2; /* areschannel is already setup in the Curl_open() function */ |