diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2015-10-21 13:46:03 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2015-10-21 23:18:04 +0200 |
| commit | 9744ef2289b606515b91f39c827a65f55c6ca909 (patch) | |
| tree | ad5db35f81170e169e7cea79af1bcf90e3afecfe | |
| parent | c238d4da1b1a8234e4a680d37c9641266df55adf (diff) | |
| download | curl-9744ef2289b606515b91f39c827a65f55c6ca909.tar.gz | |
checksrc: add crude // detection
| -rwxr-xr-x | lib/checksrc.pl | 5 | ||||
| -rw-r--r-- | lib/checksrc.whitelist | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/lib/checksrc.pl b/lib/checksrc.pl index 8fad2cfcb..ddd0b3623 100755 --- a/lib/checksrc.pl +++ b/lib/checksrc.pl @@ -143,6 +143,11 @@ sub scanfile { checkwarn($line, length($1), $file, $l, "Trailing whitespace"); } + # crude attempt to detect // comments without too many false + # positives + if($l =~ /^([^"\*]*)[^:"]\/\//) { + checkwarn($line, length($1), $file, $l, "\/\/ comment"); + } # check spaces after for/if/while if($l =~ /^(.*)(for|if|while) \(/) { if($1 =~ / *\#/) { diff --git a/lib/checksrc.whitelist b/lib/checksrc.whitelist index e261b9da1..d20909bdc 100644 --- a/lib/checksrc.whitelist +++ b/lib/checksrc.whitelist @@ -8,3 +8,4 @@ return fopen(file, "r"); /* VMS */ return fopen(file, "r", "rfm=stmlf", "ctx=stm"); curl_memlog("FILE %s:%d fopen(\"%s\",\"%s\") = %p\n", + a URL as file://localhost//foo must be valid as well, to refer to |