summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2019-09-19 09:18:26 +0200
committerDaniel Stenberg <daniel@haxx.se>2019-09-20 08:07:03 +0200
commit49f3117a238b6eac0e22a32f50699a9eddcb66ab (patch)
treef1d3f94cb507a659ec164f1af20e26a9765780fe
parenta50c3d7fa0ba4390ac05a290836f076909d2954d (diff)
downloadcurl-49f3117a238b6eac0e22a32f50699a9eddcb66ab.tar.gz
ftp: Expression 'ftpc->wait_data_conn' is always false
Fixes warning detected by PVS-Studio Fixes #4374
-rw-r--r--lib/ftp.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/lib/ftp.c b/lib/ftp.c
index a4a37c9af..4cd9a1acf 100644
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -3570,13 +3570,8 @@ static CURLcode ftp_do_more(struct connectdata *conn, int *completep)
return result;
result = ftp_multi_statemach(conn, &complete);
- if(ftpc->wait_data_conn)
- /* if we reach the end of the FTP state machine here, *complete will be
- TRUE but so is ftpc->wait_data_conn, which says we need to wait for
- the data connection and therefore we're not actually complete */
- *completep = 0;
- else
- *completep = (int)complete;
+ /* ftpc->wait_data_conn is always false here */
+ *completep = (int)complete;
}
else {
/* download */