summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Satiro <raysatiro@yahoo.com>2020-02-09 03:15:13 -0500
committerJay Satiro <raysatiro@yahoo.com>2020-02-12 16:55:33 -0500
commit4d1aa8d43b1983e5930e461b4ed1b305004395f7 (patch)
tree7934e27224d1a589c4ca890c34723c7cbace6617
parent55bb83c92b8dba30aa0ef15a8130a5509c03d1a5 (diff)
downloadcurl-4d1aa8d43b1983e5930e461b4ed1b305004395f7.tar.gz
multi: fix outdated comment
- Do not say that conn->data is "cleared" by multi_done(). If the connection is in use then multi_done assigns another easy handle still using the connection to conn->data, therefore in that case it is not cleared. Closes https://github.com/curl/curl/pull/4901
-rw-r--r--lib/multi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/multi.c b/lib/multi.c
index 6c9d06b0b..37a37a4f0 100644
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -730,8 +730,8 @@ CURLMcode curl_multi_remove_handle(struct Curl_multi *multi,
we don't leave a half-baked one around */
if(easy_owns_conn) {
- /* multi_done() clears the conn->data field to lose the association
- between the easy handle and the connection
+ /* multi_done() clears the association between the easy handle and the
+ connection.
Note that this ignores the return code simply because there's
nothing really useful to do with it anyway! */