diff options
author | Daniel Stenberg <daniel@haxx.se> | 2017-09-09 11:57:17 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2017-09-11 09:27:28 +0200 |
commit | e155f38d1eaa89cc8ce2a6536b74be2954506bb0 (patch) | |
tree | 0f7e222cb9be21b1276eecf32bb66ebf5057eccc | |
parent | 02eb6184ad6ba6133382dfe24b45472176df92f7 (diff) | |
download | curl-e155f38d1eaa89cc8ce2a6536b74be2954506bb0.tar.gz |
checksrc: verify spaces around equals signs
... as the code style mandates.
-rwxr-xr-x | lib/checksrc.pl | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/lib/checksrc.pl b/lib/checksrc.pl index b9fa9362f..f4ffa1ef3 100755 --- a/lib/checksrc.pl +++ b/lib/checksrc.pl @@ -58,7 +58,9 @@ my %warnings = ( 'OPENCOMMENT' => 'file ended with a /* comment still "open"', 'ASTERISKSPACE' => 'pointer declared with space after asterisk', 'ASTERISKNOSPACE' => 'pointer declared without space before asterisk', - 'ASSIGNWITHINCONDITION' => 'assignment within conditional expression' + 'ASSIGNWITHINCONDITION' => 'assignment within conditional expression', + 'EQUALSNOSPACE' => 'equals sign without following space', + 'NOSPACEEQUALS' => 'equals sign without preceeding space', ); sub readwhitelist { @@ -526,6 +528,20 @@ sub scanfile { "wrongly placed open brace"); } } + + # check for equals sign without spaces next to it + if($nostr =~ /(.*)\=[a-z0-9]/i) { + checkwarn("EQUALSNOSPACE", + $line, length($1)+1, $file, $ol, + "no space after equals sign"); + } + # check for equals sign without spaces before it + elsif($nostr =~ /(.*)[a-z0-9]\=/i) { + checkwarn("NOSPACEEQUALS", + $line, length($1)+1, $file, $ol, + "no space before equals sign"); + } + $line++; $prevl = $ol; } |