diff options
author | Daniel Stenberg <daniel@haxx.se> | 2019-09-19 09:16:41 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2019-09-20 08:07:00 +0200 |
commit | a50c3d7fa0ba4390ac05a290836f076909d2954d (patch) | |
tree | c0c3aaf3eeb9f3c91b83a2ac6513792db0b87072 | |
parent | 97c17e9fcbb4d27eec3cf51db8599ea151c16042 (diff) | |
download | curl-a50c3d7fa0ba4390ac05a290836f076909d2954d.tar.gz |
ftp: Expression 'ftpc->wait_data_conn' is always true
Fixes warning detected by PVS-Studio
Fixes #4374
-rw-r--r-- | lib/ftp.c | 11 |
1 files changed, 5 insertions, 6 deletions
@@ -3530,14 +3530,13 @@ static CURLcode ftp_do_more(struct connectdata *conn, int *completep) /* if we got an error or if we don't wait for a data connection return immediately */ - if(result || (ftpc->wait_data_conn != TRUE)) + if(result || !ftpc->wait_data_conn) return result; - if(ftpc->wait_data_conn) - /* if we reach the end of the FTP state machine here, *complete will be - TRUE but so is ftpc->wait_data_conn, which says we need to wait for - the data connection and therefore we're not actually complete */ - *completep = 0; + /* if we reach the end of the FTP state machine here, *complete will be + TRUE but so is ftpc->wait_data_conn, which says we need to wait for the + data connection and therefore we're not actually complete */ + *completep = 0; } if(ftp->transfer <= FTPTRANSFER_INFO) { |