diff options
author | Fred Drake <fdrake@acm.org> | 2000-06-30 17:48:51 +0000 |
---|---|---|
committer | Fred Drake <fdrake@acm.org> | 2000-06-30 17:48:51 +0000 |
commit | 11f89cea96aef9f44c4941f0a2e4d7cc8cef462e (patch) | |
tree | 74b020336894bf80b79fd5b9e5c81ee547e2c783 /PC/msvcrtmodule.c | |
parent | d4d696a06e382b8d8a0b2904590530f8fb5458eb (diff) | |
download | cpython-11f89cea96aef9f44c4941f0a2e4d7cc8cef462e.tar.gz |
[*** Not tested as I don't have Windows running right now! ***]
Trent Mick <trentm@activestate.com>:
Fix PC/msvcrtmodule.c and PC/winreg.c for Win64. Basically:
- sizeof(HKEY) > sizeof(long) on Win64, so use PyLong_FromVoidPtr()
instead of PyInt_FromLong() to return HKEY values on Win64
- Check for string overflow of an arbitrary registry value (I know
that ensuring that a registry value does not overflow 2**31 characters
seems ridiculous but it is *possible*).
Closes SourceForge patch #100517.
Diffstat (limited to 'PC/msvcrtmodule.c')
-rwxr-xr-x | PC/msvcrtmodule.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/PC/msvcrtmodule.c b/PC/msvcrtmodule.c index 21be21a5c9..613e173c84 100755 --- a/PC/msvcrtmodule.c +++ b/PC/msvcrtmodule.c @@ -90,7 +90,7 @@ static PyObject *msvcrt_open_osfhandle(PyObject *self, PyObject *args) static PyObject *msvcrt_get_osfhandle(PyObject *self, PyObject *args) { int fd; - long handle; + intptr_t handle; if (!PyArg_ParseTuple(args,"i:get_osfhandle", &fd)) return NULL; @@ -99,7 +99,10 @@ static PyObject *msvcrt_get_osfhandle(PyObject *self, PyObject *args) if (handle == -1) return PyErr_SetFromErrno(PyExc_IOError); - return PyInt_FromLong(handle); + /* technically 'handle' is not a pointer, but a integer as + large as a pointer, Python's *VoidPtr interface is the + most appropriate here */ + return PyLong_FromVoidPtr((void*)handle); } /* Console I/O */ |