diff options
| author | Brett Cannon <bcannon@gmail.com> | 2010-05-04 00:30:17 +0000 |
|---|---|---|
| committer | Brett Cannon <bcannon@gmail.com> | 2010-05-04 00:30:17 +0000 |
| commit | ae58d9a560ef7e119a0cb7b940a9a8ed1e8c4b2d (patch) | |
| tree | de2d1b81001e8690fecbfc3b65f1082541a44fbd /Modules/cPickle.c | |
| parent | ebb605d569ade699818871b764a5116b12142be9 (diff) | |
| download | cpython-ae58d9a560ef7e119a0cb7b940a9a8ed1e8c4b2d.tar.gz | |
Remove a redundant string length check and variable assignment.
Found with Clang's static analyzer.
Diffstat (limited to 'Modules/cPickle.c')
| -rw-r--r-- | Modules/cPickle.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/Modules/cPickle.c b/Modules/cPickle.c index d89e8109e8..79eebcaa25 100644 --- a/Modules/cPickle.c +++ b/Modules/cPickle.c @@ -864,7 +864,7 @@ whichmodule(PyObject *global, PyObject *global_name) *global_name_attr = 0, *name = 0; module = PyObject_GetAttrString(global, "__module__"); - if (module) + if (module) return module; if (PyErr_ExceptionMatches(PyExc_AttributeError)) PyErr_Clear(); @@ -903,7 +903,6 @@ whichmodule(PyObject *global, PyObject *global_name) like this rule. jlf */ if (!j) { - j=1; name=__main___str; } @@ -1235,9 +1234,6 @@ save_string(Picklerobject *self, PyObject *args, int doput) int i; char c_str[5]; - if ((size = PyString_Size(args)) < 0) - return -1; - if (size < 256) { c_str[0] = SHORT_BINSTRING; c_str[1] = size; |