summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYury Selivanov <yury@magic.io>2016-12-16 11:51:57 -0500
committerYury Selivanov <yury@magic.io>2016-12-16 11:51:57 -0500
commit460416a4b039739d559968f467b7f0142f101368 (patch)
treed2d788c9121ad71164d5a087bd57ddaed25218b4
parentc29637b71f9f339cdd0421df0de5cceebfea5212 (diff)
downloadcpython-460416a4b039739d559968f467b7f0142f101368.tar.gz
Merge 3.5 (issue #28990)
-rw-r--r--Lib/asyncio/sslproto.py1
-rw-r--r--Lib/test/test_asyncio/test_sslproto.py10
-rw-r--r--Misc/NEWS4
3 files changed, 15 insertions, 0 deletions
diff --git a/Lib/asyncio/sslproto.py b/Lib/asyncio/sslproto.py
index 991c77b482..7ad28d6aa0 100644
--- a/Lib/asyncio/sslproto.py
+++ b/Lib/asyncio/sslproto.py
@@ -480,6 +480,7 @@ class SSLProtocol(protocols.Protocol):
self._loop.call_soon(self._app_protocol.connection_lost, exc)
self._transport = None
self._app_transport = None
+ self._wakeup_waiter(exc)
def pause_writing(self):
"""Called when the low-level transport's buffer goes over
diff --git a/Lib/test/test_asyncio/test_sslproto.py b/Lib/test/test_asyncio/test_sslproto.py
index 0ca6d1bf2a..59ff0f6967 100644
--- a/Lib/test/test_asyncio/test_sslproto.py
+++ b/Lib/test/test_asyncio/test_sslproto.py
@@ -85,5 +85,15 @@ class SslProtoHandshakeTests(test_utils.TestCase):
# Restore error logging.
log.logger.setLevel(log_level)
+ def test_connection_lost(self):
+ # From issue #472.
+ # yield from waiter hang if lost_connection was called.
+ waiter = asyncio.Future(loop=self.loop)
+ ssl_proto = self.ssl_protocol(waiter)
+ self.connection_made(ssl_proto)
+ ssl_proto.connection_lost(ConnectionAbortedError)
+ test_utils.run_briefly(self.loop)
+ self.assertIsInstance(waiter.exception(), ConnectionAbortedError)
+
if __name__ == '__main__':
unittest.main()
diff --git a/Misc/NEWS b/Misc/NEWS
index 5cf929f21f..dc8acc8b49 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -14,6 +14,10 @@ Core and Builtins
must not convert combined table into split table. Patch written by INADA
Naoki.
+- Issue #28990: Fix SSL hanging if connection is closed before handshake
+ completed.
+ (Patch by HoHo-Ho)
+
Windows
-------