summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2015-02-06 08:35:20 +0200
committerSerhiy Storchaka <storchaka@gmail.com>2015-02-06 08:35:20 +0200
commit8be508f27ae32f15c6babea9f8708d25ae30e47c (patch)
tree3c248b20ed3b896ae6f4b6af2857859df6360eba
parent5ddbc55c5e080abffad796341789a72f240fae09 (diff)
downloadcpython-8be508f27ae32f15c6babea9f8708d25ae30e47c.tar.gz
Issue #23881: Only use entry-values with gdb 7.4 in tests.
Fixes a regression in issue #22765. Patch by Vinson Lee.
-rw-r--r--Lib/test/test_gdb.py18
1 files changed, 10 insertions, 8 deletions
diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index 2db9cd59f9..aaa5c69d49 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -124,14 +124,6 @@ class DebuggerTests(unittest.TestCase):
commands = ['set breakpoint pending yes',
'break %s' % breakpoint,
- # GDB as of 7.4 (?) onwards can distinguish between the
- # value of a variable at entry vs current value:
- # http://sourceware.org/gdb/onlinedocs/gdb/Variables.html
- # which leads to the selftests failing with errors like this:
- # AssertionError: 'v@entry=()' != '()'
- # Disable this:
- 'set print entry-values no',
-
# The tests assume that the first frame of printed
# backtrace will not contain program counter,
# that is however not guaranteed by gdb
@@ -143,6 +135,16 @@ class DebuggerTests(unittest.TestCase):
'set print address off',
'run']
+
+ # GDB as of 7.4 onwards can distinguish between the
+ # value of a variable at entry vs current value:
+ # http://sourceware.org/gdb/onlinedocs/gdb/Variables.html
+ # which leads to the selftests failing with errors like this:
+ # AssertionError: 'v@entry=()' != '()'
+ # Disable this:
+ if (gdb_major_version, gdb_minor_version) >= (7, 4):
+ commands += ['set print entry-values no']
+
if cmds_after_breakpoint:
commands += cmds_after_breakpoint
else: