diff options
author | Benjamin Peterson <benjamin@python.org> | 2011-05-31 18:59:49 -0500 |
---|---|---|
committer | Benjamin Peterson <benjamin@python.org> | 2011-05-31 18:59:49 -0500 |
commit | 9cacc93d2d42ec33a3c6e71b311d818a55584893 (patch) | |
tree | e65f0e31b7544c62ef4427d14e690ba5e908f34b | |
parent | 13fa43f13eb8f402da37b780f2983af6c6d39f36 (diff) | |
download | cpython-9cacc93d2d42ec33a3c6e71b311d818a55584893.tar.gz |
simply use the Python version for pyexpat.__version__ #12221
-rw-r--r-- | Misc/NEWS | 5 | ||||
-rw-r--r-- | Modules/pyexpat.c | 26 |
2 files changed, 10 insertions, 21 deletions
@@ -7,6 +7,11 @@ What's New in Python 2.7.2? *Release date: 2011-06-XX* +Extension Modules +----------------- + +- Issue #1221: Make pyexpat.__version__ equal to the Python version. + What's New in Python 2.7.2 release candidate 1? =============================================== diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c index 3bd68a9441..3d04ca8c45 100644 --- a/Modules/pyexpat.c +++ b/Modules/pyexpat.c @@ -1792,26 +1792,6 @@ static struct PyMethodDef pyexpat_methods[] = { PyDoc_STRVAR(pyexpat_module_documentation, "Python wrapper for Expat parser."); -/* Return a Python string that represents the version number without the - * extra cruft added by revision control, even if the right options were - * given to the "cvs export" command to make it not include the extra - * cruft. - */ -static PyObject * -get_version_string(void) -{ - static char *rcsid = "$Revision$"; - char *rev = rcsid; - int i = 0; - - while (!isdigit(Py_CHARMASK(*rev))) - ++rev; - while (rev[i] != ' ' && rev[i] != '\0') - ++i; - - return PyString_FromStringAndSize(rev, i); -} - /* Initialization function for the module */ #ifndef MODULE_NAME @@ -1841,6 +1821,7 @@ MODULE_INITFUNC(void) PyObject *modelmod_name; PyObject *model_module; PyObject *sys_modules; + PyObject *version; static struct PyExpat_CAPI capi; PyObject* capi_object; @@ -1872,7 +1853,10 @@ MODULE_INITFUNC(void) Py_INCREF(&Xmlparsetype); PyModule_AddObject(m, "XMLParserType", (PyObject *) &Xmlparsetype); - PyModule_AddObject(m, "__version__", get_version_string()); + version = PyString_FromString(PY_VERSION); + if (!version) + return; + PyModule_AddObject(m, "__version__", version); PyModule_AddStringConstant(m, "EXPAT_VERSION", (char *) XML_ExpatVersion()); { |