summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBarry Warsaw <barry@python.org>2010-03-01 21:46:51 +0000
committerBarry Warsaw <barry@python.org>2010-03-01 21:46:51 +0000
commit3583751c93e1994caf29aa3da4baa8a7ff473480 (patch)
tree962f4caa5a92e8a02b6e4380121ebb271c97f6b2
parente45446f0f6da706e1a3f09cbf2bd3f208992c40e (diff)
downloadcpython-3583751c93e1994caf29aa3da4baa8a7ff473480.tar.gz
Manually copy patch for bug 7250 from the release26-maint branch. I suck
because I did this in the wrong order and couldn't smack svnmerge into submission.
-rw-r--r--Lib/wsgiref/handlers.py4
-rw-r--r--Misc/NEWS3
2 files changed, 7 insertions, 0 deletions
diff --git a/Lib/wsgiref/handlers.py b/Lib/wsgiref/handlers.py
index fcb8e23937..a5f7109c26 100644
--- a/Lib/wsgiref/handlers.py
+++ b/Lib/wsgiref/handlers.py
@@ -434,6 +434,10 @@ class CGIHandler(BaseCGIHandler):
"""
wsgi_run_once = True
+ # Do not allow os.environ to leak between requests in Google App Engine
+ # and other multi-run CGI use cases. This is not easily testable.
+ # See http://bugs.python.org/issue7250
+ os_environ = {}
def __init__(self):
BaseCGIHandler.__init__(
diff --git a/Misc/NEWS b/Misc/NEWS
index 9729699d22..0564d138d4 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -35,6 +35,9 @@ Core and Builtins
Library
-------
+- Issue #7250: Fix info leak of os.environ across multi-run uses of
+ wsgiref.handlers.CGIHandler.
+
- Issue #1729305: Fix doctest to handle encode error with "backslashreplace".
- Issue #691291: codecs.open() should not convert end of lines on reading and