summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* maint: post-release administriviaPádraig Brady2023-04-183-2/+5
| | | | | | * NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
* version 9.3v9.3Pádraig Brady2023-04-181-1/+1
| | | | * NEWS: Record release date.
* tests: avoid allocation checks on ZFSPádraig Brady2023-04-161-1/+3
| | | | | * tests/du/basic.sh: Allocation of files was seen to change asynchronously on ZFS, so avoid allocation comparisons there.
* tests: tty-eof: fix various issuesPádraig Brady2023-04-141-4/+8
| | | | | | | * tests/misc/tty-eof.pl: Ensure we don't erroneously skip commands with parameters. Comment as to why cut(1) is treated differently. Adjust expect calls to not wait needlessly for cut output.
* tests: avoid dependence on file layout for cp sparse checkPádraig Brady2023-04-131-14/+4
| | | | | | * tests/cp/sparse-2.sh: Don't depend on the copy taking <= allocation of the source. Instead leverage --debug to check that zero detection is being enabled.
* copy: --debug: indicate if NUL detection is used with SEEK_HOLEPádraig Brady2023-04-131-0/+4
| | | | | * src/copy.c (sparse_copy): With --sparse=always we also detect NULs in extents we're copying, so indicate this with --debug.
* doc: update re 32-bit buildsPaul Eggert2023-04-101-7/+7
| | | | | * README-install: Mention how to build on 32-bit-only hosts. This builds on a previous patch by Pádraig Brady.
* build: fix _Noreturn compilation failurePádraig Brady2023-04-103-3/+5
| | | | | | | | | Fix a build failure seen on gcc 3.4 on Solaris 10 at least. * src/crctab.c: Ensure we include config.h for all compilation units. This is now required for new _Noreturn usage in gnulib for stdint.h. * src/cksum.c: Update generation code to ensure config.h included. * cfg.mk: Remove crctab.c exclusion from the config.h check.
* tests: avoid non portable brace expansionPádraig Brady2023-04-101-2/+2
| | | | | * tests/cp/backup-dir.sh: Avoid non portable brace expansion which is not supported by FreeBSD or Solaris shells at least.
* maint: require support for post-2038 timestampsPaul Eggert2023-04-092-1/+6
| | | | | * bootstrap.conf (gnulib_modules): Replace year2038 with year2038-required.
* build: update gnulib submodule to latestPaul Eggert2023-04-091-0/+0
|
* wc: ensure we update file offsetPádraig Brady2023-04-083-1/+20
| | | | | | | | * src/wc.c (wc): Update the offset when not reading, and do read if we can't update the offset. * tests/misc/wc-proc.sh: Add a test case. * NEWS: Mention the bug fix. Fixes https://bugs.gnu.org/61300
* cp,mv: issue "skipped" messages when skipping filesPádraig Brady2023-04-084-12/+53
| | | | | | | | | * NEWS: Mention the change in behavior to issue a "not replaced" error diagnostic with -n, and the "skipped" message with -v. * src/copy.c (copy_internal): Adjust to output the "skipped" messages depending on -i, -n, -u. * tests/cp/cp-i.sh: Adjust accordingly. * tests/mv/mv-n.sh: Likewise.
* cp,mv: add --update=none to always skip existing filesPádraig Brady2023-04-088-36/+194
| | | | | | | | | | | | | | | | | | | | | | | | | | Add --update=none which is equivalent to the --no-clobber behavior from before coreutils 9.2. I.e. existing files are unconditionally skipped, and them not being replaced does not affect the exit status. * src/copy.h [enum Update_type]: A new type to support parameters to the --update command line option. [enum Interactive]: Add I_ALWAYS_SKIP. * src/copy.c: Treat I_ALWAYS_SKIP like I_ALWAYS_NO (-n), except that we don't fail when skipping. * src/system.h (emit_update_parameters_note): A new function to output the description of the new --update parameters. * src/cp.c (main): Parse --update arguments, ensuring that -n takes precedence if specified. (usage): Describe the new option. Also allude that -u is related in the -n description. * src/mv.c: Accept the new --update parameters and update usage() accordingly. * doc/coreutils.texi (cp invocation): Describe the new --update parameters. Also reference --update from the --no-clobber description. (mv invocation): Likewise. * tests/mv/update.sh: Test the new parameters. * NEWS: Mention the new feature. Addresses https://bugs.gnu.org/62572
* cp: fix --backup with subdirectoriesPádraig Brady2023-04-043-2/+13
| | | | | | | | | * gnulib: Reference the latest gnulib including the fix to the backupfile module in commit 94496522. * tests/cp/backup-dir.sh: Add a test to ensure we rename appropriately when backing up through subdirs. * NEWS: Mention the bug fix. Fixes https://bugs.gnu.org/62607
* tests: tee: avoid false failure due to fifo usagePádraig Brady2023-03-311-1/+1
| | | | | | | | * tests/misc/tee.sh: Call cleanup_ in all cases to ensure there are no overlapping interactions on the fifo that might impact later parts of the test. This was seen to cause issue with dash on musl libc. Addresses https://bugs.gnu.org/62542
* tests: adjust csplit VM limitPádraig Brady2023-03-311-1/+1
| | | | | | | | * tests/misc/csplit-heap.sh: More memory is required to avoid a false failure on some systems. Noticed with musl libc with bash as the shell. This is confirmed to still easily trigger with the original memory leak being tested. Addresses https://bugs.gnu.org/62542
* wc: diagnose overflow of total countsPádraig Brady2023-03-313-7/+64
| | | | | | | | | * src/wc.c (wc): Use INT_ADD_WRAPV() to detect overflow. (main): Upon overflow, saturate the total, print a diagnostic, and set exit status. * tests/misc/wc-total.sh: Add a test case, which operates on BTRFS and 64 bit systems at least. Reported at https://bugs.debian.org/1027100
* dircolors: diagnose read errorsPádraig Brady2023-03-284-2/+36
| | | | | | | * NEWS: Mention the fix. * src/dircolors.c: Fail upon read error from getline(). * tests/misc/dircolors.sh: Add a new test. * tests/local.mk: Reference the new test.
* tests: add a test case for the previous date fixPádraig Brady2023-03-283-0/+34
| | | | | | * NEWS: Also mention this bug fix. * tests/misc/date-f.sh: Add a new test. * tests/local.mk: Reference the new test.
* date: diagnose -f read errorsPaul Eggert2023-03-281-1/+3
| | | | * src/date.c (batch_convert): Diagnose read errors, fixing Bug#62497.
* cp: clarify commentaryPaul Eggert2023-03-251-11/+11
| | | | * src/copy.c: Make comments a bit clearer.
* copy: fix --reflink=auto to fallback in more casesPádraig Brady2023-03-242-27/+43
| | | | | | | | | | | | | | | | | On restricted systems like android or some containers, FICLONE could return EPERM, EACCES, or ENOTTY, which would have induced the command to fail to copy rather than falling back to a more standard copy. * src/copy.c (is_terminal_failure): A new function refactored from handle_clone_fail(). (is_CLONENOTSUP): Merge in the handling of EACCES, ENOTTY, EPERM as they also pertain to determination of whether cloning is supported if we ever use this function in that context. (handle_clone_fail): Use is_terminal_failure() in all cases, so that we assume a terminal failure in less errno cases. * NEWS: Mention the bug fix. Addresses https://bugs.gnu.org/62404
* doc: add a NEWS entry for the previous fixPádraig Brady2023-03-241-0/+5
| | | | * NEWS: Mention the previous cksum --check fix.
* cksum: fix reporting of failed checksPádraig Brady2023-03-232-2/+12
| | | | | | | | | | | | This applies to all checksumming utilities, where we incorrectly report all subsequent files as checking 'OK' once any file has passed a digest check. The exit status was not impacted, only the printed status. * src/digest.c (digest_check): Use the correct state variable to determine if the _current_ file has passed or not. * tests/misc/md5sum.pl: Add a test case. Fixes https://bugs.gnu.org/62403
* tests: skip some parts of tests/misc/tee.sh if run as rootNick Alcock2023-03-211-3/+5
| | | | | | | | | Similarly to the fix to tests/rmdir/ignore.sh in c0e5f8c59, tee should not be expected to fail when run with read-only outputs when run as root. * tests/misc/tee.sh: Add uid_is_privileged_ guard around test for read-only outputs.
* maint: post-release administriviaPádraig Brady2023-03-203-2/+5
| | | | | | * NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
* version 9.2v9.2Pádraig Brady2023-03-201-1/+1
| | | | * NEWS: Record release date.
* tests: avoid false failure on systems without statxPádraig Brady2023-03-192-4/+6
| | | | | | * tests/ls/stat-free-symlinks.sh: Filter out syscalls that return ENOSYS, as that was seen with statx() on Debian 10.13 on mips64, and resulted in overcounting of stat calls.
* stty: ensure arbitrary data is not displayedPádraig Brady2023-03-191-2/+6
| | | | | | | | | | * src/stty.c (main): Use static structures to ensure they're initialized (to zero), so that random data is not displayed, or compared resulting in a inaccurate failure reported to users. This was seen on musl libc where some parts of the termios c_cc array were not initialized by tcgetattr(). Reported by Bruno Haible.
* tests: df: avoid false failure on systems with multiple rootsPádraig Brady2023-03-191-3/+6
| | | | | * tests/df/df-symlink.sh: Skip the test on systems with multiple file system roots.
* doc: uniq: revert previous man page adjustmentPádraig Brady2023-03-181-3/+4
| | | | | * src/uniq.c (usage): -D doesn't take an argument so should be separated in the description.
* doc: uniq: use more standard description of -D long optionPádraig Brady2023-03-181-4/+3
| | | | | | * src/uniq.c: Describe -D and --all-repeated together, as with all other long options. Fixes https://bugs.gnu.org/62249
* tests: aix: avoid unsupported functionalityPádraig Brady2023-03-182-2/+10
| | | | | | | * tests/misc/tee.sh: AIX doesn't support detecting closed outputs either with poll() or select() so avoid testing that functionality. * tests/tail-2/pipe-f.sh: Likewise.
* maint: avoid discarded-qualifiers warnings with SELinux 3.5Bernhard Voelker2023-03-171-2/+2
| | | | | | | | | | | | | | | | | | | | Since SELinux version 3.5, the return value of context_str(3) is declared as const; see: https://github.com/SELinuxProject/selinux/commit/dd98fa322766 Therefore, GCC complains (here with -Werror): src/selinux.c: In function 'defaultcon': src/selinux.c:152:16: error: assignment discards 'const' qualifier \ from pointer target type [-Werror=discarded-qualifiers] 152 | if (!(constr = context_str (tcontext))) | ^ src/selinux.c: In function 'restorecon_private': src/selinux.c:252:16: error: assignment discards 'const' qualifier \ from pointer target type [-Werror=discarded-qualifiers] 252 | if (!(constr = context_str (tcontext))) | ^ * src/selinux.c (defaultcon): Define CONSTR as const. (restorecon_private): Likewise.
* test: avoid a test hang on HurdPádraig Brady2023-03-151-1/+1
| | | | | | * tests/cp/sparse-to-pipe.sh: Protect the cp call seen to hang on Hurd/i686 with a timeout. Reported By: Bruno Haible
* cksum: fix --raw on 64 bit big endian systemsPádraig Brady2023-03-151-2/+4
| | | | | | | | | | * src/sum.c (output_bsd): On sparc64 for example, a crc of 0 was output due to casting an int variable to uint16_t and thus operating on the wrong end of the variable. Instead use explicit assignment to the narrower type to ensure we get the appropriate data. (output_sysv): Likewise. Reported by Bruno Haible.
* build: avoid -Wsometimes-uninitialized on macOS 12Bruno Haible2023-03-152-2/+2
| | | | | * src/pr.c (integer_overflow): Mark as _Noreturn. * src/test.c (beyond): Likewise.
* doc: remove older ChangeLog itemsPádraig Brady2023-03-131-1/+1
| | | | | * Makefile.am: Update the oldest documented version to 8.29 which is now about 5 years old.
* tee: avoid undefined behavior after fclose()Pádraig Brady2023-03-133-9/+11
| | | | | | | * iopoll.c (fclose_wait): Rename from confusing fclose_nonblock name. Also adjust to do no operations on the stream after fclose() as this is undefined. Instead use fflush() to determine EAGAIN status. (fwrite_wait): Renamed from confusing fwrite_nonblock name.
* doc: dircolors: better separate the sections in the databasePádraig Brady2023-03-131-0/+12
| | | | | | * src/dircolors.hin: Make the separate sections of the self documenting dircolors database more apparent, by adding heading comments, and appropriate separation.
* ls: --color: honor separate sequences for extension casesPádraig Brady2023-03-134-9/+114
| | | | | | | | | | | | | | | | | | | Following on from commit v8.29-45-g24053fbd8 which unconditionally used case insensitive extension matching, support selective case sensitive matching when there are separate extension cases defined with different display sequences. * src/dircolors.hin: Document how file name suffixes are matched. Note this is displayed with `dircolors --print-database` which the texi info recommends to use for details. * src/ls.c (parse_ls_color): Postprocess the list to mark entries for case sensitive matching, and also adjust so that unmatchable entries are more quickly ignored. (get_color_indicator): Use exact matching rather than case insensitive matching if so marked. * tests/ls/color-ext.sh: Add test cases. * NEWS: Mention the change in behavior. Addresses https://bugs.gnu.org/33123
* tests: adjust du test for recent apparent size changePádraig Brady2023-03-131-102/+3
| | | | | | * tests/du/threshold.sh: Directories are assumed to be of size 0 with --apparent since commit v9.1-187-g110bcd283 so remove --apparent cases from this test.
* tee: support non blocking outputsPádraig Brady2023-03-085-25/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Non blocking outputs can be seen for example when piping telnet through tee to a terminal. In that case telnet sets its input to nonblocking mode, which results in tee's output being nonblocking, in which case in may receive an EAGAIN error upon write(). The same issue was seen with mpirun. The following can be used to reproduce this locally at a terminal (in most invocations): $ { dd iflag=nonblock count=0 status=none; dd bs=10K count=10 if=/dev/zero status=none; } | tee || echo fail >/dev/tty * src/iopoll.c (iopoll_internal): A new function refactored from iopoll(), to also support a mode where we check the output descriptor is writeable. (iopoll): Now refactored to just call iopoll_internal(). (fwait_for_nonblocking_write): A new internal function which uses iopoll_internal() to wait for writeable output if an EAGAIN or EWOULDBLOCK was received. (fwrite_nonblock): An fwrite() wrapper which uses fwait_for_nonblocking_write() to handle EAGAIN. (fclose_nonblock): Likewise. src/iopoll.h: Add fclose_nonblock, fwrite_nonblock. src/tee.c: Call fclose_nonblock() and fwrite_nonblock wrappers, instead of the standard functions. * tests/misc/tee.sh: Add a test case. * NEWS: Mention the improvement. The idea was suggested by Kamil Dudka in https://bugzilla.redhat.com/1615467
* doc: remove redundant NEWS entryPádraig Brady2023-03-081-4/+0
| | | | | * NEWS: There was no bug on macOS, and the split -n new feature is documented already.
* split: support split -n on larger pipe inputPaul Eggert2023-03-075-43/+72
| | | | | | | | | * bootstrap.conf (gnulib_modules): Add free-posix, tmpfile. * src/split.c (copy_to_tmpfile): New function. (input_file_size): Use it to split larger files when sizes cannot easily be determined via fstat or lseek. See Bug#61386#235. * tests/split/l-chunk.sh: Mark tests of /dev/zero as very expensive since they exhaust /tmp.
* tee: fix a crash with unwriteable filesPádraig Brady2023-03-072-3/+10
| | | | | | | | This was introduced recently with commit v9.1-166-g6b12e62d9 * src/tee.c (tee_files): Check the return from fopen() before passing to fileno() etc. * tests/misc/tee.sh: Add a test case.
* maint: pacify ‘make syntax-check’Paul Eggert2023-03-062-4/+4
| | | | | | | | Problem reported by Pádraig Brady (Bug#61386#226). * src/split.c (parse_chunk): Use die instead of error. (main): Quote a string. * tests/local.mk (all_root_tests): Move du/apparent.sh from here ... (all_tests): ... to here.
* tail,tee: avoid issues with many files on systems without pollPádraig Brady2023-03-061-0/+6
| | | | | * src/iopoll.c (iopoll): Protect the call to select against passing in a descriptor larger than FD_SETSIZE.
* du: --apparent counts only symlinks and regularPaul Eggert2023-03-045-4/+46
| | | | | | | | Problem reported by Christoph Anton Mitterer (Bug#61884). * src/du.c (process_file): When counting apparent sizes, count only usable st_size members. * tests/du/apparent.sh: New file. * tests/local.mk (all_root_tests): Add it.