all: avoid quoting file names when possible

Quote file names using the "shell-escape" or "shell-escape-always"
methods, which quote as appropriate for most shells,
and better support copy and paste of presented names.
The "always" variant is used when the file name is
embedded in an error message with surrounding spaces.

* cfg.mk (sc_error_shell_quotes): A new syntax check rule
to suggest quotef() where appropriate.
(sc_error_shell_always_quotes): Likewise for quoteaf().
* src/system.h (quotef): A new define to apply shell quoting
when needed.  I.E. when shell character or ':' is present.
(quoteaf): Likewise, but always quote.
* src/*.c: Use quotef() and quoteaf() rather than quote()
where appropriate.
* tests/: Adjust accordingly.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/chroot.c b/src/chroot.c
index 9551d934f..ec2f5c444 100644
--- a/src/chroot.c
+++ b/src/chroot.c
@@ -200,7 +200,7 @@ Run COMMAND with root directory set to NEWROOT.\n\
 "), stdout);
       printf (_("\
   --skip-chdir           do not change working directory to %s\n\
-"), quote ("/"));
+"), quoteaf ("/"));
 
       fputs (HELP_OPTION_DESCRIPTION, stdout);
       fputs (VERSION_OPTION_DESCRIPTION, stdout);
@@ -284,7 +284,7 @@ main (int argc, char **argv)
   if (! is_oldroot && skip_chdir)
     {
       error (0, 0, _("option --skip-chdir only permitted if NEWROOT is old %s"),
-             quote ("/"));
+             quoteaf ("/"));
       usage (EXIT_CANCELED);
     }
 
@@ -327,7 +327,7 @@ main (int argc, char **argv)
 
   if (chroot (newroot) != 0)
     error (EXIT_CANCELED, errno, _("cannot change root directory to %s"),
-           quote (newroot));
+           quoteaf (newroot));
 
   if (! skip_chdir && chdir ("/"))
     error (EXIT_CANCELED, errno, _("cannot chdir to root directory"));