diff options
| author | Michal Gorny <mgorny@gentoo.org> | 2019-01-09 13:27:29 +0000 |
|---|---|---|
| committer | Michal Gorny <mgorny@gentoo.org> | 2019-01-09 13:27:29 +0000 |
| commit | 4037a5a32ec582b279ae7641a058598bda86ee40 (patch) | |
| tree | 62989a79669eb59b19a4553d00e1622fd34f5875 | |
| parent | b53518b4870d430a41f4b37cc076c7eb090982da (diff) | |
| download | compiler-rt-4037a5a32ec582b279ae7641a058598bda86ee40.tar.gz | |
[test] Detect glibc-2.27+ and XFAIL appropriate tests
XFAIL the tests known to fail with glibc-2.27+. This takes away
the burden of handling known failures from users, and ensures that
we will be verbosely informed when they actually start working again.
Bug report: https://bugs.llvm.org/show_bug.cgi?id=37804
Differential Revision: https://reviews.llvm.org/D56062
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@350717 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | test/lit.common.cfg | 15 | ||||
| -rw-r--r-- | test/lsan/TestCases/Linux/use_tls_dynamic.cc | 5 | ||||
| -rw-r--r-- | test/msan/dtls_test.c | 5 |
3 files changed, 25 insertions, 0 deletions
diff --git a/test/lit.common.cfg b/test/lit.common.cfg index 975ae29e8..cbd908280 100644 --- a/test/lit.common.cfg +++ b/test/lit.common.cfg @@ -289,6 +289,21 @@ if config.android: if android_api_level >= 28: config.available_features.add('android-28') +if config.host_os == 'Linux': + # detect whether we are using glibc, and which version + # NB: 'ldd' is just one of the tools commonly installed as part of glibc + ldd_ver_cmd = subprocess.Popen(['ldd', '--version'], + stdout=subprocess.PIPE, + env={'LANG': 'C'}) + sout, _ = ldd_ver_cmd.communicate() + ver_line = sout.splitlines()[0] + if ver_line.startswith(b"ldd "): + from distutils.version import LooseVersion + ver = LooseVersion(ver_line.split()[-1].decode()) + # 2.27 introduced some incompatibilities + if ver >= LooseVersion("2.27"): + config.available_features.add("glibc-2.27") + sancovcc_path = os.path.join(config.llvm_tools_dir, "sancov") if os.path.exists(sancovcc_path): config.available_features.add("has_sancovcc") diff --git a/test/lsan/TestCases/Linux/use_tls_dynamic.cc b/test/lsan/TestCases/Linux/use_tls_dynamic.cc index 4d70a46f8..8093d6f0e 100644 --- a/test/lsan/TestCases/Linux/use_tls_dynamic.cc +++ b/test/lsan/TestCases/Linux/use_tls_dynamic.cc @@ -1,4 +1,9 @@ // Test that dynamically allocated TLS space is included in the root set. + +// This is known to be broken with glibc-2.27+ +// https://bugs.llvm.org/show_bug.cgi?id=37804 +// XFAIL: glibc-2.27 + // RUN: LSAN_BASE="report_objects=1:use_stacks=0:use_registers=0:use_ld_allocations=0" // RUN: %clangxx %s -DBUILD_DSO -fPIC -shared -o %t-so.so // RUN: %clangxx_lsan %s -o %t diff --git a/test/msan/dtls_test.c b/test/msan/dtls_test.c index ee91be2ff..bc1fe609a 100644 --- a/test/msan/dtls_test.c +++ b/test/msan/dtls_test.c @@ -11,6 +11,11 @@ // Reports use-of-uninitialized-value, not analyzed XFAIL: netbsd + + // This is known to be broken with glibc-2.27+ + // https://bugs.llvm.org/show_bug.cgi?id=37804 + XFAIL: glibc-2.27 + */ #ifndef BUILD_SO |