diff options
| author | Dan Liew <dan@su-root.co.uk> | 2019-01-11 17:59:52 +0000 |
|---|---|---|
| committer | Dan Liew <dan@su-root.co.uk> | 2019-01-11 17:59:52 +0000 |
| commit | 222cbb9e89dd8ddeacfe2b1ba0931ee6198d0fc8 (patch) | |
| tree | e9fc98e935ad652e1c43c9adc99a10c131bebaf2 | |
| parent | bd3acec0513387fe9cefb5b21d9772873017538a (diff) | |
| download | compiler-rt-222cbb9e89dd8ddeacfe2b1ba0931ee6198d0fc8.tar.gz | |
Provide storage for `true_type::value` and `false_type::value`.
Summary:
This fixes linker errors that occurs when the
`sanitizer_type_traits_test.cc` is built without optimizations.
The error occurs because the test tries to take a reference.
A possible workaround is to give the GTest macros take boolean rvalues
by doing something like:
```
ASSERT_TRUE(bool(is_same<uptr, uptr>::value));
```
However this only hides the problem. Unfortunately Using `constexpr`
won't fix the problem unless we are using C++17.
Reviewers: vitalybuka, kubamracek, george.karpenkov, yln
Subscribers: mgorny, #sanitizers, llvm-commits
Differential Revision: https://reviews.llvm.org/D56035
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@350940 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/sanitizer_common/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | lib/sanitizer_common/sanitizer_type_traits.cc | 21 |
2 files changed, 22 insertions, 0 deletions
diff --git a/lib/sanitizer_common/CMakeLists.txt b/lib/sanitizer_common/CMakeLists.txt index 64a7bc49c..f4e768f1a 100644 --- a/lib/sanitizer_common/CMakeLists.txt +++ b/lib/sanitizer_common/CMakeLists.txt @@ -38,6 +38,7 @@ set(SANITIZER_SOURCES_NOTERMINATION sanitizer_suppressions.cc sanitizer_tls_get_addr.cc sanitizer_thread_registry.cc + sanitizer_type_traits.cc sanitizer_win.cc) if(UNIX AND NOT APPLE AND NOT OS_NAME MATCHES "SunOS") diff --git a/lib/sanitizer_common/sanitizer_type_traits.cc b/lib/sanitizer_common/sanitizer_type_traits.cc new file mode 100644 index 000000000..27fec6e1f --- /dev/null +++ b/lib/sanitizer_common/sanitizer_type_traits.cc @@ -0,0 +1,21 @@ +//===-- sanitizer_type_traits.cc --------------------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// +// +// Implements a subset of C++ type traits. This is so we can avoid depending +// on system C++ headers. +// +//===----------------------------------------------------------------------===// +#include "sanitizer_type_traits.h" + +namespace __sanitizer { + +const bool true_type::value; +const bool false_type::value; + +} // namespace __sanitizer |