1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
# This file is part of cloud-init. See LICENSE file for license information.
import logging
import os
import shutil
import tempfile
from io import BytesIO
import configobj
import pytest
from cloudinit import util
from cloudinit.config import cc_mcollective
from cloudinit.config.schema import (
SchemaValidationError,
get_schema,
validate_cloudconfig_schema,
)
from tests.unittests import helpers as t_help
from tests.unittests.util import get_cloud
LOG = logging.getLogger(__name__)
STOCK_CONFIG = """\
main_collective = mcollective
collectives = mcollective
libdir = /usr/share/mcollective/plugins
logfile = /var/log/mcollective.log
loglevel = info
daemonize = 1
# Plugins
securityprovider = psk
plugin.psk = unset
connector = activemq
plugin.activemq.pool.size = 1
plugin.activemq.pool.1.host = stomp1
plugin.activemq.pool.1.port = 61613
plugin.activemq.pool.1.user = mcollective
plugin.activemq.pool.1.password = marionette
# Facts
factsource = yaml
plugin.yaml = /etc/mcollective/facts.yaml
"""
class TestConfig(t_help.FilesystemMockingTestCase):
def setUp(self):
super(TestConfig, self).setUp()
self.tmp = tempfile.mkdtemp()
self.addCleanup(shutil.rmtree, self.tmp)
# "./": make os.path.join behave correctly with abs path as second arg
self.server_cfg = os.path.join(
self.tmp, "./" + cc_mcollective.SERVER_CFG
)
self.pubcert_file = os.path.join(
self.tmp, "./" + cc_mcollective.PUBCERT_FILE
)
self.pricert_file = os.path.join(
self.tmp, self.tmp, "./" + cc_mcollective.PRICERT_FILE
)
def test_basic_config(self):
cfg = {
"mcollective": {
"conf": {
"loglevel": "debug",
"connector": "rabbitmq",
"logfile": "/var/log/mcollective.log",
"ttl": "4294957",
"collectives": "mcollective",
"main_collective": "mcollective",
"securityprovider": "psk",
"daemonize": "1",
"factsource": "yaml",
"direct_addressing": "1",
"plugin.psk": "unset",
"libdir": "/usr/share/mcollective/plugins",
"identity": "1",
},
},
}
expected = cfg["mcollective"]["conf"]
self.patchUtils(self.tmp)
cc_mcollective.configure(cfg["mcollective"]["conf"])
contents = util.load_file(cc_mcollective.SERVER_CFG, decode=False)
contents = configobj.ConfigObj(BytesIO(contents))
self.assertEqual(expected, dict(contents))
def test_existing_config_is_saved(self):
cfg = {"loglevel": "warn"}
util.write_file(self.server_cfg, STOCK_CONFIG)
cc_mcollective.configure(config=cfg, server_cfg=self.server_cfg)
self.assertTrue(os.path.exists(self.server_cfg))
self.assertTrue(os.path.exists(self.server_cfg + ".old"))
self.assertEqual(
util.load_file(self.server_cfg + ".old"), STOCK_CONFIG
)
def test_existing_updated(self):
cfg = {"loglevel": "warn"}
util.write_file(self.server_cfg, STOCK_CONFIG)
cc_mcollective.configure(config=cfg, server_cfg=self.server_cfg)
cfgobj = configobj.ConfigObj(self.server_cfg)
self.assertEqual(cfg["loglevel"], cfgobj["loglevel"])
def test_certificats_written(self):
# check public-cert and private-cert keys in config get written
cfg = {
"loglevel": "debug",
"public-cert": "this is my public-certificate",
"private-cert": "secret private certificate",
}
cc_mcollective.configure(
config=cfg,
server_cfg=self.server_cfg,
pricert_file=self.pricert_file,
pubcert_file=self.pubcert_file,
)
found = configobj.ConfigObj(self.server_cfg)
# make sure these didnt get written in
self.assertFalse("public-cert" in found)
self.assertFalse("private-cert" in found)
# these need updating to the specified paths
self.assertEqual(found["plugin.ssl_server_public"], self.pubcert_file)
self.assertEqual(found["plugin.ssl_server_private"], self.pricert_file)
# and the security provider should be ssl
self.assertEqual(found["securityprovider"], "ssl")
self.assertEqual(
util.load_file(self.pricert_file), cfg["private-cert"]
)
self.assertEqual(util.load_file(self.pubcert_file), cfg["public-cert"])
class TestHandler(t_help.TestCase):
@t_help.mock.patch("cloudinit.config.cc_mcollective.subp")
@t_help.mock.patch("cloudinit.config.cc_mcollective.util")
def test_mcollective_install(self, mock_util, mock_subp):
cc = get_cloud()
cc.distro = t_help.mock.MagicMock()
mock_util.load_file.return_value = b""
mycfg = {"mcollective": {"conf": {"loglevel": "debug"}}}
cc_mcollective.handle("cc_mcollective", mycfg, cc, LOG, [])
self.assertTrue(cc.distro.install_packages.called)
install_pkg = cc.distro.install_packages.call_args_list[0][0][0]
self.assertEqual(install_pkg, ("mcollective",))
self.assertTrue(mock_subp.subp.called)
self.assertEqual(
mock_subp.subp.call_args_list[0][0][0],
["service", "mcollective", "restart"],
)
class TestMcollectiveSchema:
@pytest.mark.parametrize(
"config, error_msg",
[
# Disallow undocumented keys client 'mcollective' without error
(
{"mcollective": {"customkey": True}},
"mcollective: Additional properties are not allowed",
),
# Allow undocumented keys client keys below 'conf' without error
({"mcollective": {"conf": {"customkey": 1}}}, None),
# Don't allow undocumented keys that don't match expected type
(
{"mcollective": {"conf": {"": {"test": None}}}},
"does not match any of the regexes:",
),
(
{"mcollective": {"conf": {"public-cert": 1}}},
"mcollective.conf.public-cert: 1 is not of type 'string'",
),
],
)
@t_help.skipUnlessJsonSchema()
def test_schema_validation(self, config, error_msg):
if error_msg is None:
validate_cloudconfig_schema(config, get_schema(), strict=True)
else:
with pytest.raises(SchemaValidationError, match=error_msg):
validate_cloudconfig_schema(config, get_schema(), strict=True)
# vi: ts=4 expandtab
|
