summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRon Yorston <rmy@pobox.com>2019-07-29 09:51:14 +0100
committerDenys Vlasenko <vda.linux@googlemail.com>2019-10-21 16:54:40 +0200
commitc88d3ec458e66d8c25af81ae7b2044933c069563 (patch)
treebe49ed455212436c9c74e1152905171a5922211a
parent0f1369f0c5b6f0570208f9e5b5cec2b860f23088 (diff)
downloadbusybox-c88d3ec458e66d8c25af81ae7b2044933c069563.tar.gz
ash: only catch unexpected exceptions in PS1 expansion
Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) catches all exceptions raised by expandarg(). Some exceptions, such as the EXEXIT raised when command expansion is used, are expected: export PS1='$(echo "$ ")' These should be processed normally or the shell hangs at the prompt. function old new delta expandstr 344 353 +9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/0 up/down: 9/0) Total: 9 bytes Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/ash.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/shell/ash.c b/shell/ash.c
index e3bbac9a0..c0352602b 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -13126,6 +13126,8 @@ expandstr(const char *ps, int syntax_type)
if (setjmp(jmploc.loc) == 0) {
exception_handler = &jmploc;
expandarg(&n, NULL, EXP_QUOTED);
+ } else if (exception_type == EXEXIT) {
+ exitshell();
}
exception_handler = savehandler;
RESTORE_INT(saveint);