summaryrefslogtreecommitdiff
path: root/spec/deprecation_spec.rb
blob: d7df05bb43dd5b7bb7b93e058c0959379348f8d8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
require "spec_helper"

describe "Bundler version 1.99" do
  context "when bundle is run" do
    it "should print a single deprecation warning" do
      # install_gemfile calls `bundle :install, opts`
      install_gemfile <<-G
        source "file://#{gem_repo1}"
        gem "rack"
      G

      expect(err).to eq("DEPRECATION: Gemfile and Gemfile.lock are " \
       "deprecated and will be replaced with gems.rb and gems.locked in " \
       "Bundler 2.0.0.")
    end
  end

  context "when Bundler.setup is run in a ruby script" do
    it "should print a single deprecation warning" do
      install_gemfile <<-G
        source "file://#{gem_repo1}"
        gem "rack", :group => :test
      G

      ruby <<-RUBY
        require 'rubygems'
        require 'bundler'
        require 'bundler/vendored_thor'

        Bundler.ui = Bundler::UI::Shell.new
        Bundler.setup
        Bundler.setup
      RUBY

      expect(err).to eq("DEPRECATION: Gemfile and Gemfile.lock are " \
       "deprecated and will be replaced with gems.rb and gems.locked in " \
       "Bundler 2.0.0.")
    end
  end

  context "when `bundler/deployment` is required in a ruby script" do
    it "should print a capistrano deprecation warning" do
      install_gemfile <<-G
        source "file://#{gem_repo1}"
        gem "rack", :group => :test
      G

      ruby(<<-RUBY, { :expect_err => true })
        require 'bundler/deployment'
      RUBY

      expect(err).to eq("DEPRECATION: Bundler no longer integrates " \
                             "with Capistrano, but Capistrano provides " \
                             "its own integration with Bundler via the " \
                             "capistrano-bundler gem. Use it instead.")
    end
  end

  describe Bundler::Dsl do
    before do
      @rubygems = double("rubygems")
      allow(Bundler::Source::Rubygems).to receive(:new){ @rubygems }
    end

    context "with github gems" do
      it "warns about the https change" do
        allow(Bundler.ui).to receive(:deprecate)
        msg = "The :github option uses the git: protocol, which is not secure. " \
        "Bundler 2.0 will use the https: protcol, which is secure. Enable this change now by " \
        "running `bundle config github.https true`."
        expect(Bundler.ui).to receive(:deprecate).with(msg)
        subject.gem("sparks", :github => "indirect/sparks")
      end

      it "upgrades to https on request" do
        Bundler.settings["github.https"] = true
        subject.gem("sparks", :github => "indirect/sparks")
        github_uri = "https://github.com/indirect/sparks.git"
        expect(subject.dependencies.first.source.uri).to eq(github_uri)
      end
    end

    context "with bitbucket gems" do
      it "warns about removal" do
        allow(Bundler.ui).to receive(:deprecate)
        msg = "The :bitbucket git source is deprecated, and will be removed " \
          "in Bundler 2.0. Add this code to your Gemfile to ensure it " \
          "continues to work:\n    git_source(:bitbucket) do |repo_name|\n  " \
          "    https://\#{user_name}@bitbucket.org/\#{user_name}/\#{repo_name}" \
          ".git\n    end"
        expect(Bundler.ui).to receive(:deprecate).with(msg, true)
        subject.gem("not-really-a-gem", :bitbucket => "mcorp/flatlab-rails")
      end
    end

    context "with gist gems" do
      it "warns about removal" do
        allow(Bundler.ui).to receive(:deprecate)
        msg = "The :gist git source is deprecated, and will be removed " \
          "in Bundler 2.0. Add this code to your Gemfile to ensure it " \
          "continues to work:\n    git_source(:gist) do |repo_name|\n  " \
          "    https://gist.github.com/\#{repo_name}.git\n" \
          "    end"
        expect(Bundler.ui).to receive(:deprecate).with(msg, true)
        subject.gem("not-really-a-gem", :gist => "1234")
      end
    end
  end
end