summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* add feature flag to use https for :git in the dslcolby/git-https-defaultColby Swandale2018-11-251-0/+16
|
* Followed up https://github.com/bundler/bundler/pull/6743SHIBATA Hiroshi2018-11-162-5/+5
| | | | | #6743 was failed with ruby core repository and ignored working example. Fixed them.
* Merge #6775Bundlerbot2018-11-161-0/+11
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6775: [Plugin::Index] Only register each plugin once for a given hook r=colby-swandale a=segiddins ### What was the end-user problem that led to this PR? The problem was running `plugin install` twice for a plugin withs hooks would cause that hook to be registered twice. Closes #6771. ### What was your diagnosis of the problem? My diagnosis was a plugin's hooks should only be run once per event. ### What is your fix for the problem, implemented in this PR? My fix is to `uniq` the list of plugins registered for each event. Co-authored-by: Samuel Giddins <segiddins@segiddins.me> Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com> Co-authored-by: Colby Swandale <me@colby.fyi>
| * fix rubocopColby Swandale2018-11-161-5/+5
| |
| * Double-register hook in spec segiddins/6771-uniq-hook-registrationOlle Jonsson2018-11-101-1/+6
| | | | | | | | | | To make it clear the list is uniq’d Co-Authored-By: segiddins <segiddins@segiddins.me>
| * [Plugin::Index] Only register each plugin once for a given hookSamuel Giddins2018-11-051-0/+6
| |
* | Merge #6743Bundlerbot2018-11-1628-61/+111
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6743: Support file structure of ruby core repository. r=hsbt a=hsbt ### What was the end-user problem that led to this PR? In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior. ### What is your fix for the problem, implemented in this PR? Support the structure of ruby core repository. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * | rubocop -aSHIBATA Hiroshi2018-11-071-1/+0
| | |
| * | To use around hook instead of before suite.SHIBATA Hiroshi2018-11-061-4/+3
| | |
| * | To use helper method instead of env variables.SHIBATA Hiroshi2018-11-061-2/+2
| | |
| * | Support old versions of Ruby on platform_spec.rbSHIBATA Hiroshi2018-11-021-7/+7
| | |
| * | Partly reverted 09bfdfa31ad5ae34d29745344493f6a63d355804.SHIBATA Hiroshi2018-11-021-4/+4
| | |
| * | To use helper method instead of env variables.SHIBATA Hiroshi2018-11-011-1/+1
| | |
| * | rubocop -aSHIBATA Hiroshi2018-11-011-1/+1
| | |
| * | Fixed typoSHIBATA Hiroshi2018-11-011-1/+1
| | |
| * | Backport from ruby coreSHIBATA Hiroshi2018-11-0120-72/+83
| | |
| * | rubocop -aSHIBATA Hiroshi2018-10-205-13/+11
| | |
| * | Restore rubygems certificates. Current bundler examples will removeSHIBATA Hiroshi2018-10-201-1/+7
| | | | | | | | | | | | them after finished bundler rspec.
| * | Added ruby_core filtering condition with some examples.SHIBATA Hiroshi2018-10-2021-57/+58
| | | | | | | | | | | | The ruby core repository couldn't invoke its examples.
| * | Added to support BUNDLE_RUBY and BUNDLE_GEM environmental variables.SHIBATA Hiroshi2018-10-205-7/+43
| | | | | | | | | | | | They are replaced build binary on ruby core repository.
* | | Merge #6714Bundlerbot2018-11-067-46/+78
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should. ### What was your diagnosis of the problem? My diagnosis was that: * Sometimes specs leak settings and env variable modifications. * When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere. * Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily. ### What is your fix for the problem, implemented in this PR? My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them. ### Why did you choose this fix out of the possible options? I chose this fix because it seems like the best way to alleviate the issues found. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Remove unnecessary installs from git specsspec_reset_state_and_refactoringsDavid Rodríguez2018-10-031-4/+0
| | |
| * | Remove commented out codeDavid Rodríguez2018-10-031-4/+0
| | |
| * | Hangs in specs improvedDavid Rodríguez2018-10-031-1/+1
| | | | | | | | | | | | | | | | | | | | | When working on a bug, I was getting a hang inside the subprocess of a specs, and it was hard to debug because any logging I added was not visible. This reording makes logging visible and can make it easier to troubleshoot these cases.
| * | Reuse `install_gemfile` helperDavid Rodríguez2018-10-032-17/+6
| | |
| * | Move gemfile write to the specs that need itDavid Rodríguez2018-10-031-12/+47
| | | | | | | | | | | | | | | | | | If a set of specs need the Gemfile, they also need to `bundle install` it, so it's more readable to move those together, and also more efficient since we don't create Gemfiles that are not necessary.
| * | Cleanup after ourselves when changing settingsDavid Rodríguez2018-10-033-22/+38
| | | | | | | | | | | | To make sure we don't leak modified global state.
| * | Reword spec so it reads betterDavid Rodríguez2018-10-031-1/+1
| | |
* | | Merge #6769Bundlerbot2018-10-301-0/+24
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6769: Fix `remove` when block method appears in gem name r=segiddins a=dduugg Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? https://github.com/bundler/bundler/issues/6768 ### What was your diagnosis of the problem? `remove_nested_blocks` considers any appearance of text matching a block method (`group source env install_if`) to be an occurrence of a nested block. ### What is your fix for the problem, implemented in this PR? `remove_nested_blocks` should only reduce the scope of where a nested block method can occur. ### Why did you choose this fix out of the possible options? Another approach would use word delimiters rather than `starts_with?` to find nested block methods, but this is probably fine. Co-authored-by: Douglas Eichelberger <dduugg@gmail.com>
| * | | Add testDouglas Eichelberger2018-10-291-0/+24
| | | |
* | | | Remove more unnecessary stuffremove_old_rubygems_stuff_from_specsDavid Rodríguez2018-10-261-2/+0
| | | |
* | | | Remove unnecessary stuff from specsDavid Rodríguez2018-10-266-56/+9
|/ / / | | | | | | | | | Since we no longer test against rubygems versions that old.
* | | fix error with path objects in arrayAlex Gordon2018-10-251-0/+13
| |/ |/|
* | Merge #6749Bundlerbot2018-10-192-0/+49
|\ \ | | | | | | | | | | | | | | | | | | | | | 6749: Add local git repository source option (`--local_git`) to plugin installation r=indirect a=indirect Reopening #6338 to close #5446. Co-authored-by: Saverio Miroddi <saverio.pub2@gmail.com>
| * | Rename `local-git` plugin install option to `local_git`Saverio Miroddi2018-03-272-4/+4
| | | | | | | | | | | | Addresses https://github.com/bundler/bundler/pull/6338#discussion_r177392401.
| * | Rename plugin install --file option to --local-gitSaverio Miroddi2018-03-192-6/+6
| | |
| * | Extend plugin installer file source UTsSaverio Miroddi2018-03-191-0/+31
| | |
| * | Plugin installer: make remote and local git source options mutually exclusiveSaverio Miroddi2018-03-191-0/+7
| | |
| * | Add file path source option (`--file`) to plugin installationSaverio Miroddi2018-03-111-0/+11
| | | | | | | | | | | | | | | | | | Convenience option for installing plugins from a local repository, using the local path: bundle plugin install --file /path/to/bundler-dependency_graph bundler-dependency_graph
* | | Enable gemfile flag for bundle lockLaura Paakkinen2018-10-181-0/+27
| | |
* | | Make RakeTask spec:deps OS agnosticLeo Arnold2018-10-172-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | @segiddins encouraged contributions towards support for Windows https://github.com/bundler/bundler/issues/5992#issuecomment-326809543 As a first step towards this goal this commit fixes file path specification in the first pieces of Ruby code called when setting up a test environment.
* | | Merge #6739Bundlerbot2018-10-171-2/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6739: Remove the duplicate gems from suggestions r=colby-swandale a=y-yagi ### What was the end-user problem that led to this PR? If the lock file has the same gems for different platforms, the suggestion includes all those gems. For example, using the [Rails's lock file](https://github.com/rails/rails/blob/4a51cbba58435bbba65ca50670bd6ae4887942bd/Gemfile.lock), it shows like this: ``` $ bundle update mai Could not find gem 'mai'. Did you mean ffi, ffi, ffi, ffi, mail, ast, jwt, que or wdm? ``` ### What was your diagnosis of the problem? Missing consideration when lock file contains the same gem. ### What is your fix for the problem, implemented in this PR? I removed the same name using `uniq`. Co-authored-by: yuuji.yaginuma <yuuji.yaginuma@gmail.com>
| * | | Remove the duplicate gems from suggestionsyuuji.yaginuma2018-10-151-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the lock file has the same gems for different platforms, the suggestion includes all those gems. For example, using the Rails's lock file(https://github.com/rails/rails/blob/4a51cbba58435bbba65ca50670bd6ae4887942bd/Gemfile.lock), it shows like this: ``` $ bundle update mai Could not find gem 'mai'. Did you mean ffi, ffi, ffi, ffi, mail, ast, jwt, que or wdm? ``` Since it is unnecessary to include the same gem, removed duplicate gems.
* | | | Merge #6742Bundlerbot2018-10-174-5/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6742: Use helper method instead of hard-code path. r=colby-swandale a=hsbt ### What was the end-user problem that led to this PR? In ruby core repository, We need to replace executable file like `ruby`, `rake`, `gem`. ### What is your fix for the problem, implemented in this PR? This pull request makes hard-coded executable file to the helper methods. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * | | | use rake helper methoduse-helper-methodsSHIBATA Hiroshi2018-10-161-2/+2
| | | | |
| * | | | rubocop -aSHIBATA Hiroshi2018-10-161-1/+1
| | | | |
| * | | | added full path of rake executable.SHIBATA Hiroshi2018-10-161-1/+1
| | | | |
| * | | | Added missing helper method for rakeSHIBATA Hiroshi2018-10-161-0/+4
| | | | |
| * | | | Use helper method instead of hard-code path.SHIBATA Hiroshi2018-10-162-3/+3
| |/ / /
* | | | Merge #6741Bundlerbot2018-10-161-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt ### What was the end-user problem that led to this PR? In Windows environment, ':' is always contained path variable. See our original commit and its message https://github.com/ruby/ruby/commit/f35fb6d36c3218988b17dbeb4412922c23745f0e Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
View Lorry Controller Status