summaryrefslogtreecommitdiff
path: root/spec/update
Commit message (Collapse)AuthorAgeFilesLines
* Check for generic lockfilesDavid Rodríguez2019-07-231-1/+1
|
* Normalize file:// handling in specsDavid Rodríguez2019-06-114-16/+16
|
* s/last_command.stderr/err/David Rodríguez2019-04-121-1/+1
|
* Unify stderr helpersDavid Rodríguez2019-04-121-1/+1
|
* Remove `prefer_gems_rb` settinginit_gems_rbDavid Rodríguez2019-04-111-17/+0
| | | | | | | | | | | | In my opinion, it's overkill to provide a setting for how little this setting was doing. Both types of Gemfile are supported and work regardless of this setting. The only difference this setting would make is the warning message one would get when having _both_ types of Gemfiles in the same project. I changed things so that gems.rb is always looked up first, and the warning message in case you have both always tells you to remove Gemfile and Gemfile.lock.
* Move on to bundler 3David Rodríguez2019-04-112-12/+2
| | | | | | * Drop bundler 1 stuff from tests. * Move all feature flags to bundler 3 (like they are in 2-0-stable) and get them tested.
* Merge #7007Bundlerbot2019-04-021-5/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7007: Remove lockfile incompatibility created by the `lockfile_uses_separate_rubygems_sources` setting r=deivid-rodriguez a=deivid-rodriguez This is more of a question PR, I created this patch to try it out and try to understand, not necessarily get it merged. ### What was the end-user problem that led to this PR? The problem was that once we enable the `lockfile_uses_separate_rubygems_sources` setting, all lockfiles in the world will become incompatible with the previous version. Actually, not necessarily incompatible, but bundler will reorder the sections when the setting is enabled, that will generate churn lock file diffs, and _maybe_ some confusion / merge conflicts, and so on. ### What was your diagnosis of the problem? My diagnosis was that maybe this is not necessary. I read over the issues where this setting was added and what I understood is that previously if a Gemfile specified multiple rubygems sources, they would all get merged together and that's dangerous because it's not deterministic from which source each gem will be picked up, and that could be maliciously exploited. So now each source gets its own separate section. However, how does that affect the ordering of the sections? I don't think it should affect it? ### What is your fix for the problem, implemented in this PR? My fix is to change the `lock_sources` method so that both code branches (`lockfile_uses_separate_rubygems_sources == true`, and `lockfile_uses_separate_rubygems_sources == false`) result in the same ordering of the source sections. ### Why did you choose this fix out of the possible options? I chose this fix because I _think_ it keeps the setting doing the same thing, but also keeps lock file compatibility. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove lockfile incompatibility due to a settingseparate_rubygems_sources_in_lockfileDavid Rodríguez2019-03-021-5/+5
| | | | | | | | | | | | The `lockfile_uses_separate_rubygems_sources` was causing a lockfile incompatibility but in my opinion, this incompatibility is not necessary in the general case.
* | Always pass the `--all` flag when neededremove_bundle_update_deprecationsDavid Rodríguez2019-03-303-10/+10
| |
* | Remove `bundle config` deprecations from specsremove_bundle_config_deprecationsDavid Rodríguez2019-03-293-3/+3
|/
* Reword deprecation messagesDavid Rodríguez2019-02-211-6/+6
| | | | | | Including the version is confusing, in my opinion, because it's unclear whether it refers to the future version of removal, or to the current running version.
* Change some specs checking the wrong streamDavid Rodríguez2019-02-211-2/+2
|
* Use newest interface to `bundle config` everywhereDavid Rodríguez2019-02-191-1/+1
|
* Fix 1.x specscheck_out_only_in_specsDavid Rodríguez2019-02-141-1/+1
|
* Remove now unnecessary `lack_errors` matcherDavid Rodríguez2019-02-141-1/+1
| | | | | Since the errors are checked on their own stream, no filtering is needed.
* Split stderr and stdout in specsDavid Rodríguez2019-02-141-2/+2
|
* Improve redownload specsmore_assertionsDavid Rodríguez2018-09-241-3/+13
| | | | So they are run on bundler 1.x too.
* Limit redownload specs to bundler 2better_force_to_redownload_transitionDavid Rodríguez2018-09-191-1/+1
|
* Make the equivalent change to `bundle update`David Rodríguez2018-09-181-0/+34
|
* fix whitespace to make rubocop happy and add spacing between `it blocksColby Swandale2018-01-271-1/+2
|
* Added a note about why `BUNDLE_GEMFILE` is specified in these specsJoel Van Horn2018-01-251-0/+2
|
* Added spacing and `before` in specJoel Van Horn2018-01-251-2/+4
|
* Added `--gemfile` option to `bundle update`Joel Van Horn2018-01-241-0/+61
|
* Fixed failing examples for Bundler 2 APISHIBATA Hiroshi2017-12-111-1/+1
|
* Fixed failing examples with Ruby 2.5.SHIBATA Hiroshi2017-12-111-2/+2
| | | | | It's introduced by URI::Generic channges. https://github.com/ruby/ruby/commit/ed48bfa5e8770a345424abd7f24f94ea9bbf5973
* Automatically bundle clean without a path set on 2.0Samuel Giddins2017-08-281-6/+12
|
* Untangle the system gem path and the default bundle path in the specsSamuel Giddins2017-07-241-2/+2
|
* Update specs for the specific platform being added to the lockfileSamuel Giddins2017-07-051-1/+1
| | | | Also ensure the resolver processes specs in the correct order for error messages
* Update the Bundler 2 specs for the removal of using... messagesseg-suppress-using-messagesSamuel Giddins2017-07-031-3/+2
|
* Get the Bundler 2 specs passing with transitive source pinningSamuel Giddins2017-06-231-1/+37
|
* Get the 2.0 specs passing under 2.0Samuel Giddins2017-06-232-7/+8
|
* Specify `--require spec_helper` in .rspecKoichi ITO2017-05-033-3/+0
|
* Disable RSpec monkey patchingSamuel Giddins2017-01-153-3/+3
|
* Use `bundle!` in specsJason King2016-12-091-4/+4
|
* Specs for update post-install messagesJason King2016-12-081-0/+77
|
* Remove expect_err from the specs & print all output on a spec failureSamuel Giddins2016-08-031-4/+4
|
* Use `include_gem` as the matcher nameSamuel Giddins2016-08-021-6/+6
|
* [Matchers] Add TheBundle class to make custom matchers more fluentSamuel Giddins2016-08-021-6/+6
|
* Add Bundler.ui.deprecateStefan Lance2016-07-051-1/+1
|
* [GitProxy] Only try and submodule deinit on git 2.9.0+seg-deinit-submodulesSamuel Giddins2016-06-271-1/+1
|
* [GitProxy] Deinit submodules if they are not requestedSamuel Giddins2016-06-241-1/+0
|
* Compatibility with frozen string literalsSamuel Giddins2016-01-312-0/+2
|
* Clean up "Cloning into 'submodule-1.0'..." output messages from test suiteJames Wen2015-12-301-3/+3
| | | | | | | | - Removes the following output messages from the test suite: ``` Cloning into 'submodule-1.0'... done. ```
* Nix the gem_helpers method in `Bundler::Dsl`Mike Virata-Stone2015-12-151-1/+1
| | | | | | New generic_local_platform to remove all the `generic(Gem::Platform.local)` calls Make `generic` and `generic_local_platform` module functions Thanks to @segiddins for the idea!
* [RuboCop] Enable Style/PercentLiteralDelimitersSamuel Giddins2015-11-261-1/+1
|
* Include revision hash in Source::Git#to_sshow-git-revAgis Anastasopoulos2015-10-251-2/+2
| | | | | | | | | This effectively changes the output of commands that use Source::Git#to_s (ie. `bundle install`). For example: Using rack 1.0.0 from git@github.com:rack/rack.git (at master@574b147) Closes #3433.
* [Path] Update spec for wrapping path in backticksSamuel Giddins2015-10-021-1/+1
|
* fixup! Add test for updating gems on source when source differs to nameCaden Lovelace2015-08-231-39/+39
|
* Add test for updating gems on source when source differs to nameCaden Lovelace2015-08-231-0/+51
|
* Fix Style/SingleSpaceBeforeFirstArgErick Sasse2015-07-191-2/+2
|
View Lorry Controller Status